[OpenSmalltalk/opensmalltalk-vm] Seqfault on startin gLinux64 (#433)

 

It seems that after ba7bb95 a seqfault was introduced to the 64bit Linux VM. With no image file the VM happily produces output. When providing an image file it immediately segfaults regardless of whether a display is provided or whether it runs headless.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/433?email_source=notifications\u0026email_token=AIJPEW4D3BQVQWF327VHUBDQPAZS5A5CNFSM4JBXERYKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HSNCSSQ", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/433?email_source=notifications\u0026email_token=AIJPEW4D3BQVQWF327VHUBDQPAZS5A5CNFSM4JBXERYKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HSNCSSQ", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 
Hi Patrick,


> On Oct 17, 2019, at 3:00 AM, Patrick R <[hidden email]> wrote:
>
> It seems that after ba7bb95 a seqfault was introduced to the 64bit Linux VM. With no image file the VM happily produces output. When providing an image file it immediately segfaults regardless of whether a display is provided or whether it runs headless.
>

can you provide some more information? The crash.dmp file perhaps (please generate a fresh one so it contains only one or two crashes). Can you also possible boy disassemble the trampoline table to see what code is generated for s stack switch? Any of the send trampolines will do. To do this, in gdb put s breakpoint in interpret, run and proceed once, then call printTrampolineTable(), and then disassemble a send routine using a pair of addresses from the output.

AdvThanksance

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/433?email_source=notifications\u0026email_token=AIJPEW3BYA2QM3YRC6FLJBLQPBDDHA5CNFSM4JBXERYKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBPXWIA#issuecomment-543128352", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/433?email_source=notifications\u0026email_token=AIJPEW3BYA2QM3YRC6FLJBLQPBDDHA5CNFSM4JBXERYKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBPXWIA#issuecomment-543128352", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 

I'm trying to isolate the problem too. It might have something to do with my recent change to the dependencies, although I doubt it. I'll get back to you when I know more.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/433?email_source=notifications\u0026email_token=AIJPEW6ECU737HXOTRI3ALTQPCHZLA5CNFSM4JBXERYKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBQXLFI#issuecomment-543258005", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/433?email_source=notifications\u0026email_token=AIJPEW6ECU737HXOTRI3ALTQPCHZLA5CNFSM4JBXERYKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBQXLFI#issuecomment-543258005", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 

@eliotmiranda The commit that introduced the segfault is 30220af.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/433?email_source=notifications\u0026email_token=AIJPEW3A6OUK6BWLTUL2RSTQPCK5NA5CNFSM4JBXERYKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBQ2AWA#issuecomment-543268952", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/433?email_source=notifications\u0026email_token=AIJPEW3A6OUK6BWLTUL2RSTQPCK5NA5CNFSM4JBXERYKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBQ2AWA#issuecomment-543268952", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 

Can confirm @theseion 's finding after a bisect. The crash does not occur on debug builds for me, unfortunately. This is the stack I get in a production build:

(gdb) bt
#0  0x0000555555a0003d in ?? ()
#1  0x0000555555b5e000 in ?? ()
#2  0x000055555560a1b1 in generateStackPointerCapture () at /home/tom/Code/squeak/opensmalltalk-vm/spur64src/vm/cogitX64SysV.c:7255
#3  initializeCodeZoneFromupTo (startAddress=<optimized out>, endAddress=93824996104024) at /home/tom/Code/squeak/opensmalltalk-vm/spur64src/vm/cogitX64SysV.c:7903
#4  0x00005555555b8559 in readImageFromFileHeapSizeStartingAt (f=<optimized out>, desiredHeapSize=<optimized out>, imageOffset=<optimized out>)
    at /home/tom/Code/squeak/opensmalltalk-vm/spur64src/vm/gcc3x-cointerp.c:20588
#5  0x00005555555894c0 in imgInit () at /home/tom/Code/squeak/opensmalltalk-vm/platforms/unix/vm/sqUnixMain.c:1971
#6  0x0000555555585c62 in main (argc=<optimized out>, argv=0x7fffffffd4a8, envp=<optimized out>) at /home/tom/Code/squeak/opensmalltalk-vm/platforms/unix/vm/sqUnixMain.c:2095
(gdb) 

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/433?email_source=notifications\u0026email_token=AIJPEW4ON47R7JERXX3MGODQPLASXA5CNFSM4JBXERYKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBXIWQQ#issuecomment-544115522", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/433?email_source=notifications\u0026email_token=AIJPEW4ON47R7JERXX3MGODQPLASXA5CNFSM4JBXERYKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBXIWQQ#issuecomment-544115522", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 

Same here:

Program received signal SIGSEGV, Segmentation fault.
0x000000000090003a in ?? ()
(gdb) bt
#0 0x000000000090003a in ?? ()
#1 0x0000000000a5e000 in ?? ()
#2 0x000000000049ce86 in generateStackPointerCapture ()
at /media/psf/Home/Smalltalk/OpenSmalltalk/opensmalltalk-vm/spur64src/vm/cogitX64SysV.c:7255
#3 initializeCodeZoneFromupTo (startAddress=, endAddress=7980952)
at /media/psf/Home/Smalltalk/OpenSmalltalk/opensmalltalk-vm/spur64src/vm/cogitX64SysV.c:7903
#4 0x000000000044c69d in readImageFromFileHeapSizeStartingAt (f=f@entry=0x85df20,
desiredHeapSize=desiredHeapSize@entry=0, imageOffset=imageOffset@entry=0)
at /media/psf/Home/Smalltalk/OpenSmalltalk/opensmalltalk-vm/spur64src/vm/gcc3x-cointerp.c:20588
#5 0x000000000041e142 in imgInit ()
at /media/psf/Home/Smalltalk/OpenSmalltalk/opensmalltalk-vm/platforms/unix/vm/sqUnixMain.c:1971
#6 0x000000000041aee1 in main (argc=, argv=0x7fffffffdd88, envp=)
at /media/psf/Home/Smalltalk/OpenSmalltalk/opensmalltalk-vm/platforms/unix/vm/sqUnixMain.c:2095

(gdb) call printTrampolineTable()
0x900000: ceCheckLZCNTFunction
0x900018: ceGetFP
0x900020: ceGetSP
0x900028: ceCaptureCStackPointers

(gdb) x/4i 0x900018
0x900018: mov %rbp,%rax
0x90001b: retq
0x90001c: int3
0x90001d: int3
(gdb) x/4i 0x900020
0x900020: mov %rsp,%rax
0x900023: add $0x8,%rax
0x900027: retq
0x900028: push %rbx
(gdb) x/11i 0x900028
0x900028: push %rbx
0x900029: mov $0x79c798,%rbx
0x900030: movabs %rax,0x79c420
=> 0x90003a: add %al,(%rax)
0x90003c: add %cl,-0x77(%rax)
0x90003f: loopne 0x900089
0x900041: add $0x10,%eax
0x900044: movabs %rax,0x79c418
0x90004e: pop %rbx
0x90004f: retq
0x900050: int3

It looks like the generated method got corrupted again...

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/433?email_source=notifications\u0026email_token=AIJPEW2L5Z7IN3EKJEIRNHDQPN6SBA5CNFSM4JBXERYKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBX5MQQ#issuecomment-544200258", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/433?email_source=notifications\u0026email_token=AIJPEW2L5Z7IN3EKJEIRNHDQPN6SBA5CNFSM4JBXERYKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBX5MQQ#issuecomment-544200258", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 

However, if I use build.lix64x64/squeak.cog.spur/build_clang/mvm, I then get a working VM.
I suggest using clang until we find the problem...

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/433?email_source=notifications\u0026email_token=AIJPEW34TDN7KQM3JR3ZXXDQPN7VTA5CNFSM4JBXERYKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBX5Q3I#issuecomment-544200813", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/433?email_source=notifications\u0026email_token=AIJPEW34TDN7KQM3JR3ZXXDQPN7VTA5CNFSM4JBXERYKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBX5Q3I#issuecomment-544200813", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 

May I close this one?
I got literally NO feedback...

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/433?email_source=notifications\u0026email_token=AIJPEWZHCX5ERYK5WEN5YGDQTGMBDA5CNFSM4JBXERYKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDXTEVI#issuecomment-552546901", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/433?email_source=notifications\u0026email_token=AIJPEWZHCX5ERYK5WEN5YGDQTGMBDA5CNFSM4JBXERYKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDXTEVI#issuecomment-552546901", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 

Sorry about that, I had interpreted your comment as a suggestion. Did you change the build process to use Clang instead of GCC? In that case I'll have to check again. I'll do that tonight.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/433?email_source=notifications\u0026email_token=AIJPEW3XQR5HVYDWFVYZ7J3QTJQCJA5CNFSM4JBXERYKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDZMLWI#issuecomment-552781273", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/433?email_source=notifications\u0026email_token=AIJPEW3XQR5HVYDWFVYZ7J3QTJQCJA5CNFSM4JBXERYKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDZMLWI#issuecomment-552781273", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 

Yes, see merged PR above. It's only a workaround, not a root cause analysis + solving. But since we have similar workaround already for Win64, we can live with it for a while...
In the mid term, we HAVE TO gain deeper understanding because changing the compiler is hardly a sustainable solution (and it's one shot)...
So we might want to keep this issue open, or create another one with different milestones
(if we start using milestones...)

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/433?email_source=notifications\u0026email_token=AIJPEW7Q52ZU3RRQO7CPRR3QTLWJZA5CNFSM4JBXERYKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOED3GX4Y#issuecomment-553020403", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/433?email_source=notifications\u0026email_token=AIJPEW7Q52ZU3RRQO7CPRR3QTLWJZA5CNFSM4JBXERYKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOED3GX4Y#issuecomment-553020403", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 

I have to postpone this until at least tomorrow evening. Sorry.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/433?email_source=notifications\u0026email_token=AIJPEW5PHWLFJELJB35KXW3QTMO33A5CNFSM4JBXERYKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOED4AZKI#issuecomment-553127081", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/433?email_source=notifications\u0026email_token=AIJPEW5PHWLFJELJB35KXW3QTMO33A5CNFSM4JBXERYKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOED4AZKI#issuecomment-553127081", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 

Yes, using Clang fixes the segfault. Thanks Nicolas!

If you already have such a workaround for Windows, I guess it would be a good idea to have a separate issue for reverting back to GCC (or whatever the plan might be then). You can go ahead and close this issue.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/433?email_source=notifications\u0026email_token=AIJPEW2WQCC6ZURQPG52LHDQTRR4FA5CNFSM4JBXERYKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOED7TF7I#issuecomment-553595645", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/433?email_source=notifications\u0026email_token=AIJPEW2WQCC6ZURQPG52LHDQTRR4FA5CNFSM4JBXERYKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOED7TF7I#issuecomment-553595645", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 

So I close the issue since the workaround works

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/433?email_source=notifications\u0026email_token=AIJPEW3EMBIPDUG2GNJOE3LQT3XEXA5CNFSM4JBXERYKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEGNBUI#issuecomment-554488017", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/433?email_source=notifications\u0026email_token=AIJPEW3EMBIPDUG2GNJOE3LQT3XEXA5CNFSM4JBXERYKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEGNBUI#issuecomment-554488017", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 

Closed #433.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/433?email_source=notifications\u0026email_token=AIJPEWZQVOHYBZ4XIXA7YXDQT3XEZA5CNFSM4JBXERYKYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOU4OKMTI#event-2803672653", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/433?email_source=notifications\u0026email_token=AIJPEWZQVOHYBZ4XIXA7YXDQT3XEZA5CNFSM4JBXERYKYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOU4OKMTI#event-2803672653", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>