[OpenSmalltalk/opensmalltalk-vm] Simplify sqUnixMain.c's imgInit() (#530)

 

• use sqImageFileOpen() to open the image file
• use file descriptors only to avoid leaking a FILE struct
• removed the ability to let winImageFind manipulate the file some way
  (only supported by the Quartz display anyway)
• removed the loop retrying opening the file again because that relied on
  winImageFind
• reformatted the code to follow the formatting guidelines (it was a
  bit messy)

---

You can view, comment on, or merge this pull request online at:

  https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/530

Commit Summary

• Simplify sqUnixMain.c's imgInit()

File Changes

• M platforms/unix/vm/sqUnixMain.c (64)

Patch Links:

• https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/530.patch
• https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/530.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/530", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/530", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 

@eliotmiranda approved this pull request.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/530#pullrequestreview-518825978", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/530#pullrequestreview-518825978", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 

Merged #530 into Cog.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/530#event-3932087972", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/530#event-3932087972", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>