[OpenSmalltalk/opensmalltalk-vm] Some sound_RecordSamplesIntoAtLength implementations are not compatible with 64bits (#240)

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[OpenSmalltalk/opensmalltalk-vm] Some sound_RecordSamplesIntoAtLength implementations are not compatible with 64bits (#240)

David T Lewis
 

For example, vm-sound-NAS is trying to pass the buffer address thru an int.
That ain't gonna work.
We shall review all the implementations and declare void *buf.
This is related to old report http://bugs.squeak.org/view.php?id=7835.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Some sound_RecordSamplesIntoAtLength implementations are not compatible with 64bits (#240)"}],"action":{"name":"View Issue","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/240"}}}</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] Some sound_RecordSamplesIntoAtLength implementations are not compatible with 64bits (#240)

David T Lewis
 

Same weirdness for sound_PlaySamplesFromAtLength

Note that a few implementations are legacy-interpreter-friendly:
we pass a sqInt which is transformed into a pointer via pointerForOop
This is for 32bits image on 64bits VM compatibility for example.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@nicolas-cellier-aka-nice in #240: Same weirdness for sound_PlaySamplesFromAtLength\r\n\r\nNote that a few implementations are legacy-interpreter-friendly:\r\nwe pass a sqInt which is transformed into a pointer via pointerForOop\r\nThis is for 32bits image on 64bits VM compatibility for example."}],"action":{"name":"View Issue","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/240#issuecomment-379464545"}}}</script>