[OpenSmalltalk/opensmalltalk-vm] Update sqUnixExternalPrims.c (#179)

 

I'm pretty certain that
#include <errno.h>
is the right way to do it everywhere.

---

You can view, comment on, or merge this pull request online at:

  https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/179

Commit Summary

• Update sqUnixExternalPrims.c

File Changes

• M platforms/unix/vm/sqUnixExternalPrims.c (6)

Patch Links:

• https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/179.patch
• https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/179.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Update sqUnixExternalPrims.c (#179)"}],"action":{"name":"View Pull Request","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/179"}}}</script>

 

@aryler pushed 1 commit.

• 4254da4 Shouldn't need sys/errno.h if errno.h already #include'd

—
You are receiving this because you are subscribed to this thread.
View it on GitHub or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@aryler pushed 1 commit in #179"}],"action":{"name":"View Pull Request","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/179/files/41471fd89760894167f7de7927b6add615451407..4254da4bef28784ccbb074e35d5e9dc917089edb"}}}</script>

 

@aryler pushed 1 commit.

• d7356df I think this should also be just errno.h, not sys/errno.h

—
You are receiving this because you are subscribed to this thread.
View it on GitHub or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@aryler pushed 1 commit in #179"}],"action":{"name":"View Pull Request","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/179/files/4254da4bef28784ccbb074e35d5e9dc917089edb..d7356dfb8aadbb011642982f446f8950c3e905b1"}}}</script>

 

It sounds correct, I verified man errno for freebsd, openbsd, linux and all mention <errno.h>
I think it comes from macos, where man errno does not answer anything usefull...
But where I get this answer to man 2 intro

NAME
intro -- introduction to system calls and error numbers

SYNOPSIS
#include <sys/errno.h>

DESCRIPTION
This section provides an overview of the system calls, their error returns, and other common
definitions and concepts.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@nicolas-cellier-aka-nice in #179: It sounds correct, I verified `man errno` for freebsd, openbsd, linux and all mention `\u003cerrno.h\u003e`\r\nI think it comes from macos, where `man errno` does not answer anything usefull...\r\nBut where I get this answer to `man 2 intro`\r\n\r\n**NAME**\r\n intro -- introduction to system calls and error numbers\r\n\r\n**SYNOPSIS**\r\n #include \u003csys/errno.h\u003e\r\n\r\n**DESCRIPTION**\r\n This section provides an overview of the system calls, their error returns, and other common\r\n definitions and concepts."}],"action":{"name":"View Pull Request","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/179#issuecomment-355132424"}}}</script>

 

MacOS seems to be the only one that specifies sys/errno.h in documentation.
But if that were necessary then I suspect sys/errno.h would be found in more places in the codebase.
Even in the MacOS dir there are plenty of plain errno.h's.
Plain errno.h is POSIX.
I'm pretty certain it's normal for errno.h to #include sys/errno.h.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@aryler in #179: MacOS seems to be the only one that specifies sys/errno.h in documentation.\r\nBut if that were necessary then I suspect sys/errno.h would be found in more places in the codebase.\r\nEven in the MacOS dir there are plenty of plain errno.h's.\r\nPlain errno.h is POSIX.\r\nI'm pretty certain it's normal for errno.h to #include sys/errno.h."}],"action":{"name":"View Pull Request","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/179#issuecomment-355142970"}}}</script>

 

Merged #179.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Merged #179."}],"action":{"name":"View Pull Request","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/179#event-1409107170"}}}</script>