[OpenSmalltalk/opensmalltalk-vm] Use Metal instead of OpenGL for the main VM Window in OS X (#306)

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
22 messages Options
12
Reply | Threaded
Open this post in threaded view
|

[OpenSmalltalk/opensmalltalk-vm] Use Metal instead of OpenGL for the main VM Window in OS X (#306)

Pablo Tesone
 

Because OpenGL is being deprecated by Apple, use Metal instead of OpenGL for main VM window in OS X.

Metal only works in 64 bits mode. So, I also made the needed changes to keep using OpenGL in the 32 bits version of the OS X VM.


You can view, comment on, or merge this pull request online at:

  https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/306

Commit Summary

  • I ported the main OS X view from OpenGL into Metal.
  • Disable restoring OpenGL context hack in ioProcessEvents when using Metal for the main window.

File Changes

Patch Links:


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Use Metal instead of OpenGL for the main VM Window in OS X (#306)"}],"action":{"name":"View Pull Request","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/306"}}}</script> <script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/306", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/306", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } }, { "@type": "MessageCard", "@context": "http://schema.org/extensions", "hideOriginalBody": "false", "originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB", "title": "Use Metal instead of OpenGL for the main VM Window in OS X (#306)", "sections": [ { "text": "", "activityTitle": "**Ronie Salgado**", "activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png", "activitySubtitle": "@ronsaldo", "facts": [ ] }, { "title": "Commit Summary", "facts": [ { "name": "f74c43a", "value": "I ported the main OS X view from OpenGL into Metal." }, { "name": "534db29", "value": "Disable restoring OpenGL context hack in ioProcessEvents when using Metal for the main window." } ] }, { "title": "File Changes", "facts": [ { "name": "Modified", "value": "[build.macos32x86/common/Makefile.app](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/306/files#diff-0) (4 changes)" }, { "name": "Modified", "value": "[build.macos32x86/common/Makefile.flags](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/306/files#diff-1) (2 changes)" }, { "name": "Modified", "value": "[build.macos64x64/common/Makefile.app](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/306/files#diff-2) (8 changes)" }, { "name": "Modified", "value": "[build.macos64x64/common/Makefile.flags](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/306/files#diff-3) (7 changes)" }, { "name": "Modified", "value": "[build.macos64x64/common/Makefile.rules](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/306/files#diff-4) (10 changes)" }, { "name": "Modified", "value": "[build.macos64x64/common/Makefile.vm](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/306/files#diff-5) (1 changes)" }, { "name": "Modified", "value": "[platforms/iOS/vm/Common/Classes/sqSqueakEventsAPI.m](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/306/files#diff-6) (14 changes)" }, { "name": "Added", "value": "[platforms/iOS/vm/English.lproj/MainMenu-opengl.xib](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/306/files#diff-7) (1261 changes)" }, { "name": "Modified", "value": "[platforms/iOS/vm/English.lproj/MainMenu.xib](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/306/files#diff-8) (8 changes)" }, { "name": "Modified", "value": "[platforms/iOS/vm/OSX/SqViewBitmapConversion.m](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/306/files#diff-9) (5 changes)" }, { "name": "Modified", "value": "[platforms/iOS/vm/OSX/SqViewClut.m](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/306/files#diff-10) (5 changes)" }, { "name": "Added", "value": "[platforms/iOS/vm/OSX/SqueakMainShaders.metal](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/306/files#diff-11) (73 changes)" }, { "name": "Modified", "value": "[platforms/iOS/vm/OSX/SqueakOSXAppDelegate.m](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/306/files#diff-12) (5 changes)" }, { "name": "Added", "value": "[platforms/iOS/vm/OSX/sqSqueakOSXMetalView.h](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/306/files#diff-13) (93 changes)" }, { "name": "Added", "value": "[platforms/iOS/vm/OSX/sqSqueakOSXMetalView.m](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/306/files#diff-14) (772 changes)" } ] } ], "potentialAction": [ { "name": "Add a comment", "@type": "ActionCard", "inputs": [ { "isMultiLine": true, "@type": "TextInput", "id": "IssueComment", "isRequired": false } ], "actions": [ { "name": "Comment", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"OpenSmalltalk/opensmalltalk-vm\",\n\"issueId\": 306,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}" } ] }, { "name": "Close pull request", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"OpenSmalltalk/opensmalltalk-vm\",\n\"pullRequestId\": 306\n}" }, { "targets": [ { "os": "default", "uri": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/306" } ], "@type": "OpenUri", "name": "View on GitHub" }, { "targets": [ { "os": "default", "uri": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/306.patch" } ], "@type": "OpenUri", "name": "View patch" }, { "targets": [ { "os": "default", "uri": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/306.diff" } ], "@type": "OpenUri", "name": "View diff" }, { "name": "Unsubscribe", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 409039196\n}" } ], "themeColor": "26292E" } ]</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] Use Metal instead of OpenGL for the main VM Window in OS X (#306)

Pablo Tesone
 

@ronsaldo pushed 1 commit.

  • ea78e18 Set the version of the metal shading language to use.


You are receiving this because you are subscribed to this thread.
View it on GitHub or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@ronsaldo pushed 1 commit in #306"}],"action":{"name":"View Pull Request","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/306/files/534db294809a6c23ad44eff0ff2b41cc2bd5ec66..ea78e18f6911dc554cdd3be6b2c4a82a322d0605"}}}</script> <script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/306/files/534db294809a6c23ad44eff0ff2b41cc2bd5ec66..ea78e18f6911dc554cdd3be6b2c4a82a322d0605", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/306/files/534db294809a6c23ad44eff0ff2b41cc2bd5ec66..ea78e18f6911dc554cdd3be6b2c4a82a322d0605", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } }, { "@type": "MessageCard", "@context": "http://schema.org/extensions", "hideOriginalBody": "false", "originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB", "title": "@ronsaldo pushed 1 commit in #306", "sections": [ { "text": "1 new commit pushed to OpenSmalltalk/opensmalltalk-vm #306:", "activityTitle": "**Ronie Salgado**", "activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png", "activitySubtitle": "@ronsaldo", "facts": [ { "name": "ea78e18", "value": "Set the version of the metal shading language to use." } ] } ], "potentialAction": [ { "targets": [ { "os": "default", "uri": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/306/files/534db294809a6c23ad44eff0ff2b41cc2bd5ec66..ea78e18f6911dc554cdd3be6b2c4a82a322d0605" } ], "@type": "OpenUri", "name": "View on GitHub" }, { "name": "Unsubscribe", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 409039196\n}" } ], "themeColor": "26292E" } ]</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] Use Metal instead of OpenGL for the main VM Window in OS X (#306)

Pablo Tesone
In reply to this post by Pablo Tesone
 

This is great! Could @johnmci have a look at this please? I'm not very familiar with the OpenGL API or Metal API...


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@fniephaus in #306: This is great! Could @johnmci have a look at this please? I'm not very familiar with the OpenGL API or Metal API..."}],"action":{"name":"View Pull Request","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/306#issuecomment-437650704"}}}</script> <script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/306#issuecomment-437650704", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/306#issuecomment-437650704", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } }, { "@type": "MessageCard", "@context": "http://schema.org/extensions", "hideOriginalBody": "false", "originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB", "title": "Re: [OpenSmalltalk/opensmalltalk-vm] Use Metal instead of OpenGL for the main VM Window in OS X (#306)", "sections": [ { "text": "", "activityTitle": "**Fabio Niephaus**", "activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png", "activitySubtitle": "@fniephaus", "facts": [ ] } ], "potentialAction": [ { "name": "Add a comment", "@type": "ActionCard", "inputs": [ { "isMultiLine": true, "@type": "TextInput", "id": "IssueComment", "isRequired": false } ], "actions": [ { "name": "Comment", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"OpenSmalltalk/opensmalltalk-vm\",\n\"issueId\": 306,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}" } ] }, { "name": "Close pull request", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"OpenSmalltalk/opensmalltalk-vm\",\n\"pullRequestId\": 306\n}" }, { "targets": [ { "os": "default", "uri": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/306#issuecomment-437650704" } ], "@type": "OpenUri", "name": "View on GitHub" }, { "name": "Unsubscribe", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 409039196\n}" } ], "themeColor": "26292E" } ]</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] Use Metal instead of OpenGL for the main VM Window in OS X (#306)

Pablo Tesone
In reply to this post by Pablo Tesone
 

@ronsaldo pushed 1 commit.

  • 24705af Use osx-metal1.1 instead macos-metal1.1.


You are receiving this because you are subscribed to this thread.
View it on GitHub or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@ronsaldo pushed 1 commit in #306"}],"action":{"name":"View Pull Request","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/306/files/ea78e18f6911dc554cdd3be6b2c4a82a322d0605..24705afc9ca2a4b88ed3eefc12f3a3d184cecf2e"}}}</script> <script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/306/files/ea78e18f6911dc554cdd3be6b2c4a82a322d0605..24705afc9ca2a4b88ed3eefc12f3a3d184cecf2e", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/306/files/ea78e18f6911dc554cdd3be6b2c4a82a322d0605..24705afc9ca2a4b88ed3eefc12f3a3d184cecf2e", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } }, { "@type": "MessageCard", "@context": "http://schema.org/extensions", "hideOriginalBody": "false", "originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB", "title": "@ronsaldo pushed 1 commit in #306", "sections": [ { "text": "1 new commit pushed to OpenSmalltalk/opensmalltalk-vm #306:", "activityTitle": "**Ronie Salgado**", "activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png", "activitySubtitle": "@ronsaldo", "facts": [ { "name": "24705af", "value": "Use osx-metal1.1 instead macos-metal1.1." } ] } ], "potentialAction": [ { "targets": [ { "os": "default", "uri": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/306/files/ea78e18f6911dc554cdd3be6b2c4a82a322d0605..24705afc9ca2a4b88ed3eefc12f3a3d184cecf2e" } ], "@type": "OpenUri", "name": "View on GitHub" }, { "name": "Unsubscribe", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 409039196\n}" } ], "themeColor": "26292E" } ]</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] Use Metal instead of OpenGL for the main VM Window in OS X (#306)

Pablo Tesone
In reply to this post by Pablo Tesone
 

@ronsaldo pushed 1 commit.

  • 367164d Another attempt to build shaders on CI.


You are receiving this because you are subscribed to this thread.
View it on GitHub or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@ronsaldo pushed 1 commit in #306"}],"action":{"name":"View Pull Request","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/306/files/24705afc9ca2a4b88ed3eefc12f3a3d184cecf2e..367164db1bcab073393974b5b1ee658c50f9beac"}}}</script> <script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/306/files/24705afc9ca2a4b88ed3eefc12f3a3d184cecf2e..367164db1bcab073393974b5b1ee658c50f9beac", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/306/files/24705afc9ca2a4b88ed3eefc12f3a3d184cecf2e..367164db1bcab073393974b5b1ee658c50f9beac", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } }, { "@type": "MessageCard", "@context": "http://schema.org/extensions", "hideOriginalBody": "false", "originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB", "title": "@ronsaldo pushed 1 commit in #306", "sections": [ { "text": "1 new commit pushed to OpenSmalltalk/opensmalltalk-vm #306:", "activityTitle": "**Ronie Salgado**", "activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png", "activitySubtitle": "@ronsaldo", "facts": [ { "name": "367164d", "value": "Another attempt to build shaders on CI." } ] } ], "potentialAction": [ { "targets": [ { "os": "default", "uri": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/306/files/24705afc9ca2a4b88ed3eefc12f3a3d184cecf2e..367164db1bcab073393974b5b1ee658c50f9beac" } ], "@type": "OpenUri", "name": "View on GitHub" }, { "name": "Unsubscribe", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 409039196\n}" } ], "themeColor": "26292E" } ]</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] Use Metal instead of OpenGL for the main VM Window in OS X (#306)

Pablo Tesone
In reply to this post by Pablo Tesone
 

@ronsaldo pushed 1 commit.

  • 4380ab9 I added a workaround for the different versions of the metallib tool.


You are receiving this because you are subscribed to this thread.
View it on GitHub or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@ronsaldo pushed 1 commit in #306"}],"action":{"name":"View Pull Request","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/306/files/367164db1bcab073393974b5b1ee658c50f9beac..4380ab9155596d55bc37c5f43167642ecf6f6261"}}}</script> <script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/306/files/367164db1bcab073393974b5b1ee658c50f9beac..4380ab9155596d55bc37c5f43167642ecf6f6261", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/306/files/367164db1bcab073393974b5b1ee658c50f9beac..4380ab9155596d55bc37c5f43167642ecf6f6261", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } }, { "@type": "MessageCard", "@context": "http://schema.org/extensions", "hideOriginalBody": "false", "originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB", "title": "@ronsaldo pushed 1 commit in #306", "sections": [ { "text": "1 new commit pushed to OpenSmalltalk/opensmalltalk-vm #306:", "activityTitle": "**Ronie Salgado**", "activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png", "activitySubtitle": "@ronsaldo", "facts": [ { "name": "4380ab9", "value": "I added a workaround for the different versions of the metallib tool." } ] } ], "potentialAction": [ { "targets": [ { "os": "default", "uri": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/306/files/367164db1bcab073393974b5b1ee658c50f9beac..4380ab9155596d55bc37c5f43167642ecf6f6261" } ], "@type": "OpenUri", "name": "View on GitHub" }, { "name": "Unsubscribe", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 409039196\n}" } ], "themeColor": "26292E" } ]</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] Use Metal instead of OpenGL for the main VM Window in OS X (#306)

Pablo Tesone
In reply to this post by Pablo Tesone
 

@ronsaldo pushed 1 commit.

  • 8841c0b Embed statically the compiled metal shaders as a workaround for CI problems.


You are receiving this because you are subscribed to this thread.
View it on GitHub or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@ronsaldo pushed 1 commit in #306"}],"action":{"name":"View Pull Request","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/306/files/4380ab9155596d55bc37c5f43167642ecf6f6261..8841c0bfb800bf3c3777c2ec57da4bd6448b78a2"}}}</script> <script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/306/files/4380ab9155596d55bc37c5f43167642ecf6f6261..8841c0bfb800bf3c3777c2ec57da4bd6448b78a2", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/306/files/4380ab9155596d55bc37c5f43167642ecf6f6261..8841c0bfb800bf3c3777c2ec57da4bd6448b78a2", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } }, { "@type": "MessageCard", "@context": "http://schema.org/extensions", "hideOriginalBody": "false", "originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB", "title": "@ronsaldo pushed 1 commit in #306", "sections": [ { "text": "1 new commit pushed to OpenSmalltalk/opensmalltalk-vm #306:", "activityTitle": "**Ronie Salgado**", "activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png", "activitySubtitle": "@ronsaldo", "facts": [ { "name": "8841c0b", "value": "Embed statically the compiled metal shaders as a workaround for CI problems." } ] } ], "potentialAction": [ { "targets": [ { "os": "default", "uri": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/306/files/4380ab9155596d55bc37c5f43167642ecf6f6261..8841c0bfb800bf3c3777c2ec57da4bd6448b78a2" } ], "@type": "OpenUri", "name": "View on GitHub" }, { "name": "Unsubscribe", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 409039196\n}" } ], "themeColor": "26292E" } ]</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] Use Metal instead of OpenGL for the main VM Window in OS X (#306)

David T. Lewis
In reply to this post by Pablo Tesone
 
On Sat, Nov 10, 2018 at 11:24:46PM -0800, Ronie Salgado wrote:
>  
> Because OpenGL is being deprecated by Apple, use Metal instead of OpenGL for main VM window in OS X.
>

Very nice to see this :-)

Dave

Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] Use Metal instead of OpenGL for the main VM Window in OS X (#306)

Pablo Tesone
In reply to this post by Pablo Tesone
 

@eliotmiranda pushed 1 commit.


You are receiving this because you are subscribed to this thread.
View it on GitHub or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@eliotmiranda pushed 1 commit in #306"}],"action":{"name":"View Pull Request","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/306/files/8841c0bfb800bf3c3777c2ec57da4bd6448b78a2..0b15880b6b9ffc816a951f63270b9a9ea12d5c49"}}}</script> <script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/306/files/8841c0bfb800bf3c3777c2ec57da4bd6448b78a2..0b15880b6b9ffc816a951f63270b9a9ea12d5c49", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/306/files/8841c0bfb800bf3c3777c2ec57da4bd6448b78a2..0b15880b6b9ffc816a951f63270b9a9ea12d5c49", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } }, { "@type": "MessageCard", "@context": "http://schema.org/extensions", "hideOriginalBody": "false", "originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB", "title": "@eliotmiranda pushed 1 commit in #306", "sections": [ { "text": "1 new commit pushed to OpenSmalltalk/opensmalltalk-vm #306:", "activityTitle": "**Eliot Miranda**", "activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png", "activitySubtitle": "@eliotmiranda", "facts": [ { "name": "0b15880", "value": "Update Makefile.app" } ] } ], "potentialAction": [ { "targets": [ { "os": "default", "uri": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/306/files/8841c0bfb800bf3c3777c2ec57da4bd6448b78a2..0b15880b6b9ffc816a951f63270b9a9ea12d5c49" } ], "@type": "OpenUri", "name": "View on GitHub" }, { "name": "Unsubscribe", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 409039196\n}" } ], "themeColor": "26292E" } ]</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] Use Metal instead of OpenGL for the main VM Window in OS X (#306)

Pablo Tesone
In reply to this post by Pablo Tesone
 

@eliotmiranda pushed 1 commit.


You are receiving this because you are subscribed to this thread.
View it on GitHub or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@eliotmiranda pushed 1 commit in #306"}],"action":{"name":"View Pull Request","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/306/files/0b15880b6b9ffc816a951f63270b9a9ea12d5c49..e42d3d1810bb88a43d56cb63c9e7d07fc20d4c4f"}}}</script> <script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/306/files/0b15880b6b9ffc816a951f63270b9a9ea12d5c49..e42d3d1810bb88a43d56cb63c9e7d07fc20d4c4f", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/306/files/0b15880b6b9ffc816a951f63270b9a9ea12d5c49..e42d3d1810bb88a43d56cb63c9e7d07fc20d4c4f", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } }, { "@type": "MessageCard", "@context": "http://schema.org/extensions", "hideOriginalBody": "false", "originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB", "title": "@eliotmiranda pushed 1 commit in #306", "sections": [ { "text": "1 new commit pushed to OpenSmalltalk/opensmalltalk-vm #306:", "activityTitle": "**Eliot Miranda**", "activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png", "activitySubtitle": "@eliotmiranda", "facts": [ { "name": "e42d3d1", "value": "Update Makefile.rules" } ] } ], "potentialAction": [ { "targets": [ { "os": "default", "uri": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/306/files/0b15880b6b9ffc816a951f63270b9a9ea12d5c49..e42d3d1810bb88a43d56cb63c9e7d07fc20d4c4f" } ], "@type": "OpenUri", "name": "View on GitHub" }, { "name": "Unsubscribe", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 409039196\n}" } ], "themeColor": "26292E" } ]</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] Use Metal instead of OpenGL for the main VM Window in OS X (#306)

Pablo Tesone
In reply to this post by Pablo Tesone
 

Hi Ronie, can you add a comment to platforms/iOS/vm/OSX/SqueakMainShaders.metal.inc to explain what's in SqueakMainShaders_metallib? This is some mysterious s&%t ;-)


You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@eliotmiranda in #306: Hi Ronie, can you add a comment to platforms/iOS/vm/OSX/SqueakMainShaders.metal.inc to explain what's in SqueakMainShaders_metallib? This is some mysterious s\u0026%t ;-)"}],"action":{"name":"View Pull Request","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/306#issuecomment-438094554"}}}</script> <script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/306#issuecomment-438094554", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/306#issuecomment-438094554", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } }, { "@type": "MessageCard", "@context": "http://schema.org/extensions", "hideOriginalBody": "false", "originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB", "title": "Re: [OpenSmalltalk/opensmalltalk-vm] Use Metal instead of OpenGL for the main VM Window in OS X (#306)", "sections": [ { "text": "", "activityTitle": "**Eliot Miranda**", "activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png", "activitySubtitle": "@eliotmiranda", "facts": [ ] } ], "potentialAction": [ { "name": "Add a comment", "@type": "ActionCard", "inputs": [ { "isMultiLine": true, "@type": "TextInput", "id": "IssueComment", "isRequired": false } ], "actions": [ { "name": "Comment", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"OpenSmalltalk/opensmalltalk-vm\",\n\"issueId\": 306,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}" } ] }, { "name": "Close pull request", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"OpenSmalltalk/opensmalltalk-vm\",\n\"pullRequestId\": 306\n}" }, { "targets": [ { "os": "default", "uri": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/306#issuecomment-438094554" } ], "@type": "OpenUri", "name": "View on GitHub" }, { "name": "Unsubscribe", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 409039196\n}" } ], "themeColor": "26292E" } ]</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] Use Metal instead of OpenGL for the main VM Window in OS X (#306)

Pablo Tesone
In reply to this post by Pablo Tesone
 

Superb work, Ronie. So thorough. Shame about the selector comparisons in doCommandBySelector:; I know the time isn't an issue but it's ugly :-) I suppose we could implement the selectors instead.


You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@eliotmiranda in #306: Superb work, Ronie. So thorough. Shame about the selector comparisons in doCommandBySelector:; I know the time isn't an issue but it's ugly :-) I suppose we could implement the selectors instead."}],"action":{"name":"View Pull Request","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/306#issuecomment-438095722"}}}</script> <script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/306#issuecomment-438095722", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/306#issuecomment-438095722", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } }, { "@type": "MessageCard", "@context": "http://schema.org/extensions", "hideOriginalBody": "false", "originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB", "title": "Re: [OpenSmalltalk/opensmalltalk-vm] Use Metal instead of OpenGL for the main VM Window in OS X (#306)", "sections": [ { "text": "", "activityTitle": "**Eliot Miranda**", "activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png", "activitySubtitle": "@eliotmiranda", "facts": [ ] } ], "potentialAction": [ { "name": "Add a comment", "@type": "ActionCard", "inputs": [ { "isMultiLine": true, "@type": "TextInput", "id": "IssueComment", "isRequired": false } ], "actions": [ { "name": "Comment", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"OpenSmalltalk/opensmalltalk-vm\",\n\"issueId\": 306,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}" } ] }, { "name": "Close pull request", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"OpenSmalltalk/opensmalltalk-vm\",\n\"pullRequestId\": 306\n}" }, { "targets": [ { "os": "default", "uri": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/306#issuecomment-438095722" } ], "@type": "OpenUri", "name": "View on GitHub" }, { "name": "Unsubscribe", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 409039196\n}" } ], "themeColor": "26292E" } ]</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] Use Metal instead of OpenGL for the main VM Window in OS X (#306)

Pablo Tesone
In reply to this post by Pablo Tesone
 

@ronsaldo pushed 1 commit.

  • 6e1da75 Adding a comment on the embedded compiled shaders.


You are receiving this because you are subscribed to this thread.
View it on GitHub or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@ronsaldo pushed 1 commit in #306"}],"action":{"name":"View Pull Request","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/306/files/e42d3d1810bb88a43d56cb63c9e7d07fc20d4c4f..6e1da7500a653eb906606562145a8f863e25fab4"}}}</script> <script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/306/files/e42d3d1810bb88a43d56cb63c9e7d07fc20d4c4f..6e1da7500a653eb906606562145a8f863e25fab4", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/306/files/e42d3d1810bb88a43d56cb63c9e7d07fc20d4c4f..6e1da7500a653eb906606562145a8f863e25fab4", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } }, { "@type": "MessageCard", "@context": "http://schema.org/extensions", "hideOriginalBody": "false", "originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB", "title": "@ronsaldo pushed 1 commit in #306", "sections": [ { "text": "1 new commit pushed to OpenSmalltalk/opensmalltalk-vm #306:", "activityTitle": "**Ronie Salgado**", "activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png", "activitySubtitle": "@ronsaldo", "facts": [ { "name": "6e1da75", "value": "Adding a comment on the embedded compiled shaders." } ] } ], "potentialAction": [ { "targets": [ { "os": "default", "uri": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/306/files/e42d3d1810bb88a43d56cb63c9e7d07fc20d4c4f..6e1da7500a653eb906606562145a8f863e25fab4" } ], "@type": "OpenUri", "name": "View on GitHub" }, { "name": "Unsubscribe", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 409039196\n}" } ], "themeColor": "26292E" } ]</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] Use Metal instead of OpenGL for the main VM Window in OS X (#306)

Pablo Tesone
In reply to this post by Pablo Tesone
 

About platforms/iOS/vm/OSX/SqueakMainShaders.metal.inc , I agree, but the metal build tools were not working on CI, and I did not want to bump up the required version of XCode. So I ended copying the approach of offline compilation from SDL2. I just added the comment.

Well as for the doCommandBySelector; comparison, I copied most of the event related stuff from the sqSqueakOSXOpenGLView.m and sqSqueakOSXCGView.m . I think that someone else should refactor these parts in order to avoid code duplication.


You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@ronsaldo in #306: About platforms/iOS/vm/OSX/SqueakMainShaders.metal.inc , I agree, but the metal build tools were not working on CI, and I did not want to bump up the required version of XCode. So I ended copying the approach of offline compilation from SDL2. I just added the comment. \r\n\r\nWell as for the doCommandBySelector; comparison, I copied most of the event related stuff from the sqSqueakOSXOpenGLView.m and sqSqueakOSXCGView.m . I think that someone else should refactor these parts in order to avoid code duplication."}],"action":{"name":"View Pull Request","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/306#issuecomment-438145516"}}}</script> <script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/306#issuecomment-438145516", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/306#issuecomment-438145516", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } }, { "@type": "MessageCard", "@context": "http://schema.org/extensions", "hideOriginalBody": "false", "originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB", "title": "Re: [OpenSmalltalk/opensmalltalk-vm] Use Metal instead of OpenGL for the main VM Window in OS X (#306)", "sections": [ { "text": "", "activityTitle": "**Ronie Salgado**", "activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png", "activitySubtitle": "@ronsaldo", "facts": [ ] } ], "potentialAction": [ { "name": "Add a comment", "@type": "ActionCard", "inputs": [ { "isMultiLine": true, "@type": "TextInput", "id": "IssueComment", "isRequired": false } ], "actions": [ { "name": "Comment", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"OpenSmalltalk/opensmalltalk-vm\",\n\"issueId\": 306,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}" } ] }, { "name": "Close pull request", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"OpenSmalltalk/opensmalltalk-vm\",\n\"pullRequestId\": 306\n}" }, { "targets": [ { "os": "default", "uri": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/306#issuecomment-438145516" } ], "@type": "OpenUri", "name": "View on GitHub" }, { "name": "Unsubscribe", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 409039196\n}" } ], "themeColor": "26292E" } ]</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] Use Metal instead of OpenGL for the main VM Window in OS X (#306)

Pablo Tesone
In reply to this post by Pablo Tesone
 

@ronsaldo maybe it's time to bump the macOS version our CI uses? The binaries should still work on older macOS systems, right?


You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@fniephaus in #306: @ronsaldo maybe it's time to bump the macOS version our CI uses? The binaries should still work on older macOS systems, right?"}],"action":{"name":"View Pull Request","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/306#issuecomment-438176566"}}}</script> <script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/306#issuecomment-438176566", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/306#issuecomment-438176566", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } }, { "@type": "MessageCard", "@context": "http://schema.org/extensions", "hideOriginalBody": "false", "originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB", "title": "Re: [OpenSmalltalk/opensmalltalk-vm] Use Metal instead of OpenGL for the main VM Window in OS X (#306)", "sections": [ { "text": "", "activityTitle": "**Fabio Niephaus**", "activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png", "activitySubtitle": "@fniephaus", "facts": [ ] } ], "potentialAction": [ { "name": "Add a comment", "@type": "ActionCard", "inputs": [ { "isMultiLine": true, "@type": "TextInput", "id": "IssueComment", "isRequired": false } ], "actions": [ { "name": "Comment", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"OpenSmalltalk/opensmalltalk-vm\",\n\"issueId\": 306,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}" } ] }, { "name": "Close pull request", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"OpenSmalltalk/opensmalltalk-vm\",\n\"pullRequestId\": 306\n}" }, { "targets": [ { "os": "default", "uri": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/306#issuecomment-438176566" } ], "@type": "OpenUri", "name": "View on GitHub" }, { "name": "Unsubscribe", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 409039196\n}" } ], "themeColor": "26292E" } ]</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] Use Metal instead of OpenGL for the main VM Window in OS X (#306)

Pablo Tesone
In reply to this post by Pablo Tesone
 

Lets not allow this go stale. What is blocking it?
Can the CI be bumped to check how it fits with recent movement of Cog branch.
@eliotmiranda, are you satisfied with Ronnie's commit 6e1da75?
@fniephaus, unless its blocking, lets move any macOS version bump to a separate issue.
@johnmci, are you available to review? otherwise please advise us not to wait.


You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@bencoman in #306: Lets not allow this go stale. What is blocking it? \r\nCan the CI be bumped to check how it fits with recent movement of Cog branch. \r\n@eliotmiranda, are you satisfied with Ronnie's commit 6e1da75?\r\n@fniephaus, unless its blocking, lets move any macOS version bump to a separate issue.\r\n @johnmci, are you available to review? otherwise please advise us not to wait."}],"action":{"name":"View Pull Request","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/306#issuecomment-451131583"}}}</script> <script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/306#issuecomment-451131583", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/306#issuecomment-451131583", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] Use Metal instead of OpenGL for the main VM Window in OS X (#306)

Pablo Tesone
In reply to this post by Pablo Tesone
 

Please respond...
@eliotmiranda, are you satisfied with Ronnie's commit 6e1da75?
@johnmci, are you available to review as Fabio requested? otherwise please advise us not to wait.
@fniephaus, unless its blocking, can any macOS version bump be done in a separate issue?


You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@bencoman in #306: Please respond...\r\n@eliotmiranda, are you satisfied with Ronnie's commit 6e1da75?\r\n@johnmci, are you available to review as Fabio requested? otherwise please advise us not to wait.\r\n@fniephaus, unless its blocking, can any macOS version bump be done in a separate issue?"}],"action":{"name":"View Pull Request","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/306#issuecomment-453089627"}}}</script> <script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/306#issuecomment-453089627", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/306#issuecomment-453089627", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] Use Metal instead of OpenGL for the main VM Window in OS X (#306)

Pablo Tesone
In reply to this post by Pablo Tesone
 

unless its blocking, can any macOS version bump be done in a separate issue?

Sure, no need to bump the version at all if it's not required by this change.


You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@fniephaus in #306: \u003e unless its blocking, can any macOS version bump be done in a separate issue?\r\n\r\nSure, no need to bump the version at all if it's not required by this change."}],"action":{"name":"View Pull Request","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/306#issuecomment-453280755"}}}</script> <script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/306#issuecomment-453280755", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/306#issuecomment-453280755", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] Use Metal instead of OpenGL for the main VM Window in OS X (#306)

Pablo Tesone
In reply to this post by Pablo Tesone
 

I got super excited about this PR again, so I merged it locally into Cog and build a Squeak VM. I'm on macOS Mojave and my MacBook has a Retina Display. Unfortunately, I am seeing this when opening the Squeak-5.2 release image:

image

Mouse events seem to work fine, so only the rendering is off for some reason.


You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@fniephaus in #306: I got super excited about this PR again, so I merged it locally into `Cog` and build a Squeak VM. I'm on macOS Mojave and my MacBook has a Retina Display. Unfortunately, I am seeing this when opening the Squeak-5.2 release image:\r\n\r\n![image](https://user-images.githubusercontent.com/2368856/51002398-6dbb0800-1533-11e9-9b30-9dc33d2e9236.png)\r\n\r\nMouse events seem to work fine, so only the rendering is off for some reason."}],"action":{"name":"View Pull Request","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/306#issuecomment-453290159"}}}</script> <script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/306#issuecomment-453290159", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/306#issuecomment-453290159", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] Use Metal instead of OpenGL for the main VM Window in OS X (#306)

Pablo Tesone
In reply to this post by Pablo Tesone
 

@fniephaus commented on this pull request.


In platforms/iOS/vm/OSX/sqSqueakOSXMetalView.m:

> +	// Alawys try to fill the texture with the pixels.
+	if ( fullScreendispBitsIndex ) {
+		[self loadTexturesFrom: fullScreendispBitsIndex subRectangle: (clippyIsEmpty ? rect : NSRectFromCGRect(clippy))];
+		//[self loadTexturesFrom: fullScreendispBitsIndex subRectangle: rect];
+		clippyIsEmpty = YES;
+	    syncNeeded = NO;
+	}
+	
+	MTLRenderPassDescriptor *renderPassDescriptor = self.currentRenderPassDescriptor;
+	if(renderPassDescriptor != nil && self.currentDrawable)
+	{
+		currentCommandBuffer = [graphicsCommandQueue commandBuffer];
+		currentRenderEncoder = [currentCommandBuffer renderCommandEncoderWithDescriptor: renderPassDescriptor];
+		
+		// Set the viewport.
+		[currentRenderEncoder setViewport: (MTLViewport){0.0, 0.0, lastFrameSize.size.width, lastFrameSize.size.height}];

When I change this line to

[currentRenderEncoder setViewport: (MTLViewport){0.0, 0.0, lastFrameSize.size.width * 2, lastFrameSize.size.height * 2}];

the problem I mentioned in #306 (comment) goes away. But this is probably not the right fix.


You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@fniephaus commented on #306"}],"action":{"name":"View Pull Request","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/306#pullrequestreview-191458644"}}}</script> <script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/306#pullrequestreview-191458644", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/306#pullrequestreview-191458644", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>
12