[OpenSmalltalk/opensmalltalk-vm] Use NSWindow API for changing fullscreen mode (#478)

 

instead of going through NSView's API. The latter does offer more options, but messes up the fullscreen mode for some reason (UI becomes unresponsive because input events are no longer received).

Using self.window toggleFullScreen:self also does not mess with additional displays (only the display showing Squeak is put into fullscreen mode).

Please test and review!

---

You can view, comment on, or merge this pull request online at:

  https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/478

Commit Summary

• Use NSWindow API for changing fullscreen mode

File Changes

• M platforms/iOS/vm/OSX/sqSqueakOSXMetalView.m (24)

Patch Links:

• https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/478.patch
• https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/478.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/478?email_source=notifications\u0026email_token=AIJPEW5BZ5GVPNRIRS7OXHTRFDWCVA5CNFSM4K5OE6O2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IRCQO3Q", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/478?email_source=notifications\u0026email_token=AIJPEW5BZ5GVPNRIRS7OXHTRFDWCVA5CNFSM4K5OE6O2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IRCQO3Q", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 

@nicolas-cellier-aka-nice commented on this pull request.

---

In platforms/iOS/vm/OSX/sqSqueakOSXMetalView.m:

> @@ -48,6 +48,7 @@
 
 extern SqueakOSXAppDelegate *gDelegateApp;
 extern struct VirtualMachine* interpreterProxy;
+extern int getFullScreenFlag();

Just a detail, but should be sqInt

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/478?email_source=notifications\u0026email_token=AIJPEW5DEXBIQF34JANKBELRFEOOZA5CNFSM4K5OE6O2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCXLXEOI#pullrequestreview-366441017", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/478?email_source=notifications\u0026email_token=AIJPEW5DEXBIQF34JANKBELRFEOOZA5CNFSM4K5OE6O2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCXLXEOI#pullrequestreview-366441017", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 

@fniephaus commented on this pull request.

---

In platforms/iOS/vm/OSX/sqSqueakOSXMetalView.m:

> @@ -48,6 +48,7 @@
 
 extern SqueakOSXAppDelegate *gDelegateApp;
 extern struct VirtualMachine* interpreterProxy;
+extern int getFullScreenFlag();

Have you given the PR a try locally?

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/478?email_source=notifications\u0026email_token=AIJPEW35G3KZ26V3OMY2TSDRFEOYPA5CNFSM4K5OE6O2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCXLXTEQ#discussion_r385730178", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/478?email_source=notifications\u0026email_token=AIJPEW35G3KZ26V3OMY2TSDRFEOYPA5CNFSM4K5OE6O2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCXLXTEQ#discussion_r385730178", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 

@eliotmiranda commented on this pull request.

Personally I loathe and despise (fullScreen == 0) Correct C is !fullScreen. ;-)

And getFullScreenFlag() == (fullScreen == 1) is better written as getFullScreenFlag() == (fullScreen != 0) (or occasionally one will see getFullScreenFlag() == !!fullScreen).

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/478?email_source=notifications\u0026email_token=AIJPEW3ZACOD5HA33YMWUF3RFESLBA5CNFSM4K5OE6O2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCXL5FXY#pullrequestreview-366465759", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/478?email_source=notifications\u0026email_token=AIJPEW3ZACOD5HA33YMWUF3RFESLBA5CNFSM4K5OE6O2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCXL5FXY#pullrequestreview-366465759", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 

@eliotmiranda approved this pull request.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/478?email_source=notifications\u0026email_token=AIJPEW3IXBLAGV6M65UGOCLRFESOZA5CNFSM4K5OE6O2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCXL5LLI#pullrequestreview-366466477", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/478?email_source=notifications\u0026email_token=AIJPEW3IXBLAGV6M65UGOCLRFESOZA5CNFSM4K5OE6O2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCXL5LLI#pullrequestreview-366466477", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 

@fniephaus pushed 1 commit.

• 1b60d38 Address reviewer feedback [ci skip]

—
You are receiving this because you are subscribed to this thread.
View it on GitHub or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/478/files/05d149fc6a844ed53ee23303cd5b7e4822b03d0b..1b60d38144e319ab8c6e7f2f4b94a8a085da334a?email_source=notifications\u0026email_token=AIJPEW5G4JU33Z6YTHSIICDRFEVKNA5CNFSM4K5OE6O2YY3PNVWWK3TUL52HS4DFXNIHK3DMKJSXC5LFON2FA5LTNBHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZF5KB2WY3BDGM4DCMZTGQYDINSQOVZWQIZUGY4TMMJTGE3DANY", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/478/files/05d149fc6a844ed53ee23303cd5b7e4822b03d0b..1b60d38144e319ab8c6e7f2f4b94a8a085da334a?email_source=notifications\u0026email_token=AIJPEW5G4JU33Z6YTHSIICDRFEVKNA5CNFSM4K5OE6O2YY3PNVWWK3TUL52HS4DFXNIHK3DMKJSXC5LFON2FA5LTNBHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZF5KB2WY3BDGM4DCMZTGQYDINSQOVZWQIZUGY4TMMJTGE3DANY", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 

Merged #478 into Cog.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/478?email_source=notifications\u0026email_token=AIJPEW3U3U2C4PADD23BCBDRFEVMXA5CNFSM4K5OE6O2YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOW6437PQ#event-3082403774", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/478?email_source=notifications\u0026email_token=AIJPEW3U3U2C4PADD23BCBDRFEVMXA5CNFSM4K5OE6O2YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOW6437PQ#event-3082403774", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>