[OpenSmalltalk/opensmalltalk-vm] Win64 fixes (#338)

 

This fixes are mainly

• my own failure to respect the invariant imageName and imageNameW must always be synched, writing in imageNameT (the TCHAR* facade) cannot work!
• SecurityPlugin broken by merge win minheadless experiments. I agree with the spirit of the changes (UNICODE), but this is unfinished.
• a few potential security flaws coming from the past

[skip travis] i don't know if this incantation will work the way i wish... These are platforms/win32 changes only

---

You can view, comment on, or merge this pull request online at:

  https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/338

Commit Summary

• fix: squeakIniName cannot be both a WCHAR* (sqWin32Security.c) and TCHAR*
• fix: remove superfluous TEXT macro
• fix: wcsncpy does not necessarily writes the terminating NULL
• fix: B3DAccelerator: dwState is used un-initialized if value is not 0,1 or 2.
• fix issue #336 potential buffer overrun in sqWin32Midi.c
• fix: use LoadLibraryA for -DUNICODE compatibility
• fix: LoadLibrary could fail
• fix: SecurityPlugin: RegQueryValueExW dwSize is buffer size in bytes
• SecurityPlugin: prefer wcs* functions to lstr*W
• Fix: securityPlugin: use WideCharToMultiByte and CP_UTF8
• SecurityPlugin use MultiByteToWideChar rather than sqUTF8toUTF16Copy
• fix: SecurityPlugin: restore expandMyDocuments

File Changes

• M platforms/win32/plugins/B3DAcceleratorPlugin/sqWin32D3D.c (9)
• M platforms/win32/plugins/CroquetPlugin/sqWin32CroquetPlugin.c (1)
• M platforms/win32/plugins/MIDIPlugin/sqWin32MIDI.c (4)
• M platforms/win32/plugins/SecurityPlugin/sqWin32Security.c (138)
• M platforms/win32/vm/sqWin32.h (4)
• M platforms/win32/vm/sqWin32Backtrace.c (4)
• M platforms/win32/vm/sqWin32Main.c (16)
• M platforms/win32/vm/sqWin32Prefs.c (23)
• M platforms/win32/vm/sqWin32Window.c (25)

Patch Links:

• https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/338.patch
• https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/338.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Win64 fixes (#338)"}],"action":{"name":"View Pull Request","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/338"}}}</script> <script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/338", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/338", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 

@nicolas-cellier-aka-nice pushed 1 commit.

• adbdf2e fix SecurityPlugin: revert unfortunate copy/paste

—
You are receiving this because you are subscribed to this thread.
View it on GitHub or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@nicolas-cellier-aka-nice pushed 1 commit in #338"}],"action":{"name":"View Pull Request","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/338/files/9b485667f433a2863a87452712c58b692fe79e8c..adbdf2e6511c89a7206bde7265024b23d5ca75b8"}}}</script> <script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/338/files/9b485667f433a2863a87452712c58b692fe79e8c..adbdf2e6511c89a7206bde7265024b23d5ca75b8", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/338/files/9b485667f433a2863a87452712c58b692fe79e8c..adbdf2e6511c89a7206bde7265024b23d5ca75b8", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 

Merged #338 into Cog.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Merged #338 into Cog."}],"action":{"name":"View Pull Request","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/338#event-2052331613"}}}</script> <script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/338#event-2052331613", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/338#event-2052331613", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>