[OpenSmalltalk/opensmalltalk-vm] afd70d: Remove ux2st & st2ux deadcode

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[OpenSmalltalk/opensmalltalk-vm] afd70d: Remove ux2st & st2ux deadcode

Eliot Miranda-3
 
  Branch: refs/heads/Nuke-MacRoman
  Home:   https://github.com/OpenSmalltalk/opensmalltalk-vm
  Commit: afd70d645c5e40a76953742f4f2beaebdeb21331
      https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/afd70d645c5e40a76953742f4f2beaebdeb21331
  Author: Nicolas Cellier <[hidden email]>
  Date:   2019-12-24 (Tue, 24 Dec 2019)

  Changed paths:
    M platforms/unix/vm-display-X11/sqUnixX11.c

  Log Message:
  -----------
  Remove ux2st & st2ux deadcode

My pleasure: we get enough legacy code to handle and understand.
No need for additional `#if 0` diversion.


  Commit: 975c82d8ba7f398429ae2da92e4422f6c21d245f
      https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/975c82d8ba7f398429ae2da92e4422f6c21d245f
  Author: Nicolas Cellier <[hidden email]>
  Date:   2019-12-26 (Thu, 26 Dec 2019)

  Changed paths:
    M platforms/unix/vm-display-X11/sqUnixX11.c

  Log Message:
  -----------
  Revert "Use translateCode primarily for translating symbolic X11 keysym to OSVM keycode"

This reverts commit f8c78a3f34bf7dea293c6526ae660b98647b2a82.


  Commit: d0e455d643139c449c7d9636c491f7e400a8a8f2
      https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/d0e455d643139c449c7d9636c491f7e400a8a8f2
  Author: Nicolas Cellier <[hidden email]>
  Date:   2019-12-26 (Thu, 26 Dec 2019)

  Changed paths:
    M platforms/unix/vm-display-X11/sqUnixX11.c

  Log Message:
  -----------
  Revert "Directly use the symbolic (=virtual) key code, that's what we want."

This reverts commit 0dbcb71e9c53cb5c60023fa018d03e178117864f.


  Commit: 929bf65da31c7f98dc93b095f361c5e5c870c84d
      https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/929bf65da31c7f98dc93b095f361c5e5c870c84d
  Author: Nicolas Cellier <[hidden email]>
  Date:   2019-12-26 (Thu, 26 Dec 2019)

  Changed paths:
    M platforms/unix/vm-display-X11/sqUnixX11.c

  Log Message:
  -----------
  Let unix Squeak VM generate ASCII control characters like it always did

Note: I have reverted my deeper changes that did always used the `KeySym *symbolic`as event `charCode`.
This will be for another branch and will require coordinated cross platform support and image changes.
This makes Nuke-MacRoman branch a good candidate for fixing https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/456
...at least for ctrl+a to ctrl+z


Compare: https://github.com/OpenSmalltalk/opensmalltalk-vm/compare/f8c78a3f34bf...929bf65da31c