Smalltalk › Squeak › Squeak VM

[OpenSmalltalk/opensmalltalk-vm] another try to properly build libgit2 (v3) (#255)

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

9 messages Options

David T Lewis

[OpenSmalltalk/opensmalltalk-vm] another try to properly build libgit2 (v3) (#255)

You can view, comment on, or merge this pull request online at:

https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/255

Commit Summary

another try to properly build libgit2
temporal line to verify the result of libgit2 build
now is ssh2 what's not there
trying adding dependencies
maybe not all those ;)
another try?
you like more this one?
the problems of copy&pasting
restore dependencies but it *shouldn't* be necessary :(
maybe setting LD_FLAGS explicit?
more to force libssh2 directory
Merge branch 'Cog' of github.com:OpenSmalltalk/opensmalltalk-vm into Cog
still working on compile lingit2 with libssh2

File Changes

M .travis_install.sh (3)
M build.linux32x86/third-party/Makefile.libgit2 (11)

Patch Links:

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

David T Lewis

Re: [OpenSmalltalk/opensmalltalk-vm] another try to properly build libgit2 (v3) (#255)

@estebanlm pushed 1 commit.

cd2359e remove invisible chars

—
You are receiving this because you are subscribed to this thread.
View it on GitHub or mute the thread.

David T Lewis

Re: [OpenSmalltalk/opensmalltalk-vm] another try to properly build libgit2 (v3) (#255)

In reply to this post by David T Lewis

this PR should be ready to integrate, but it is failing on sista builds (no related with my changes).
Con someone take a look?
Should I integrate anyway?

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@estebanlm in #255: this PR should be ready to integrate, but it is failing on sista builds (no related with my changes).\r\nCon someone take a look?\r\nShould I integrate anyway?"}],"action":{"name":"View Pull Request","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/255#issuecomment-387165520"}}}

David T Lewis

Re: [OpenSmalltalk/opensmalltalk-vm] another try to properly build libgit2 (v3) (#255)

In reply to this post by David T Lewis

@akgrant43 commented on this pull request.

In .travis_install.sh:

> @@ -43,7 +43,8 @@ elif [[ "${ARCH}" = "linux32x86" ]]; then
             libaudio-dev:i386 \
             gcc-multilib \
             uuid-dev:i386 \
-            libcurl3-dev:i386
+            libcurl4-openssl-dev:i386 \
+			libssh2-1-dev:i386

Are installing:

libssh2-1-dev:i386
libcurl4-openssl-dev:i386

an artefact of trying to figure out this issue, or really required? If they are required, should the 64 bit libraries be added as well (and why isn't the 64 bit version of libcurl3 loaded? :-))

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

David T Lewis

Re: [OpenSmalltalk/opensmalltalk-vm] another try to properly build libgit2 (v3) (#255)

In reply to this post by David T Lewis

@estebanlm commented on this pull request.

In .travis_install.sh:

> @@ -43,7 +43,8 @@ elif [[ "${ARCH}" = "linux32x86" ]]; then
             libaudio-dev:i386 \
             gcc-multilib \
             uuid-dev:i386 \
-            libcurl3-dev:i386
+            libcurl4-openssl-dev:i386 \
+			libssh2-1-dev:i386

uhm, yes... those are remainders of me trying to solve the problem.
probably not needed :)

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

David T Lewis

Re: [OpenSmalltalk/opensmalltalk-vm] another try to properly build libgit2 (v3) (#255)

In reply to this post by David T Lewis

@estebanlm commented on this pull request.

In build.linux32x86/third-party/Makefile.libgit2:

> @@ -56,6 +56,7 @@ install: $(THIRDPARTYLIBDIR)/$(LIBGIT2LIBNAME)
 			cp -d $$each $(THIRDPARTYINSTALLDIR); \
 		fi \
 	done
+	ldd $(THIRDPARTYLIBDIR)/$(LIBGIT2LIBNAME)

technically, this is not needed anymore either (I put it to see the bindings of libgit2 to ensure it was linking libssh2). Anyway since this can break again I would keep it.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

David T Lewis

Re: [OpenSmalltalk/opensmalltalk-vm] another try to properly build libgit2 (v3) (#255)

In reply to this post by David T Lewis

@akgrant43 commented on this pull request.

In build.linux32x86/third-party/Makefile.libgit2:

> @@ -56,6 +56,7 @@ install: $(THIRDPARTYLIBDIR)/$(LIBGIT2LIBNAME)
 			cp -d $$each $(THIRDPARTYINSTALLDIR); \
 		fi \
 	done
+	ldd $(THIRDPARTYLIBDIR)/$(LIBGIT2LIBNAME)

Exactly why I didn't comment here. :-)

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

David T Lewis

Re: [OpenSmalltalk/opensmalltalk-vm] another try to properly build libgit2 (v3) (#255)

In reply to this post by David T Lewis

meh, I'm going to accept it anyway, since sista builds are also failing in Cog branch

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

David T Lewis

Re: [OpenSmalltalk/opensmalltalk-vm] another try to properly build libgit2 (v3) (#255)

In reply to this post by David T Lewis

Merged #255.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.