[OpenSmalltalk/opensmalltalk-vm] bf3840: Fix a TCHAR*crashInfo trying to mix a char*msg

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[OpenSmalltalk/opensmalltalk-vm] bf3840: Fix a TCHAR*crashInfo trying to mix a char*msg

Eliot Miranda-3
 
  Branch: refs/heads/WIN64_UNICODE
  Home:   https://github.com/OpenSmalltalk/opensmalltalk-vm
  Commit: bf3840c320cf6cd488d83b1ebf7d0ea124b6ad87
      https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/bf3840c320cf6cd488d83b1ebf7d0ea124b6ad87
  Author: Nicolas Cellier <[hidden email]>
  Date:   2019-01-01 (Tue, 01 Jan 2019)

  Changed paths:
    M platforms/win32/vm/sqWin32Main.c

  Log Message:
  -----------
  Fix a TCHAR*crashInfo trying to mix a char*msg

Here, i don't want to redefine error() to take a TCHAR*
So the simplest alternative is to switch to MessageBoxA
But vmLogDirA may contain UNICODE, and UTF8 encoded character may be mangled in the MessageBox.

The right way is to switch to W variant unconditionnally, and interpret msg as UTF8...



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.