[OpenSmalltalk/opensmalltalk-vm] ce7f66: Fix issue #557 (workaround?)

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[OpenSmalltalk/opensmalltalk-vm] ce7f66: Fix issue #557 (workaround?)

Eliot Miranda-3
 
  Branch: refs/heads/Cog
  Home:   https://github.com/OpenSmalltalk/opensmalltalk-vm
  Commit: ce7f664825a5640bdf45a94f83357827f25353e6
      https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/ce7f664825a5640bdf45a94f83357827f25353e6
  Author: Nicolas Cellier <[hidden email]>
  Date:   2021-04-20 (Tue, 20 Apr 2021)

  Changed paths:
    M platforms/Cross/vm/sqAssert.h

  Log Message:
  -----------
  Fix issue #557 (workaround?)

If we build an internal plugin `SQUEAK_BUILTIN_PLUGIN`, then we don't need to `EXPORT` the error/warning functions.
There are still conflicting definitions in sqVirtualMachine.h which totally ignore IMPORT/EXPORT but these only generate warnings, not errors.


  Commit: 331b8cdcd21e09e16fd17def87becc1a542591d8
      https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/331b8cdcd21e09e16fd17def87becc1a542591d8
  Author: Nicolas Cellier <[hidden email]>
  Date:   2021-04-20 (Tue, 20 Apr 2021)

  Changed paths:
    M platforms/Cross/vm/sqAssert.h

  Log Message:
  -----------
  Merge pull request #558 from OpenSmalltalk/issue_557_export_conflict_on_windows

Fix issue #557 (workaround?) [ci skip] we know we're red


Compare: https://github.com/OpenSmalltalk/opensmalltalk-vm/compare/4e791b82c5a2...331b8cdcd21e