-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Support PKG_CONFIG in configure for UnicodePlugin :

PKG_CONFIG path to pkg-config utility
PKG_CONFIG_PATH
directories to add to pkg-config's search path
PKG_CONFIG_LIBDIR
path overriding pkg-config's built-in search path
UNICODE_PLUGIN_CFLAGS
C compiler flags for UNICODE_PLUGIN, overriding pkg-config
UNICODE_PLUGIN_LIBS
linker flags for UNICODE_PLUGIN, overriding pkg-config

Note that I believe that Ian Piumarta's "cmake" system for squeak-4 also
uses pkg-config (when he changed from autoconf to 'cmake').

The reason why I made this change, is for compiling on Solaris 11.4.

You can see in the "mvm" script that I set PKG_CONFIG_PATH for the 64bit:

On Solaris 11.4 32bit there is:

pkg-config --cflags glib-2.0

-I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include

and on Solaris 11.4 64bit there is:

PKG_CONFIG_PATH=/usr/lib/64/pkgconfig pkg-config --cflags glib-2.0

-I/usr/include/glib-2.0 -I/usr/lib/amd64/glib-2.0/include

Note the '64' or 'amd64' subdirectories.

Finally a remark: I modified

platforms/unix/config/make.cfg.in

because I don't see how to define the UNICODE_PLUGIN_CFLAGS in the plugin,
locally, without setting the variable globally (in all Makefiles).

Because of the 'mkmf' script, this will thus modify all Unix Makefiles ...

If somebody has a better idea, let's hear it !

I understand from Eliot Miranda that abandoning 'configure' is an option.

But that still has the issue of multiple locations on various Unix flavors,
for the GTK include files and libraries ...

David Stes

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBCAAGBQJfY5HNAAoJEAwpOKXMq1MaLpEIAL0qgm0zmtJs3kqV9GHli96I
+OQZHL9lLn9gNjyaohpPF7UXhXjr4VbXzjrPAjU8vDR7yImNwe11bcN39VH5nwtt
VrbXA3PpKFNyz5gWBWpyVs1k5ey4UZBSFF/76KwgdruDlXR/aQ7QLwR8WcC6UIfV
rYcvFyLaadwIDV2XoseoVpB91J+Vjy5x/hD+bT6MNybXuvWj5hYli8obdtiBi5aS
8zhBGmZnnKS8+cyfBlmbAjKknUQuy11mhos6FDQX2Wbr/VtBUYgXphcF8cYMnSIe
jV1ZOaA1IQgJ+0kXGKehjqMB/EPs5LA35sUJ8nI2YC3yww0z7n+rzC8n7UttFsg=
=Miad
-----END PGP SIGNATURE-----

---

You can view, comment on, or merge this pull request online at:

  https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/520

Commit Summary

• configure change: use pkg-config (PKG_CONFIG)

File Changes

• M build.sunos64x64/squeak.cog.spur/build/mvm (4)
• M build.sunos64x64/squeak.stack.spur/build/mvm (3)
• M platforms/unix/config/make.cfg.in (2)
• M platforms/unix/plugins/UnicodePlugin/Makefile.inc (5)
• M platforms/unix/plugins/UnicodePlugin/README.UnicodePlugin (21)
• M platforms/unix/plugins/UnicodePlugin/acinclude.m4 (19)

Patch Links:

• https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/520.patch
• https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/520.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/520", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/520", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 

I'd rather not use pkg-config just for parts of the system.
Either most things are found that way or it is not worth it…

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/520#issuecomment-694365273", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/520#issuecomment-694365273", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

OK, it's true that this may be a risky change to 'configure'.

I don't have a problem with closing/withdrawing this pull request ...

I can work-around the issue with some alternatives (like replacing the hardcoded paths by other paths), so I don't really mind.

Note that the squeak-4 package ("cmake") uses pkg-config however.

David Stes

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBCAAGBQJfY5d7AAoJEAwpOKXMq1MaisUH/Rxk9mUC+8VIYO1Zrqy7b4tn
6Q6T4I/CPek1eGHqUgFUSAQXqp2WM/8aSvNHiPUyEUGOqkjWMRtn0julkSS4q5xN
2gqDqWUUNJYrQiWFlKA8trzxLlhd4JN7JpiAZlWx4z9Jlu0ECe0uqCI9kBc99hS2
iOPE0qKfWAnH/Y0ABdkf2cLBZQWWrqYADDUeJ98I9b/NukES4QnSZ+ZtIbOE5V+i
AzVU4J/LHs85KrSW/Y4RggnvUXhik6A9TxvqKosVhmcwlgllUTsZnmzbHhZwrj2j
qVrs4nQo7yq2DjF4+dVc9ParBf4IR1dw+QYNShyIdF8IaYyh1YOq7RwP1Qwf8QY=
=dq3V
-----END PGP SIGNATURE-----

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/520#issuecomment-694370678", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/520#issuecomment-694370678", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 

Note that the squeak-4 package ("cmake") uses pkg-config however.

Yeah, I'm painfully aware :)
There are so many moving parts…

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/520#issuecomment-694382240", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/520#issuecomment-694382240", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 

I'm closing this pull request. For me this "configure" change works.

It's simply:

PKG_CHECK_MODULES(UNICODE_PLUGIN,[glib-2.0 pangocairo],,AC_PLUGIN_DISABLE)

the "PKG_CHECK_MODULES" macro checks whether glib-2.0 and pangocairo are installed VIA the pkg-config tool.

My understanding is that GTK uses pkg-config exactly for this purpose.

But it's true that any change to 'configure' has some risk associated to it (it may break things on some other platforms). Because I have a workaround, I'm closing the request.

I'll just open a request to document in the README that we have discussed the issue, so that somebody who stumbles upon the same issue in the future, knows about it.

It's seems likely that this issue will come up again - on different platforms.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/520#issuecomment-694732730", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/520#issuecomment-694732730", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 

I'm closing this pull request. For me this "configure" change works.

It's simply:

PKG_CHECK_MODULES(UNICODE_PLUGIN,[glib-2.0 pangocairo],,AC_PLUGIN_DISABLE)

the "PKG_CHECK_MODULES" macro checks whether glib-2.0 and pangocairo are installed VIA the pkg-config tool.

My understanding is that GTK uses pkg-config exactly for this purpose.

But it's true that any change to 'configure' has some risk associated to it (it may break things on some other platforms). Because I have a workaround, I'm closing the request.

I'll just open a request to document in the README that we have discussed the issue, so that somebody who stumbles upon the same issue in the future, knows about it.

It's seems likely that this issue will come up again - on different platforms.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/520#issuecomment-694732734", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/520#issuecomment-694732734", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 

I'm closing this pull request. For me this "configure" change works.

It's simply:

PKG_CHECK_MODULES(UNICODE_PLUGIN,[glib-2.0 pangocairo],,AC_PLUGIN_DISABLE)

the "PKG_CHECK_MODULES" macro checks whether glib-2.0 and pangocairo are installed VIA the pkg-config tool.

My understanding is that GTK uses pkg-config exactly for this purpose.

But it's true that any change to 'configure' has some risk associated to it (it may break things on some other platforms). Because I have a workaround, I'm closing the request.

I'll just open a request to document in the README that we have discussed the issue, so that somebody who stumbles upon the same issue in the future, knows about it.

It's seems likely that this issue will come up again - on different platforms.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/520#issuecomment-694732825", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/520#issuecomment-694732825", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 

I'm closing this pull request. For me this "configure" change works.

It's simply:

PKG_CHECK_MODULES(UNICODE_PLUGIN,[glib-2.0 pangocairo],,AC_PLUGIN_DISABLE)

the "PKG_CHECK_MODULES" macro checks whether glib-2.0 and pangocairo are installed VIA the pkg-config tool.

My understanding is that GTK uses pkg-config exactly for this purpose.

But it's true that any change to 'configure' has some risk associated to it (it may break things on some other platforms). Because I have a workaround, I'm closing the request.

I'll just open a request to document in the README that we have discussed the issue, so that somebody who stumbles upon the same issue in the future, knows about it.

It's seems likely that this issue will come up again - on different platforms.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/520#issuecomment-694732822", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/520#issuecomment-694732822", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 

I'm closing this pull request. For me this "configure" change works.

It's simply:

PKG_CHECK_MODULES(UNICODE_PLUGIN,[glib-2.0 pangocairo],,AC_PLUGIN_DISABLE)

the "PKG_CHECK_MODULES" macro checks whether glib-2.0 and pangocairo are installed VIA the pkg-config tool.

My understanding is that GTK uses pkg-config exactly for this purpose.

But it's true that any change to 'configure' has some risk associated to it (it may break things on some other platforms). Because I have a workaround, I'm closing the request.

I'll just open a request to document in the README that we have discussed the issue, so that somebody who stumbles upon the same issue in the future, knows about it.

It's seems likely that this issue will come up again - on different platforms.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/520#issuecomment-694732841", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/520#issuecomment-694732841", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 

Sorry for multiple messages, when I click "Close with comment" Github does not seems to close my pull request. It's ok to close it anyway, sorry for the multiple messages.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/520#issuecomment-694733395", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/520#issuecomment-694733395", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 

Sorry for multiple messages, when I click "Close with comment" Github does not seems to close my pull request. It's ok to close it anyway, sorry for the multiple messages.

No worries. In any case, thanks for your efforts!

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/520#issuecomment-694735013", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/520#issuecomment-694735013", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 

Closed #520.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/520#event-3781536268", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/520#event-3781536268", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>