[OpenSmalltalk/opensmalltalk-vm] configure script : check for <ifaddrs.h> (#523)

 

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

A few commits that could be of use:

1. modify configure.ac to check for the header file <ifaddrs.h>
2. update README of UnicodePlugin
3. #if COGVM in the sqCogStackAlignment.h for getReturnAddress

The COGVM compiles and works in 32bit on Solaris 10.
It also works now (thanks to code for getReturnAddress) in 64bit on Solaris 11.

Solaris 10 has no header file <ifaddrs.h> it appears, to in that case,
the configure script can automatically 'activate' the old code in
sqUnixSocket.c. In the Solaris 11 case, it has <ifaddrs.h>, so activate the
new code on Solaris 11.

David Stes

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBCAAGBQJfazvaAAoJEAwpOKXMq1MaOBMH/0oAanU940wnZi6UnptEXDzL
H4TGeGlQvX+2939+PP79CxAa0yMNQWe/Ew1f2GsERQruKXZAr76lYQPXaJsY2duI
dUeNaNxvPUuKDlsKnrltUnfDgDazYER8NluCZE3tBV8ZUVxak07u/HLUMs/lXP/9
MO/UctlbDSc8KgZlUkBlaffCzz/DtNV/CrgHZNUlPHb9GyLJD2mctc0H7qYkr1o6
2Y3QoOrC1U//4nK/2JbUV9i4lVVj/g1P9CSjRMe2P1ptZp6GfoWod1XAQMM1TIFP
tjZqhxFDB3PHnhdhyBbLrqEbAXoexi2F6nET3xGXEUPYJr6QL6w9rXf3wdhJGVM=
=tynH
-----END PGP SIGNATURE-----

---

You can view, comment on, or merge this pull request online at:

  https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/523

Commit Summary

• Unicode README: add note on a known issue
• configure: check for <ifaddrs.h> (Solaris 11 has it, Solaris 10 not)
• sqCogStackAlignment: define getReturnAddress only #if COGVM (not for Stack VM)

File Changes

• M platforms/Cross/vm/sqCogStackAlignment.h (2)
• M platforms/unix/config/config.h.in (3)
• M platforms/unix/config/configure.ac (1)
• M platforms/unix/plugins/SocketPlugin/sqUnixSocket.c (6)
• M platforms/unix/plugins/UnicodePlugin/README.UnicodePlugin (26)

Patch Links:

• https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/523.patch
• https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/523.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/523", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/523", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Any feedback please ?

The change to use <ifaddrs.h> only if the build target has it,
seems a logical change ...

The only risk is perhaps that somebody unintentionally re-enables the
'old code' by not defining HAVE_IFADDRS_H in their Makefile or config.h.

This is because by default

#undef HAVE_IFADDRS_H

and that will thus by default enable the 'old code'.

While the default now is to enable the 'new code' which uses <ifaddrs.h>.

But this can easily be solved by requiring to #define HAVE_IFADDRS_H,
and the 'configure' script will do just that automatically if it finds the file.

Anyway -- with this patch the current COGVM compiles on Solaris 10.

By the way Solaris 10 still uses openssl 0.9.7 and I think the configure
quite correctly disables SSL support so that works fine.

The SSL plugin is not built I think on Solaris 10, but no problem.

The real interest is in the support for Solaris 11 with openssl 1.0.2 etc.,
but it is nice that the code still compiles on Solaris 10.

Regards,
David Stes

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBCAAGBQJfbZoGAAoJEAwpOKXMq1MaO3sH/26aTh31X//H3xC/bQn+jPdK
ES/YFfFXJ/OB9i/WroLia8n4IHpoPCguwdLy5NPtMbo30s8VpQeVWe2OAun+jLOX
Ekj9LbfFbKpAftetgD7O+2ONWmbikvx1nrPcl4qfkD1rcf1m+ESbftsf69vDvIrc
rNC+Bgq4ZR84yQIxOySzZskN34mtPQfdOxw2B1JQP1cTtPvynkiBy+fGFM2m8Y3J
7StRLKQx9q4dzI875xV3Vmd9gmhFxA4MNHMOmh1i4r9rZYbrQjCtaoHnuI9abQcf
jPKI01K11kyj80aZlV3h9oaslTJnEIGWhJkHFYjQBamVJcqbj2wvYLCiwc9WHIY=
=lu3K
-----END PGP SIGNATURE-----

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/523#issuecomment-698768019", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/523#issuecomment-698768019", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 

Merged #523 into Cog.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/523#event-3806416378", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/523#event-3806416378", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>