[OpenSmalltalk/opensmalltalk-vm] f5ec3f: Fix type inconsistencies (int vs sqInt) (#464)

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[OpenSmalltalk/opensmalltalk-vm] f5ec3f: Fix type inconsistencies (int vs sqInt) (#464)

Eliot Miranda-3
 
  Branch: refs/heads/Cog
  Home:   https://github.com/OpenSmalltalk/opensmalltalk-vm
  Commit: f5ec3f4fa2b61af86bbc2b82a1dabe5bfafe8f4e
      https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/f5ec3f4fa2b61af86bbc2b82a1dabe5bfafe8f4e
  Author: smalltalking <[hidden email]>
  Date:   2020-01-08 (Wed, 08 Jan 2020)

  Changed paths:
    M platforms/Cross/plugins/CroquetPlugin/CroquetPlugin.h
    M platforms/Mac OS/vm/Developer/sqMacMinimal.c
    M platforms/Mac OS/vm/osExports.c
    M platforms/Mac OS/vm/sqMacMain.c
    M platforms/Mac OS/vm/sqMacMain.h
    M platforms/unix/vm-display-Quartz/zzz/sqUnixQuartz.m
    M platforms/unix/vm-display-X11/sqUnixMozilla.c
    M platforms/unix/vm/osExports.c
    M platforms/win32/plugins/CroquetPlugin/sqWin32CroquetPlugin.c
    M platforms/win32/vm/sqWin32Exports.c
    M platforms/win32/vm/sqWin32Main.c
    M platforms/win32/vm/sqWin32PluginSupport.c
    M src/plugins/IA32ABI/IA32ABI.c
    M src/plugins/UnixOSProcessPlugin/UnixOSProcessPlugin.c

  Log Message:
  -----------
  Fix type inconsistencies (int vs sqInt) (#464)

* Fix type inconsistencies (int vs sqInt)

Found by trying to compile with LTO enabled.
The VM compiles with the updated types on linux with or without LTO enabled (the LTO VM is not functional).
Didn't test with the OSes but changed the declarations in their files.
Affected functions:
- primInIOProcessEventsFlagAddress
- ioGatherEntropy
- GetAttributeString
- primitivePluginBrowserReady
- primitivePluginDestroyRequest
- primitivePluginRequestFileHandle
- primitivePluginRequestState
- primitivePluginRequestURL
- primitivePluginRequestURLStream
- primitivePluginPostURL

* Include sqMemoryAccess.h to have sqInt defined


Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] f5ec3f: Fix type inconsistencies (int vs sqInt) (#464)

Eliot Miranda-2
 
Thanks!!

On Wed, Jan 8, 2020 at 2:55 AM smalltalking <[hidden email]> wrote:
 
  Branch: refs/heads/Cog
  Home:   https://github.com/OpenSmalltalk/opensmalltalk-vm
  Commit: f5ec3f4fa2b61af86bbc2b82a1dabe5bfafe8f4e
      https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/f5ec3f4fa2b61af86bbc2b82a1dabe5bfafe8f4e
  Author: smalltalking <[hidden email]>
  Date:   2020-01-08 (Wed, 08 Jan 2020)

  Changed paths:
    M platforms/Cross/plugins/CroquetPlugin/CroquetPlugin.h
    M platforms/Mac OS/vm/Developer/sqMacMinimal.c
    M platforms/Mac OS/vm/osExports.c
    M platforms/Mac OS/vm/sqMacMain.c
    M platforms/Mac OS/vm/sqMacMain.h
    M platforms/unix/vm-display-Quartz/zzz/sqUnixQuartz.m
    M platforms/unix/vm-display-X11/sqUnixMozilla.c
    M platforms/unix/vm/osExports.c
    M platforms/win32/plugins/CroquetPlugin/sqWin32CroquetPlugin.c
    M platforms/win32/vm/sqWin32Exports.c
    M platforms/win32/vm/sqWin32Main.c
    M platforms/win32/vm/sqWin32PluginSupport.c
    M src/plugins/IA32ABI/IA32ABI.c
    M src/plugins/UnixOSProcessPlugin/UnixOSProcessPlugin.c

  Log Message:
  -----------
  Fix type inconsistencies (int vs sqInt) (#464)

* Fix type inconsistencies (int vs sqInt)

Found by trying to compile with LTO enabled.
The VM compiles with the updated types on linux with or without LTO enabled (the LTO VM is not functional).
Didn't test with the OSes but changed the declarations in their files.
Affected functions:
- primInIOProcessEventsFlagAddress
- ioGatherEntropy
- GetAttributeString
- primitivePluginBrowserReady
- primitivePluginDestroyRequest
- primitivePluginRequestFileHandle
- primitivePluginRequestState
- primitivePluginRequestURL
- primitivePluginRequestURLStream
- primitivePluginPostURL

* Include sqMemoryAccess.h to have sqInt defined




--
_,,,^..^,,,_
best, Eliot