[OpenSmalltalk/opensmalltalk-vm] fix calculation of x11 scroll distances (#446)

 

I believe these values should be like the below.

Refer to for example here: http://xahlee.info/linux/linux_x11_mouse_button_number.html (the first scroll event is button 4). And the up-direction should be negative for Squeak. After these adjustments the behavior was correct on my machine.

To try out, ensure that you have Smalltalk sendMouseWheelEvents: true

---

You can view, comment on, or merge this pull request online at:

  https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/446

Commit Summary

• fix calculation of x11 scroll distances

File Changes

• M platforms/unix/vm-display-X11/sqUnixX11.c (6)

Patch Links:

• https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/446.patch
• https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/446.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/446?email_source=notifications\u0026email_token=AIJPEW7TBSJ276O3OREF7RTQUGU55A5CNFSM4JOLVXXKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HZ4JB7Q", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/446?email_source=notifications\u0026email_token=AIJPEW7TBSJ276O3OREF7RTQUGU55A5CNFSM4JOLVXXKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HZ4JB7Q", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 

This is absolutely right, good find!
I think that we under-use this feature!

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/446?email_source=notifications\u0026email_token=AIJPEW45MEZYWFZQRYUMBCTQ2OJWRA5CNFSM4JOLVXXKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHUP6GY#issuecomment-568917787", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/446?email_source=notifications\u0026email_token=AIJPEW45MEZYWFZQRYUMBCTQ2OJWRA5CNFSM4JOLVXXKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHUP6GY#issuecomment-568917787", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 

Merged #446 into Cog.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/446?email_source=notifications\u0026email_token=AIJPEW24OCY7TK2ABXLQTIDQ2OJXNA5CNFSM4JOLVXXKYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOVVLFUSA#event-2908117576", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/446?email_source=notifications\u0026email_token=AIJPEW24OCY7TK2ABXLQTIDQ2OJXNA5CNFSM4JOLVXXKYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOVVLFUSA#event-2908117576", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>