[OpenSmalltalk/opensmalltalk-vm] getGoodSpurVM.sh does not work on Mac 32 bits (#284)

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[OpenSmalltalk/opensmalltalk-vm] getGoodSpurVM.sh does not work on Mac 32 bits (#284)

David T Lewis
 

It tries to read "squeak.cog.spur_macos32_x86_" instead of "squeak.cog.spur_macos32x86_"


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"getGoodSpurVM.sh does not work on Mac 32 bits (#284)"}],"action":{"name":"View Issue","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/284"}}}</script> <script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/284", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/284", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } }, { "@type": "MessageCard", "@context": "http://schema.org/extensions", "hideOriginalBody": "false", "originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB", "title": "getGoodSpurVM.sh does not work on Mac 32 bits (#284)", "sections": [ { "text": "", "activityTitle": "**Hernan Wilkinson**", "activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png", "activitySubtitle": "@hernanwilkinson", "facts": [ { "name": "Repository: ", "value": "OpenSmalltalk/opensmalltalk-vm" }, { "name": "Issue #: ", "value": 284 } ] } ], "potentialAction": [ { "name": "Add a comment", "@type": "ActionCard", "inputs": [ { "isMultiLine": true, "@type": "TextInput", "id": "IssueComment", "isRequired": false } ], "actions": [ { "name": "Comment", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"OpenSmalltalk/opensmalltalk-vm\",\n\"issueId\": 284,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}" } ] }, { "name": "Close issue", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"IssueClose\",\n\"repositoryFullName\": \"OpenSmalltalk/opensmalltalk-vm\",\n\"issueId\": 284\n}" }, { "targets": [ { "os": "default", "uri": "https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/284" } ], "@type": "OpenUri", "name": "View on GitHub" }, { "name": "Unsubscribe", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 380330709\n}" } ], "themeColor": "26292E" } ]</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] getGoodSpurVM.sh does not work on Mac 32 bits (#284)

David T Lewis
 

I do not have access to create a branch so neither a pull request, so I'm coping here the diff that solves the issue:
diff --git a/image/getGoodSpurVM.sh b/image/getGoodSpurVM.sh
index da8326af4..36022892e 100755
--- a/image/getGoodSpurVM.sh
+++ b/image/getGoodSpurVM.sh
@@ -15,8 +15,8 @@ else
exit 1
fi
case $OS in

  •   Darwin) 
    
  •           VOLUME="squeak.cog.spur_macos32_x86_$LATESTRELEASE"
    
  •   Darwin)
    
  •           VOLUME="squeak.cog.spur_macos32x86_$LATESTRELEASE"
              LATESTVM="$VOLUME.dmg"
              VM=Squeak.$LATESTRELEASE.app
              if [ ! -d $VM ]; then
    


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@hernanwilkinson in #284: I do not have access to create a branch so neither a pull request, so I'm coping here the diff that solves the issue: \r\ndiff --git a/image/getGoodSpurVM.sh b/image/getGoodSpurVM.sh\r\nindex da8326af4..36022892e 100755\r\n--- a/image/getGoodSpurVM.sh\r\n+++ b/image/getGoodSpurVM.sh\r\n@@ -15,8 +15,8 @@ else\r\n exit 1\r\n fi\r\n case $OS in\r\n- Darwin) \r\n- VOLUME=\"squeak.cog.spur_macos32_x86_$LATESTRELEASE\"\r\n+ Darwin)\r\n+ VOLUME=\"squeak.cog.spur_macos32x86_$LATESTRELEASE\"\r\n LATESTVM=\"$VOLUME.dmg\"\r\n VM=Squeak.$LATESTRELEASE.app\r\n if [ ! -d $VM ]; then"}],"action":{"name":"View Issue","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/284#issuecomment-421766314"}}}</script> <script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/284#issuecomment-421766314", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/284#issuecomment-421766314", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } }, { "@type": "MessageCard", "@context": "http://schema.org/extensions", "hideOriginalBody": "false", "originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB", "title": "Re: [OpenSmalltalk/opensmalltalk-vm] getGoodSpurVM.sh does not work on Mac 32 bits (#284)", "sections": [ { "text": "", "activityTitle": "**Hernan Wilkinson**", "activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png", "activitySubtitle": "@hernanwilkinson", "facts": [ ] } ], "potentialAction": [ { "name": "Add a comment", "@type": "ActionCard", "inputs": [ { "isMultiLine": true, "@type": "TextInput", "id": "IssueComment", "isRequired": false } ], "actions": [ { "name": "Comment", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"OpenSmalltalk/opensmalltalk-vm\",\n\"issueId\": 284,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}" } ] }, { "name": "Close issue", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"IssueClose\",\n\"repositoryFullName\": \"OpenSmalltalk/opensmalltalk-vm\",\n\"issueId\": 284\n}" }, { "targets": [ { "os": "default", "uri": "https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/284#issuecomment-421766314" } ], "@type": "OpenUri", "name": "View on GitHub" }, { "name": "Unsubscribe", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 380330709\n}" } ], "themeColor": "26292E" } ]</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] getGoodSpurVM.sh does not work on Mac 32 bits (#284)

David T Lewis
In reply to this post by David T Lewis
 
Fork the repository into your personal account , and create your branch
there. Then you can do a PR against the main repo.

On Sun, Sep 16, 2018, 10:34 Hernan Wilkinson <[hidden email]>
wrote:

> I do not have access to create a branch so neither a pull request, so I'm
> coping here the diff that solves the issue:
> diff --git a/image/getGoodSpurVM.sh b/image/getGoodSpurVM.sh
> index da8326af4..36022892e 100755
> --- a/image/getGoodSpurVM.sh
> +++ b/image/getGoodSpurVM.sh
> @@ -15,8 +15,8 @@ else
> exit 1
> fi
> case $OS in
>
> -
>
> Darwin)
>
> -
>
> VOLUME="squeak.cog.spur_macos32_x86_$LATESTRELEASE"
>
>
>
> -
>
> Darwin)
>
> -
>
> VOLUME="squeak.cog.spur_macos32x86_$LATESTRELEASE"
> LATESTVM="$VOLUME.dmg"
> VM=Squeak.$LATESTRELEASE.app
> if [ ! -d $VM ]; then
>
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/284#issuecomment-421766314>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/ACAleCMD9McLGpxum_KW9n64bErXhTx4ks5ublNWgaJpZM4Wq2LV>
> .
>


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@gcotelli in #284: Fork the repository into your personal account , and create your branch\nthere. Then you can do a PR against the main repo.\n\nOn Sun, Sep 16, 2018, 10:34 Hernan Wilkinson \u003cnotifications@github.com\u003e\nwrote:\n\n\u003e I do not have access to create a branch so neither a pull request, so I'm\n\u003e coping here the diff that solves the issue:\n\u003e diff --git a/image/getGoodSpurVM.sh b/image/getGoodSpurVM.sh\n\u003e index da8326af4..36022892e 100755\n\u003e --- a/image/getGoodSpurVM.sh\n\u003e +++ b/image/getGoodSpurVM.sh\n\u003e @@ -15,8 +15,8 @@ else\n\u003e exit 1\n\u003e fi\n\u003e case $OS in\n\u003e\n\u003e -\n\u003e\n\u003e Darwin)\n\u003e\n\u003e -\n\u003e\n\u003e VOLUME=\"squeak.cog.spur_macos32_x86_$LATESTRELEASE\"\n\u003e\n\u003e\n\u003e\n\u003e -\n\u003e\n\u003e Darwin)\n\u003e\n\u003e -\n\u003e\n\u003e VOLUME=\"squeak.cog.spur_macos32x86_$LATESTRELEASE\"\n\u003e LATESTVM=\"$VOLUME.dmg\"\n\u003e VM=Squeak.$LATESTRELEASE.app\n\u003e if [ ! -d $VM ]; then\n\u003e\n\u003e\n\u003e —\n\u003e You are receiving this because you are subscribed to this thread.\n\u003e Reply to this email directly, view it on GitHub\n\u003e \u003chttps://github.com/OpenSmalltalk/opensmalltalk-vm/issues/284#issuecomment-421766314\u003e,\n\u003e or mute the thread\n\u003e \u003chttps://github.com/notifications/unsubscribe-auth/ACAleCMD9McLGpxum_KW9n64bErXhTx4ks5ublNWgaJpZM4Wq2LV\u003e\n\u003e .\n\u003e\n"}],"action":{"name":"View Issue","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/284#issuecomment-421767805"}}}</script> <script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/284#issuecomment-421767805", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/284#issuecomment-421767805", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } }, { "@type": "MessageCard", "@context": "http://schema.org/extensions", "hideOriginalBody": "false", "originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB", "title": "Re: [OpenSmalltalk/opensmalltalk-vm] getGoodSpurVM.sh does not work on Mac 32 bits (#284)", "sections": [ { "text": "", "activityTitle": "**Gabriel Omar Cotelli**", "activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png", "activitySubtitle": "@gcotelli", "facts": [ ] } ], "potentialAction": [ { "name": "Add a comment", "@type": "ActionCard", "inputs": [ { "isMultiLine": true, "@type": "TextInput", "id": "IssueComment", "isRequired": false } ], "actions": [ { "name": "Comment", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"OpenSmalltalk/opensmalltalk-vm\",\n\"issueId\": 284,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}" } ] }, { "name": "Close issue", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"IssueClose\",\n\"repositoryFullName\": \"OpenSmalltalk/opensmalltalk-vm\",\n\"issueId\": 284\n}" }, { "targets": [ { "os": "default", "uri": "https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/284#issuecomment-421767805" } ], "@type": "OpenUri", "name": "View on GitHub" }, { "name": "Unsubscribe", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 380330709\n}" } ], "themeColor": "26292E" } ]</script>