[OpenSmalltalk/opensmalltalk-vm] jpeg plugin crashes in win64 cygwin/mingw builds (#526)

 

Easy to reproduce: JPEGReadWriter2Test suite run with a VM compiled with cygwin (mingw cross platform) toolchain.
This might be related to this commit or not:
7e0018d

The commit tells that assert VM crashes even when built with MSVC toolchain (w or w/o clang-cl.exe).

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/526", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/526", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 

I think that a good part of the problem is that we call _setjmp but then longjmp instead of _longjmp in error_exit.

If we (re)#define setjmp then we must also (re)#define longjmp _longjmp

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/526#issuecomment-759054202", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/526#issuecomment-759054202", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 

The commit fixed it for me

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/526#issuecomment-759089224", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/526#issuecomment-759089224", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 

Closed #526.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/526#event-4198398378", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/526#event-4198398378", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>