So says the compiler:
../../platforms/unix/plugins/FileCopyPlugin/sqUnixFileCopyPlugin.c:94:61: warning: result of comparison of constant 0 with boolean expression is always true [-Wtautological-constant-compare]
if (( (read(in, mem, stat.st_size) != stat.st_size) >= 0)
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~
../../platforms/unix/plugins/FileCopyPlugin/sqUnixFileCopyPlugin.c:95:56: warning: result of comparison of constant 0 with boolean expression is always true [-Wtautological-constant-compare]
&& (write(out, mem, stat.st_size) != stat.st_size) >= 0)
The compiler is right, this makes not much sense:
if (( (read(in, mem, stat.st_size) != stat.st_size) >= 0)
&& (write(out, mem, stat.st_size) != stat.st_size) >= 0)
Also, the copy function may leave open file descriptors in case of failure, so it badly need some attention.
https://github.com/OpenSmalltalk/opensmalltalk-vm/blob/Cog/platforms/unix/plugins/FileCopyPlugin/sqUnixFileCopyPlugin.c
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/442?email_source=notifications\u0026email_token=AIJPEW7AEQXHV3RPF5YFSPLQRSMUBA5CNFSM4JIAEQHKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HWG5QXQ",
"url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/442?email_source=notifications\u0026email_token=AIJPEW7AEQXHV3RPF5YFSPLQRSMUBA5CNFSM4JIAEQHKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HWG5QXQ",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>
Locked
