[OpenSmalltalk/opensmalltalk-v
Locked
[OpenSmalltalk/opensmalltalk-v
 
|
You can view, comment on, or merge this pull request online at:https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/386 Commit Summary
File Changes
Patch Links:
— |
Re: [OpenSmalltalk/opensmalltalk-v
|
|
I have difficulties building the VM so this is not tested locally. We need to have a look at iceberg before merging it. — |
Re: [OpenSmalltalk/opensmalltalk-v
|
|
In reply to this post by David T Lewis
@zecke pushed 1 commit.
— |
Re: [OpenSmalltalk/opensmalltalk-v
|
|
In reply to this post by David T Lewis
@zecke pushed 1 commit.
— |
Re: [OpenSmalltalk/opensmalltalk-v
|
|
In reply to this post by David T Lewis
@zecke pushed 1 commit.
— |
Re: [OpenSmalltalk/opensmalltalk-v
|
|
In reply to this post by David T Lewis
@zecke pushed 1 commit.
— |
Re: [OpenSmalltalk/opensmalltalk-v
|
|
In reply to this post by David T Lewis
Hi Holger,
I've built this on Ubuntu 16.04 and haven't seen any issues with iceberg (or anything else). HTH, — |
Re: [OpenSmalltalk/opensmalltalk-v
|
|
In reply to this post by David T Lewis
I'm supporting this PR from the sidelines! :) I've downloaded the release version of Pharo 7.0 and noticed there were linker resolution errors on my CentOS: Plus the linker wasn't able to resolve Both are fixed by this PR (I built it in a Xenial docker container), and the third parties are brought up to date, so really, two birds with one stone. It seems Travis only has issues building the macOS versions. — |
Re: [OpenSmalltalk/opensmalltalk-v
|
|
In reply to this post by David T Lewis
Hi Holger, I heartily agree with you that this is an important issue. In talking with @ronsaldo this morning he wrote "The painful change is building all of these third party dependencies with cmake. And cmake is not suitable at all for doing this. I would like to remove these third party dependencies on the near future, but for doing this we need a server for holding them." and I replied I think the best thing to do is to And he agrees. So was soon as possible we should split the repository to create e.g. opensmalltalk-third-party and stop rebuilding third-party software unnecessarily. We do have to decide where the products live on opensmalltalk-vm. I propose that they live in build.*/third-party/lib — |
Re: [OpenSmalltalk/opensmalltalk-v
|
|
In reply to this post by David T Lewis
Sounds reasonable. I'm not sure how big those libraries would be, but if we do decide to commit them to a Git repository alongside instructions to generate them, we could include them as Git submodules. This would allow us to control which version of which library comes with which version of the main repository. — |
Re: [OpenSmalltalk/opensmalltalk-v
|
|
In reply to this post by David T Lewis
On Thu, 27 Jun 2019 at 03:01, Eliot Miranda <[hidden email]> wrote: > @ronsaldo <https://github.com/ronsaldo> this morning wrote: > > "need a server for holding them." > Could use github "releases" ( https://help.github.com/en/articles/creating-releases) It won't change too often so doesn't need something high volume like BinTray. > and I replied > > I think the best thing to do is to > a) have a directory in each build.foo* which includes the pre-built > support libraries > b) have a separate repository to build the support libraries > Consider having a separate mirror-repo for each third-party library. Libraries that are github hosted can just be forked. e.g. https://github.com/freedesktop/cairo Libraries that are git based by hosted elsewhere can be cloned and pushed to opensmalltalk-vm account with full history e.g. https://www.freetype.org/developer.html Libraries with a git repo can just be untar'ed locally and pushed via git to opensmalltalk-vm account (I only spot checked, but didn't bump into a library not using git) The thing I'm not clear on is whether there are inter-dependencies between third-party libraries to be kept in sync. But anyway this can be done via the library.spec files. cheers -ben c) a workflow where when a new version of a library is needed one checks > out repository b) and builds, and then replaces the libraries in a) and > commits. That is what I'm doing with Terf. See > terf-cogvm/platforms/Cross/third-party/lib.macos32x86 & lib.macos64x64. > > And he agrees. > > So was soon as possible we should split the repository to create e.g. > opensmalltalk-third-party and stop rebuilding third-party software > unnecessarily. We do have to decide where the products live on > opensmalltalk-vm. I propose that they live in build.*/third-party/lib > — |
Re: [OpenSmalltalk/opensmalltalk-v
|
|
In reply to this post by David T Lewis
Can this be closed in favor of #482 ? — |
Re: [OpenSmalltalk/opensmalltalk-v
|
|
In reply to this post by David T Lewis
— |
Re: [OpenSmalltalk/opensmalltalk-v
|
|
In reply to this post by David T Lewis
Merged #386 into Cog. — |
| Free forum by Nabble | Edit this page |