Smalltalk › Squeak › Squeak - Dev

PasteUpMorph>privateRemoveMorph: bug?

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

4 messages Options

timrowledge

PasteUpMorph>privateRemoveMorph: bug?

There’s only two senders of privateRemoveMoprh:
1) the only implementation, in PasteUpMorph, which does a super send
2) TransformMorph>quickAddAllMorphs:, which appears to be unsent. Obviously, if it is used by any outside package it’s going to lead to a dNU:

Who’s looking after Morphic?

tim
--
tim Rowledge; [hidden email]; http://www.rowledge.org/tim
In the long run, every program becomes rococco, and then rubble.

Frank Shearar-3

Re: PasteUpMorph>privateRemoveMorph: bug?

On 18 January 2014 01:48, tim Rowledge <[hidden email]> wrote:
> There’s only two senders of privateRemoveMoprh:
> 1) the only implementation, in PasteUpMorph, which does a super send
> 2) TransformMorph>quickAddAllMorphs:, which appears to be unsent. Obviously, if it is used by any outside package it’s going to lead to a dNU:
>
> Who’s looking after Morphic?

(tumbleweed) It's one of those "collectively maintained" things.
Usually, I hope that Bert answers.

Are you looking to remove it? You could always move it to 45Deprecated
- that way if an external package depended on it, they could add
45Deprecated to their list of dependencies.

frank

timrowledge

Re: PasteUpMorph>privateRemoveMorph: bug?

On 18-01-2014, at 6:24 AM, Frank Shearar <[hidden email]> wrote:

> On 18 January 2014 01:48, tim Rowledge <[hidden email]> wrote:
>> There’s only two senders of privateRemoveMoprh:
>> 1) the only implementation, in PasteUpMorph, which does a super send
>> 2) TransformMorph>quickAddAllMorphs:, which appears to be unsent. Obviously, if it is used by any outside package it’s going to lead to a dNU:
>>
>> Who’s looking after Morphic?
>
> (tumbleweed) It's one of those "collectively maintained" things.
> Usually, I hope that Bert answers.
>
> Are you looking to remove it? You could always move it to 45Deprecated
> - that way if an external package depended on it, they could add
> 45Deprecated to their list of dependencies.

Probably; it looks to me like some left ofter cruft from some older tidy-up pass. No senders of the only sender, no actual implementation that does anything.

tim
--
tim Rowledge; [hidden email]; http://www.rowledge.org/tim
Fractured Idiom:- J'Y SUIS, J'Y PESTES - I can stay for the weekend

Bert Freudenberg

Re: PasteUpMorph>privateRemoveMorph: bug?

On 18.01.2014, at 23:20, tim Rowledge <[hidden email]> wrote:

> On 18-01-2014, at 6:24 AM, Frank Shearar <[hidden email]> wrote:
>
>> On 18 January 2014 01:48, tim Rowledge <[hidden email]> wrote:
>>> There’s only two senders of privateRemoveMoprh:
>>> 1) the only implementation, in PasteUpMorph, which does a super send
>>> 2) TransformMorph>quickAddAllMorphs:, which appears to be unsent. Obviously, if it is used by any outside package it’s going to lead to a dNU:
>>>
>>> Who’s looking after Morphic?
>>
>> (tumbleweed) It's one of those "collectively maintained" things.
>> Usually, I hope that Bert answers.
>>
>> Are you looking to remove it? You could always move it to 45Deprecated
>> - that way if an external package depended on it, they could add
>> 45Deprecated to their list of dependencies.
>
> Probably; it looks to me like some left ofter cruft from some older tidy-up pass. No senders of the only sender, no actual implementation that does anything.

Yes. I think it can go, along with quickAddAllMorphs:. Moving to 45Deprecated is the right way to do it.

- Bert -

smime.p7s (5K) Download Attachment