Smalltalk › Squeak › Squeak - Dev

[Patch] Both source files now with 512MB capacity

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

5 messages Options

Klaus D. Witzel

[Patch] Both source files now with 512MB capacity

List,

attached are two .cs files which together push the limit from 32MB to
512MB for the .sources file and the .changes file, no problem so far on
#7048. Use:

FileIn LargeSourceFilePointers-kwl.0.cs; if you filed it into an empty
changeset then select the doIt in the preabmble, otherwise select the doIt
from the fileList text view, then doIt. This doIt is essential. Note that
this fileIn will change the MethodProperties class definition, you must
accept.

Do the very same with LargeSourceFilePointers-kwl.1.cs, fileIn then doIt.
You don't need to inspect the result from the two doIts (these 204 methods
have been discussed before).

In both steps a small amount of methods is compiled and a part of the
migration is executed, doesn't take much time. Don't forget to save the
image (before; after)! The #7048 image grew 300KB here.

There is no break in compatibility with the existing .sources and .changes
files, except that *after* you passed the old 32MB limit for one of the
files, it can no longer be used by an uncoditioned image.

I'd like to receive some feedback that this works for you, all platforms,
thank you in advance. The FilePlugin was checked for the file pointer
length, it accepts up to eight byte pointers (SmallInteger and
LargeInteger).

Will do more tests (and perhaps more patches) during the next couple of
days.

/Klaus

LargeSourceFilePointers-kwl.0.cs (6K) Download Attachment

LargeSourceFilePointers-kwl.1.cs (6K) Download Attachment

Bert Freudenberg-3

Re: [Patch] Both source files now with 512MB capacity

Am 27.07.2006 um 20:20 schrieb Klaus D. Witzel:

> List,
>
> attached are two .cs files which together push the limit from 32MB
> to 512MB for the .sources file and the .changes file, no problem so
> far on #7048.

Why do you want to deprecate all the source-pointer related methods?
Wouldn't changing them to cope with the new scheme be sufficient?

- Bert -

Klaus D. Witzel

Re: [Patch] Both source files now with 512MB capacity

Bert,

I thought over this for some time (well, actually not longer than the time
it took to write the methods ;-)

I have no, absolutely no idea on what and how users of "base" Squeak do
something with source file index and pointer. With users I mean, packages
which exists out there. I cannot load + test them all.

So as a matter of *reminder* that something changed while the respective
packages where NOT in the image, I introduced the "large" message name
variants and put the flag on the "old" methods.

If I had just changed the "old" methods to cope with the new scheme, I
would have taken *full* responsibility for packages not in the image to
work as if nothing happened while they where away, which is beyond my
capabilities.

Take for example the prior: keyword recorded with preambles in files, the
format of its argument has changed (will be addressed for 3.9 [only!] when
completing migration).

Thank you for sharing your concern. Would this be a show stopper?

/Klaus

On Fri, 28 Jul 2006 00:57:13 +0200, Bert Freudenberg wrote:

> Am 27.07.2006 um 20:20 schrieb Klaus D. Witzel:
>
>> List,
>>
>> attached are two .cs files which together push the limit from 32MB to
>> 512MB for the .sources file and the .changes file, no problem so far on
>> #7048.
>
> Why do you want to deprecate all the source-pointer related methods?
> Wouldn't changing them to cope with the new scheme be sufficient?
>
> - Bert -
>
>
>

stéphane ducasse-2

Re: [Patch] Both source files now with 512MB capacity

May be we should keep that for 3.10 alpha.
We would really like to get rid of 3.9 :) since it starts to get
heavy on us :)

> Bert,
>
> I thought over this for some time (well, actually not longer than
> the time it took to write the methods ;-)
>
> I have no, absolutely no idea on what and how users of "base"
> Squeak do something with source file index and pointer. With users
> I mean, packages which exists out there. I cannot load + test them
> all.
>
> So as a matter of *reminder* that something changed while the
> respective packages where NOT in the image, I introduced the
> "large" message name variants and put the flag on the "old" methods.
>
> If I had just changed the "old" methods to cope with the new
> scheme, I would have taken *full* responsibility for packages not
> in the image to work as if nothing happened while they where away,
> which is beyond my capabilities.
>
> Take for example the prior: keyword recorded with preambles in
> files, the format of its argument has changed (will be addressed
> for 3.9 [only!] when completing migration).
>
> Thank you for sharing your concern. Would this be a show stopper?
>
> /Klaus
>
> On Fri, 28 Jul 2006 00:57:13 +0200, Bert Freudenberg wrote:
>
>> Am 27.07.2006 um 20:20 schrieb Klaus D. Witzel:
>>
>>> List,
>>>
>>> attached are two .cs files which together push the limit from
>>> 32MB to 512MB for the .sources file and the .changes file, no
>>> problem so far on #7048.
>>
>> Why do you want to deprecate all the source-pointer related
>> methods? Wouldn't changing them to cope with the new scheme be
>> sufficient?
>>
>> - Bert -
>>
>>
>>
>
>
>

Klaus D. Witzel

Re: [Patch] Both source files now with 512MB capacity

On Fri, 28 Jul 2006 11:58:56 +0200, stéphane ducasse wrote:

> May be we should keep that for 3.10 alpha.

No problem, now that the patch is available (as yet not 100% complete,
still need to address prior: pointing backwards with old pointer format).

> We would really like to get rid of 3.9 :) since it starts to get heavy
> on us :)

Hurry on, guys :)

/Klaus