Patch: Playing readonly sound files

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Patch: Playing readonly sound files

K. K. Subramaniam
Hi,

In the latest Etoys image, media files are being opened using oldFileNamed:
which opens in "write" mode. On Linux, users may not necessarily have write
permissions on media files (e.g. /usr/share/sounds/). This causes a MNU
dialog to popup. The attached patch uses readOnlyFileNamed: method for
opening files. With this change, Karl's drag/drop support for sound files
worked fine on Linux.

Can someone with an XO machine confirm if this patch works?

Regards .. Subbu



FileOpenFixes.2.cs.gz (2K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Patch: Playing readonly sound files

Bert Freudenberg
On Sep 27, 2007, at 13:18 , subbukk wrote:

> Hi,
>
> In the latest Etoys image, media files are being opened using  
> oldFileNamed:
> which opens in "write" mode. On Linux, users may not necessarily  
> have write
> permissions on media files (e.g. /usr/share/sounds/). This causes a  
> MNU
> dialog to popup. The attached patch uses readOnlyFileNamed: method for
> opening files. With this change, Karl's drag/drop support for sound  
> files
> worked fine on Linux.

Good catch.

> Can someone with an XO machine confirm if this patch works?

If it works fine under Linux it should work fine on the XO. Besides,  
you could run the complete XO operating system in emulation under Mac/
Linux/Windows. Stef just got that to work after a bit of discussion  
on the etoys list.

> Regards .. Subbu
> <FileOpenFixes.2.cs.gz>

I forwarded this to the etoys list.

We use the bug tracker at dev.laptop.org for the OLPC Etoys version,  
and the [hidden email] mailing list. So if you find more bugs /  
have fixes, please use one of those to make sure we don't overlook it.

Great to see some more people contributing! Though I am still  
surprised that no-one in the broader Squeak community is interested  
in making the Smalltalk tools work reasonably for OLPC. The core  
developers unfortunately have their plates full with making Etoys work.

- Bert -