Patch for filename normalization of mac vm

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Patch for filename normalization of mac vm

Tetsuya HAYASHI
 
Hi,

I've found the latest mac vm (or recent version) fails to normalize UTF file name.
It seems to be the function convertChars() of sqMacUnixFileInterface.c, which normalizes only decompose when converting squeak string to unix, but I think it needs pre-combined when unix string to squeak, and I noticed normalization form should be canonical (exactly should be kCFStringNormalizationFormC) for pre-combined.

Patch (diff format of xcode tool) for this problem is attached to this mail.

Regards,
--
Tetsuya HAYASHI, [hidden email], [hidden email]


sqMacUnixFileInterface.c.diff.zip (1K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Patch for filename normalization of mac vm

johnmci
 
Thank you for this, however could you send me your entire  
sqMacUnixFileInterface.c so I can compare against some work here.

On Mar 11, 2007, at 8:21 PM, Tetsuya HAYASHI wrote:

> <sqMacUnixFileInterface.c.diff.zip>

--
========================================================================
===
John M. McIntosh <[hidden email]>
Corporate Smalltalk Consulting Ltd.  http://www.smalltalkconsulting.com
========================================================================
===


Reply | Threaded
Open this post in threaded view
|

Re: Patch for filename normalization of mac vm

Tetsuya HAYASHI
 
Ok,
I attach the entire file to this mail.

(I believe the last block mark of convertChars() whould be unnecessary, but I keep it unchanged)

On 2007/03/12, at 12:40, John M McIntosh wrote:

> Thank you for this, however could you send me your entire sqMacUnixFileInterface.c so I can compare against some work here.


sqMacUnixFileInterface.c.zip (9K) Download Attachment