Smalltalk › Squeak › Squeak - Dev

Patch request for 7036

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

10 messages Options

Pavel Krivanek

Patch request for 7036

Hi Stef,

can you put this two patches into the next 3.9a release?

condenseChanges fix is related to http://bugs.impara.de/view.php?id=3737
- this patch doesn't solve all problems of condenseChanges routine but
it's better than nothing.

AsyncFile fix simply renames class variable named Error to ErrorCode.
The first name collides with global class name.

This will help me to update self-bootstrapping environment for Squeak
3.9 and make its public repository
(http://www.squeaksource.com/KernelImage.html) usable.

-- Pavel

condenseChanges fix.st (952 bytes) Download Attachment

AsyncFile fix.cs (3K) Download Attachment

stéphane ducasse-2

Re: Patch request for 7036

Hi pavel

I got back a connection :) and moved (yessss finally).

> can you put this two patches into the next 3.9a release?
>
> condenseChanges fix is related to http://bugs.impara.de/view.php?
> id=3737
> - this patch doesn't solve all problems of condenseChanges routine but
> it's better than nothing.

I was looking at it. But as you said it does not solve the problem
Adrian told me that he will have a look at it this week.

> AsyncFile fix simply renames class variable named Error to ErrorCode.
> The first name collides with global class name.
>
> This will help me to update self-bootstrapping environment for Squeak
> 3.9 and make its public repository
> (http://www.squeaksource.com/KernelImage.html) usable.
>
> -- Pavel
> <condenseChanges fix.st>
> <AsyncFile fix.cs>

Thanks for your effort to make Squeak better.

Stef

Adrian Lienhard

Re: Patch request for 7036

In reply to this post by Pavel Krivanek

Hi Pavel,

I started looking into the condenseChanges problem (http://
bugs.impara.de/view.php?id=3737).

In the IRC log which is attached to the Mantis report there is some
talk about inconsistencies with the Traits structure in memory (and
some code which should fix this). I'd like to understand what is
wrong. Do you know more? Or do you know who is "Gazza" resp. "guru'?

Cheers,
Adrian

On Jun 30, 2006, at 12:19 , Pavel Krivanek wrote:

> Hi Stef,
>
> can you put this two patches into the next 3.9a release?
>
> condenseChanges fix is related to http://bugs.impara.de/view.php?
> id=3737
> - this patch doesn't solve all problems of condenseChanges routine but
> it's better than nothing.
>
> AsyncFile fix simply renames class variable named Error to ErrorCode.
> The first name collides with global class name.
>
> This will help me to update self-bootstrapping environment for Squeak
> 3.9 and make its public repository
> (http://www.squeaksource.com/KernelImage.html) usable.
>
> -- Pavel
> <condenseChanges fix.st>
> <AsyncFile fix.cs>
>

Pavel Krivanek

Re: Patch request for 7036

Sorry Adrian, I have no idea :-(

-- Pavel

On 7/7/06, Pavel Krivanek <[hidden email]> wrote:

> Sorry Adrian, I have no idea :-(
>
> -- Pavel
>
> On 7/7/06, Adrian Lienhard <[hidden email]> wrote:
> > Hi Pavel,
> >
> > I started looking into the condenseChanges problem (http://
> > bugs.impara.de/view.php?id=3737).
> >
> > In the IRC log which is attached to the Mantis report there is some
> > talk about inconsistencies with the Traits structure in memory (and
> > some code which should fix this). I'd like to understand what is
> > wrong. Do you know more? Or do you know who is "Gazza" resp. "guru'?
> >
> > Cheers,
> > Adrian
> >
> > On Jun 30, 2006, at 12:19 , Pavel Krivanek wrote:
> >
> > > Hi Stef,
> > >
> > > can you put this two patches into the next 3.9a release?
> > >
> > > condenseChanges fix is related to http://bugs.impara.de/view.php?
> > > id=3737
> > > - this patch doesn't solve all problems of condenseChanges routine but
> > > it's better than nothing.
> > >
> > > AsyncFile fix simply renames class variable named Error to ErrorCode.
> > > The first name collides with global class name.
> > >
> > > This will help me to update self-bootstrapping environment for Squeak
> > > 3.9 and make its public repository
> > > (http://www.squeaksource.com/KernelImage.html) usable.
> > >
> > > -- Pavel
> > > <condenseChanges fix.st>
> > > <AsyncFile fix.cs>
> > >
> >
> >
> >
>

Gary Chambers

RE: Patch request for 7036

In reply to this post by Adrian Lienhard

That's me.

While investigating condenseChanges I found that some of the trait methods
had non-shared compiled methods in the classes using them, even when not
local to the classes using them. After further delving, methods that call
super have their own compiled method (legitimate) but some without super
calls also did (not good). These extra compiled methods share the source
code pointer and so, when filed out (a subsequent time), refer to the old
changes file with the new changes pointer.

By manually fixing up the trait usage via #notifyUsersofChangedSelectors:
for all local (trait) methods I was able to get it to the point where my
suggestion for a revised #moveChangesTo: method managed to condense the
changes correctly (subject to other issues addressed elsewhere).

Saved my bacon since running into the 32MB limit.

> -----Original Message-----
> From: [hidden email]
> [mailto:[hidden email]]On Behalf Of
> Adrian Lienhard
> Sent: 07 July 2006 12:15 PM
> To: The general-purpose Squeak developers list
> Subject: Re: Patch request for 7036
>
>
> Hi Pavel,
>
> I started looking into the condenseChanges problem (http://
> bugs.impara.de/view.php?id=3737).
>
> In the IRC log which is attached to the Mantis report there is some
> talk about inconsistencies with the Traits structure in memory (and
> some code which should fix this). I'd like to understand what is
> wrong. Do you know more? Or do you know who is "Gazza" resp. "guru'?
>
> Cheers,
> Adrian
>
> On Jun 30, 2006, at 12:19 , Pavel Krivanek wrote:
>
> > Hi Stef,
> >
> > can you put this two patches into the next 3.9a release?
> >
> > condenseChanges fix is related to http://bugs.impara.de/view.php?
> > id=3737
> > - this patch doesn't solve all problems of condenseChanges routine but
> > it's better than nothing.
> >
> > AsyncFile fix simply renames class variable named Error to ErrorCode.
> > The first name collides with global class name.
> >
> > This will help me to update self-bootstrapping environment for Squeak
> > 3.9 and make its public repository
> > (http://www.squeaksource.com/KernelImage.html) usable.
> >
> > -- Pavel
> > <condenseChanges fix.st>
> > <AsyncFile fix.cs>
> >
>
>

stéphane ducasse-2

Re: Patch request for 7036

In reply to this post by Adrian Lienhard

Adrian

what is the status of this bug?
I'm lost there.

Stef

On 7 juil. 06, at 13:15, Adrian Lienhard wrote:

> Hi Pavel,
>
> I started looking into the condenseChanges problem (http://
> bugs.impara.de/view.php?id=3737).
>
> In the IRC log which is attached to the Mantis report there is some
> talk about inconsistencies with the Traits structure in memory (and
> some code which should fix this). I'd like to understand what is
> wrong. Do you know more? Or do you know who is "Gazza" resp. "guru'?
>
> Cheers,
> Adrian
>
> On Jun 30, 2006, at 12:19 , Pavel Krivanek wrote:
>
>> Hi Stef,
>>
>> can you put this two patches into the next 3.9a release?
>>
>> condenseChanges fix is related to http://bugs.impara.de/view.php?
>> id=3737
>> - this patch doesn't solve all problems of condenseChanges routine
>> but
>> it's better than nothing.
>>
>> AsyncFile fix simply renames class variable named Error to ErrorCode.
>> The first name collides with global class name.
>>
>> This will help me to update self-bootstrapping environment for Squeak
>> 3.9 and make its public repository
>> (http://www.squeaksource.com/KernelImage.html) usable.
>>
>> -- Pavel
>> <condenseChanges fix.st>
>> <AsyncFile fix.cs>
>>
>
>

Adrian Lienhard

Re: Patch request for 7036

I'm working on it right now. I'll let you know...
Adrian

On Jul 9, 2006, at 16:49 , stéphane ducasse wrote:

> Adrian
>
> what is the status of this bug?
> I'm lost there.
>
> Stef
>
> On 7 juil. 06, at 13:15, Adrian Lienhard wrote:
>
>> Hi Pavel,
>>
>> I started looking into the condenseChanges problem (http://
>> bugs.impara.de/view.php?id=3737).
>>
>> In the IRC log which is attached to the Mantis report there is
>> some talk about inconsistencies with the Traits structure in
>> memory (and some code which should fix this). I'd like to
>> understand what is wrong. Do you know more? Or do you know who is
>> "Gazza" resp. "guru'?
>>
>> Cheers,
>> Adrian
>>
>> On Jun 30, 2006, at 12:19 , Pavel Krivanek wrote:
>>
>>> Hi Stef,
>>>
>>> can you put this two patches into the next 3.9a release?
>>>
>>> condenseChanges fix is related to http://bugs.impara.de/view.php?
>>> id=3737
>>> - this patch doesn't solve all problems of condenseChanges
>>> routine but
>>> it's better than nothing.
>>>
>>> AsyncFile fix simply renames class variable named Error to
>>> ErrorCode.
>>> The first name collides with global class name.
>>>
>>> This will help me to update self-bootstrapping environment for
>>> Squeak
>>> 3.9 and make its public repository
>>> (http://www.squeaksource.com/KernelImage.html) usable.
>>>
>>> -- Pavel
>>> <condenseChanges fix.st>
>>> <AsyncFile fix.cs>
>>>
>>
>>
>
>

stéphane ducasse-2

Re: Patch request for 7036

Excellent!
I'm sorting my house (arghhhh) and I will push some fixes.

Stef

> I'm working on it right now. I'll let you know...
> Adrian
>
> On Jul 9, 2006, at 16:49 , stéphane ducasse wrote:
>
>> Adrian
>>
>> what is the status of this bug?
>> I'm lost there.
>>
>> Stef
>>
>> On 7 juil. 06, at 13:15, Adrian Lienhard wrote:
>>
>>> Hi Pavel,
>>>
>>> I started looking into the condenseChanges problem (http://
>>> bugs.impara.de/view.php?id=3737).
>>>
>>> In the IRC log which is attached to the Mantis report there is
>>> some talk about inconsistencies with the Traits structure in
>>> memory (and some code which should fix this). I'd like to
>>> understand what is wrong. Do you know more? Or do you know who is
>>> "Gazza" resp. "guru'?
>>>
>>> Cheers,
>>> Adrian
>>>
>>> On Jun 30, 2006, at 12:19 , Pavel Krivanek wrote:
>>>
>>>> Hi Stef,
>>>>
>>>> can you put this two patches into the next 3.9a release?
>>>>
>>>> condenseChanges fix is related to http://bugs.impara.de/view.php?
>>>> id=3737
>>>> - this patch doesn't solve all problems of condenseChanges
>>>> routine but
>>>> it's better than nothing.
>>>>
>>>> AsyncFile fix simply renames class variable named Error to
>>>> ErrorCode.
>>>> The first name collides with global class name.
>>>>
>>>> This will help me to update self-bootstrapping environment for
>>>> Squeak
>>>> 3.9 and make its public repository
>>>> (http://www.squeaksource.com/KernelImage.html) usable.
>>>>
>>>> -- Pavel
>>>> <condenseChanges fix.st>
>>>> <AsyncFile fix.cs>
>>>>
>>>
>>>
>>
>>
>
>
>

Adrian Lienhard

Re: Patch request for 7036

I added a note to the report with the necessary steps to include the
fixes (I posted them as mcz to the 3.9 inbox). The manual test of
Pavel runs without failures now.

Adrian

On Jul 9, 2006, at 18:17 , stéphane ducasse wrote:

> Excellent!
> I'm sorting my house (arghhhh) and I will push some fixes.
>
> Stef
>
>> I'm working on it right now. I'll let you know...
>> Adrian
>>
>> On Jul 9, 2006, at 16:49 , stéphane ducasse wrote:
>>
>>> Adrian
>>>
>>> what is the status of this bug?
>>> I'm lost there.
>>>
>>> Stef
>>>
>>> On 7 juil. 06, at 13:15, Adrian Lienhard wrote:
>>>
>>>> Hi Pavel,
>>>>
>>>> I started looking into the condenseChanges problem (http://
>>>> bugs.impara.de/view.php?id=3737).
>>>>
>>>> In the IRC log which is attached to the Mantis report there is
>>>> some talk about inconsistencies with the Traits structure in
>>>> memory (and some code which should fix this). I'd like to
>>>> understand what is wrong. Do you know more? Or do you know who
>>>> is "Gazza" resp. "guru'?
>>>>
>>>> Cheers,
>>>> Adrian
>>>>
>>>> On Jun 30, 2006, at 12:19 , Pavel Krivanek wrote:
>>>>
>>>>> Hi Stef,
>>>>>
>>>>> can you put this two patches into the next 3.9a release?
>>>>>
>>>>> condenseChanges fix is related to http://bugs.impara.de/
>>>>> view.php?id=3737
>>>>> - this patch doesn't solve all problems of condenseChanges
>>>>> routine but
>>>>> it's better than nothing.
>>>>>
>>>>> AsyncFile fix simply renames class variable named Error to
>>>>> ErrorCode.
>>>>> The first name collides with global class name.
>>>>>
>>>>> This will help me to update self-bootstrapping environment for
>>>>> Squeak
>>>>> 3.9 and make its public repository
>>>>> (http://www.squeaksource.com/KernelImage.html) usable.
>>>>>
>>>>> -- Pavel
>>>>> <condenseChanges fix.st>
>>>>> <AsyncFile fix.cs>
>>>>>
>>>>
>>>>
>>>
>>>
>>
>>
>>
>
>

stéphane ducasse-2

Re: Patch request for 7036

Excellent!

Stef

> I added a note to the report with the necessary steps to include
> the fixes (I posted them as mcz to the 3.9 inbox). The manual test
> of Pavel runs without failures now.