Smalltalk › Pharo › Pharo Smalltalk Developers

Pharo 5.0 Tiny Feature Request

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

14 messages Options

Sean P. DeNigris

Pharo 5.0 Tiny Feature Request

Administrator

I know our policy is to only backport severe bug fixes, but I have one method I'd like added to 5.0 which would make my life a lot easier. Since NBMacShell has been removed, there doesn't seem to be a built-in way to send simple shell commands, which has broken all my project/image load scripts. I propose the following addition which will restore that basic functionality:

LibC class>>system: command
^ self ffiCall: #(#int #system #(#char #* #command)) module: self

It doesn't change any existing behavior, so seems relatively risk-free. What do you think?

Cheers,
Sean

Max Leske

Re: Pharo 5.0 Tiny Feature Request

Why don’t you use OSSubprocess?

Cheers,
Max

> On 18 Jun 2016, at 16:24, Sean P. DeNigris <[hidden email]> wrote:
>
> I know our policy is to only backport severe bug fixes, but I have one method
> I'd like added to 5.0 which would make my life a lot easier. Since
> NBMacShell has been removed, there doesn't seem to be a built-in way to send
> simple shell commands, which has broken all my project/image load scripts. I
> propose the following addition which will restore that basic functionality:
>
> LibC class>>system: command
> ^ self ffiCall: #(#int #system #(#char #* #command)) module: self
>
> It doesn't change any existing behavior, so seems relatively risk-free. What
> do you think?
>
>
>
> -----
> Cheers,
> Sean
> --
> View this message in context: http://forum.world.st/Pharo-5-0-Tiny-Feature-Request-tp4901682.html
> Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.
>

Sean P. DeNigris

Re: Pharo 5.0 Tiny Feature Request

Administrator

Max Leske wrote

Why don’t you use OSSubprocess?

My scripts require this functionality to be pre-loaded in a vanilla image. Also, on a minor note, some projects use OSProcess and I thought OSSP and OSP are incompatible.

Cheers,
Sean

Max Leske

Re: Pharo 5.0 Tiny Feature Request

> On 19 Jun 2016, at 01:44, Sean P. DeNigris <[hidden email]> wrote:
>
> Max Leske wrote
>> Why don’t you use OSSubprocess?
>
> My scripts require this functionality to be pre-loaded in a vanilla image.

Ok, just wanted to check.

> Also, on a minor note, some projects use OSProcess and I thought OSSP and
> OSP are incompatible.

Not as far as I know. OSSubProcess uses the OSProcess VM plugin but is otherwise independent.

Cheers,
Max

>
>
>
> -----
> Cheers,
> Sean
> --
> View this message in context: http://forum.world.st/Pharo-5-0-Tiny-Feature-Request-tp4901682p4901727.html
> Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.
>

stepharo

Re: Pharo 5.0 Tiny Feature Request

In reply to this post by Sean P. DeNigris

open a bug entry.

Stef

Le 19/6/16 à 01:44, Sean P. DeNigris a écrit :

> Max Leske wrote
>> Why don’t you use OSSubprocess?
> My scripts require this functionality to be pre-loaded in a vanilla image.
> Also, on a minor note, some projects use OSProcess and I thought OSSP and
> OSP are incompatible.
>
>
>
> -----
> Cheers,
> Sean
> --
> View this message in context: http://forum.world.st/Pharo-5-0-Tiny-Feature-Request-tp4901682p4901727.html
> Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.
>
>

Peter Uhnak

Re: Pharo 5.0 Tiny Feature Request

In reply to this post by Max Leske

On Sun, Jun 19, 2016 at 10:05:45AM +0200, Max Leske wrote:

>
> > On 19 Jun 2016, at 01:44, Sean P. DeNigris <[hidden email]> wrote:
> >
> > Max Leske wrote
> >> Why don’t you use OSSubprocess?
> >
> > My scripts require this functionality to be pre-loaded in a vanilla image.
>
> Ok, just wanted to check.
>
> > Also, on a minor note, some projects use OSProcess and I thought OSSP and
> > OSP are incompatible.
>
> Not as far as I know. OSSubProcess uses the OSProcess VM plugin but is otherwise independent.

They should be incompatible at the moment. There was a discussion about this some time ago in regards to Moose where you couldn't load & run OSSubprocess because OSProcess was already installed.
It was solved by replacing OSProcess with this system call Sean is proposing to have in Pharo.

Peter

Sean P. DeNigris

Re: Pharo 5.0 Tiny Feature Request

Administrator

In reply to this post by stepharo

stepharo wrote

open a bug entry.

Done:
18757 Simple Shell Command Eval for 5.0
https://pharo.fogbugz.com/f/cases/18757/Simple-Shell-Command-Eval-for-5-0

But I'm not sure how to commit it. It changes UFFI which has a configuration. What do I commit (package, slice, config(s))? And to where (UFFI repo, inbox)?

Cheers,
Sean

Sean P. DeNigris

Re: Pharo 5.0 Tiny Feature Request

Administrator

Sean P. DeNigris wrote

But I'm not sure how to commit it. It changes UFFI which has a configuration. What do I commit (package, slice, config(s))? And to where (UFFI repo, inbox)?

Bump :) How is it possible that there's not a simple answer to how to commit a small fix to core?!

Cheers,
Sean

hah… wait a bit… I will integrate it…

> On 28 Jul 2016, at 16:10, Sean P. DeNigris <[hidden email]> wrote:
>
> Sean P. DeNigris wrote
>> Bump :)
>> [waiting patiently while all my build scripts are broken in Pharo 5.0]
>
> So close! Marked "Fix to include". Who can integrate it?!
>
>
>
> -----
> Cheers,
> Sean
> --
> View this message in context: http://forum.world.st/Pharo-5-0-Tiny-Feature-Request-tp4901682p4908459.html
> Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.
>