Pharo-Compatibility-fbs.2

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Pharo-Compatibility-fbs.2

Frank Shearar-3
Installer ss3
    project: 'Scratch-fbs';
    install: 'Pharo-Compatibility-fbs.2.mcz'

It still only contains a single method, but instead of Symbol >>
#isBinary, it's String >> #includesSubstring:.

I wouldn't mind seeing this applied in trunk - and will, if people
like it (and moving #includesSubString: to 45Deprecated) - but for now
this is where you find the stuff you need for your favourite
#includesSubstring:-using Pharo package.

frank

Reply | Threaded
Open this post in threaded view
|

Re: Pharo-Compatibility-fbs.2

Nicolas Cellier
I think the origin of the problem is ANSI which defines #subStrings:
All other methods are spelled substring but #includesSubString:

I agree that #includesSubstring: looks better, you can include it in
trunk if you want, but I would be more carefull than Pharo about
deprecation
It is breaking compatibility of some packages (Seaside at least though
it is easy to Grease it)
I personnally think that this is quite high a price for such a minor
clean-up, and would rather call this a gratuitous breakage...

Nicolas

2013/3/8 Frank Shearar <[hidden email]>:

> Installer ss3
>     project: 'Scratch-fbs';
>     install: 'Pharo-Compatibility-fbs.2.mcz'
>
> It still only contains a single method, but instead of Symbol >>
> #isBinary, it's String >> #includesSubstring:.
>
> I wouldn't mind seeing this applied in trunk - and will, if people
> like it (and moving #includesSubString: to 45Deprecated) - but for now
> this is where you find the stuff you need for your favourite
> #includesSubstring:-using Pharo package.
>
> frank
>

Reply | Threaded
Open this post in threaded view
|

Re: Pharo-Compatibility-fbs.2

Frank Shearar-3
Yup, hence why I think that - if it goes in - it should be deprecated
for some period of time. Or maybe forever, as having a
backwards-compatibility package doesn't hurt.

frank

On 8 March 2013 22:02, Nicolas Cellier
<[hidden email]> wrote:

> I think the origin of the problem is ANSI which defines #subStrings:
> All other methods are spelled substring but #includesSubString:
>
> I agree that #includesSubstring: looks better, you can include it in
> trunk if you want, but I would be more carefull than Pharo about
> deprecation
> It is breaking compatibility of some packages (Seaside at least though
> it is easy to Grease it)
> I personnally think that this is quite high a price for such a minor
> clean-up, and would rather call this a gratuitous breakage...
>
> Nicolas
>
> 2013/3/8 Frank Shearar <[hidden email]>:
>> Installer ss3
>>     project: 'Scratch-fbs';
>>     install: 'Pharo-Compatibility-fbs.2.mcz'
>>
>> It still only contains a single method, but instead of Symbol >>
>> #isBinary, it's String >> #includesSubstring:.
>>
>> I wouldn't mind seeing this applied in trunk - and will, if people
>> like it (and moving #includesSubString: to 45Deprecated) - but for now
>> this is where you find the stuff you need for your favourite
>> #includesSubstring:-using Pharo package.
>>
>> frank
>>
>