PharoInProgress CI Failing

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

PharoInProgress CI Failing

Sean P. DeNigris
Administrator
It looks like it's related to the added Launcher chapter:
    ./AllWorkInProgress.tex:4366: Package pdftex.def Error: File `figures/pharolaun
cher_edited_new.png' not found.

But the apparently-offending line:
    +Pharo Launcher>file://figures/pharolauncher_edited_new.png|width=100|label=obj+

Does not seem materially different to me than this one from Bloc which does not seem to be causing the same error:
    +A more complex use of anchor.>file://figures/moreComplexAnchor.png|width=80|label=moreComplex+

The file seems to be there https://github.com/SquareBracketAssociates/PharoInProgress/blob/master/PharoLauncherTutorial/figures/pharolauncher_edited_new.png

Any ideas?
Cheers,
Sean
Reply | Threaded
Open this post in threaded view
|

Re: PharoInProgress CI Failing

Dmitri Zagidulin
I had something very similar happen to me today, when porting the Environment chapter of UPBE (the same error in a figure reference, where one line would work, but a similar one (or, actually an exact same one that I retyped) line would compile fine).

It turned out that, somehow, there were non-printable characters in the file name.
You can see if this is the case for you by either doing a 'cat -v' of your file, or just re-typing the line yourself. 
I have no idea how those weird characters made it into there, by the way! Maybe something exotic with cut&paste, or a find&replace with regexes in Atom.

Actually, I just pulled a fresh copy of the repo, and it doesn't look like there's trouble characters. 
But, I've noticed a couple of other things:

1) In https://github.com/SmalltalkZen/UpdatedPharoByExample/blob/master/CONTRIBUTING.md , in Caveats section, it says "You must neither use spaces nor underscores (_) in file names."  Though I doubt it's causing the problem above, why have just the pharo launcher chapter use underscore, when the rest of the chapter names use camel case?

2) All of the labels for the figures are the same, 'obj'. The labels are used for in-line figure references, so having all of the same labels is not helpful (I'm surprised the compiler doesn't complain).

3) Most importantly (this is what actually fixed the error and allowed the book to compile), you also have to add the new chapter to support/templates/book.latex.template, in the graphicspath section. (It can't find the file because it doesn't know to search PharoLauncherTutorial/figures/). (This is mentioned in https://github.com/SmalltalkZen/UpdatedPharoByExample/blob/master/CONTRIBUTING.md in the 'adding a chapter' section).



On Mon, Apr 13, 2015 at 12:32 PM, Sean P. DeNigris <[hidden email]> wrote:
It looks like it's related to the added Launcher chapter:
    ./AllWorkInProgress.tex:4366: Package pdftex.def Error: File
`figures/pharolaun
cher_edited_new.png' not found.

But the apparently-offending line:
    +Pharo
Launcher>file://figures/pharolauncher_edited_new.png|width=100|label=obj+

Does not seem materially different to me than this one from Bloc which does
not seem to be causing the same error:
    +A more complex use of
anchor.>file://figures/moreComplexAnchor.png|width=80|label=moreComplex+

The file seems to be there
https://github.com/SquareBracketAssociates/PharoInProgress/blob/master/PharoLauncherTutorial/figures/pharolauncher_edited_new.png

Any ideas?



-----
Cheers,
Sean
--
View this message in context: http://forum.world.st/PharoInProgress-CI-Failing-tp4819380.html
Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.


Reply | Threaded
Open this post in threaded view
|

Re: PharoInProgress CI Failing

Sean P. DeNigris
Administrator
Dmitri Zagidulin wrote
you also have to add the new chapter to support/templates/book.latex.template, in the graphicspath section.
Thanks! The build is green again and I passed your other suggestions to Jigyasa
Cheers,
Sean