[Please Test] Refactoring for BorderedMorph to use BorderStyle

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
22 messages Options
12
Reply | Threaded
Open this post in threaded view
|

[Please Test] Refactoring for BorderedMorph to use BorderStyle

marcel.taeumel
Hi, there.

Please find attached a refactoring of BorderedMorph to make use of BorderStyle like regular morphs do. Maybe, in the future, we can get rid of BorderedMorph.

It includes:
- No instVar access to borderColor and borderWidth but message sends.
- No #inset or #raised anymore when asking a morph for its #borderColor. Just colors.
- Copying the prototypical border styles from the UI theme when used in morphs.
- A post-load script that updates all your morphs in the image. Not that important but good for keeping your current tools opened.

After a few days of no complaints, I will merge it into Trunk.

Best,
Marcel




border-layout.2.cs (171K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [Please Test] Refactoring for BorderedMorph to use BorderStyle

marcel.taeumel
Anybody? Just file it in your work image and tell me what happens.

Best,
Marcel



--
Sent from: http://forum.world.st/Squeak-Dev-f45488.html

Reply | Threaded
Open this post in threaded view
|

Re: [Please Test] Refactoring for BorderedMorph to use BorderStyle

Hannes Hirzel
thanks for the reminder, not today but tomorrow ... HH

On 4/13/18, marcel.taeumel <[hidden email]> wrote:

> Anybody? Just file it in your work image and tell me what happens.
>
> Best,
> Marcel
>
>
>
> --
> Sent from: http://forum.world.st/Squeak-Dev-f45488.html
>
>

Reply | Threaded
Open this post in threaded view
|

Re: [Please Test] Refactoring for BorderedMorph to use BorderStyle

Karl Ramberg
A few issues:
When I open the Objects tool I get several errors with Polygon in for example the Games tab.
When I choose Quit in the menu, the buttons does not have a black outline. 

Best,
Karl




On Fri, Apr 13, 2018 at 9:37 AM, H. Hirzel <[hidden email]> wrote:
thanks for the reminder, not today but tomorrow ... HH

On 4/13/18, marcel.taeumel <[hidden email]> wrote:
> Anybody? Just file it in your work image and tell me what happens.
>
> Best,
> Marcel
>
>
>
> --
> Sent from: http://forum.world.st/Squeak-Dev-f45488.html
>
>




Reply | Threaded
Open this post in threaded view
|

Re: [Please Test] Refactoring for BorderedMorph to use BorderStyle

Karl Ramberg
Issues with PolygonMorph seem to happen only if you never have open Object tool before you file in the BorderedMorph change set.
Some of the instance variables like #closed and #arrows  are nil.

Best,
Karl 


On Fri, Apr 13, 2018 at 8:47 PM, karl ramberg <[hidden email]> wrote:
A few issues:
When I open the Objects tool I get several errors with Polygon in for example the Games tab.
When I choose Quit in the menu, the buttons does not have a black outline. 

Best,
Karl




On Fri, Apr 13, 2018 at 9:37 AM, H. Hirzel <[hidden email]> wrote:
thanks for the reminder, not today but tomorrow ... HH

On 4/13/18, marcel.taeumel <[hidden email]> wrote:
> Anybody? Just file it in your work image and tell me what happens.
>
> Best,
> Marcel
>
>
>
> --
> Sent from: http://forum.world.st/Squeak-Dev-f45488.html
>
>





Reply | Threaded
Open this post in threaded view
|

Re: [Please Test] Refactoring for BorderedMorph to use BorderStyle

Chris Muller-3
In reply to this post by marcel.taeumel
Gonna check it out right now!

On Fri, Apr 13, 2018 at 1:23 AM, marcel.taeumel <[hidden email]> wrote:

> Anybody? Just file it in your work image and tell me what happens.
>
> Best,
> Marcel
>
>
>
> --
> Sent from: http://forum.world.st/Squeak-Dev-f45488.html
>

Reply | Threaded
Open this post in threaded view
|

Re: [Please Test] Refactoring for BorderedMorph to use BorderStyle

marcel.taeumel
In reply to this post by Karl Ramberg
Hi Karl,

I found the bug with PolygonMorph. However, I cannot reproduce the Quit issue. Can you share a screenshot?

Best,
Marcel

Am 13.04.2018 20:47:20 schrieb karl ramberg <[hidden email]>:

A few issues:
When I open the Objects tool I get several errors with Polygon in for example the Games tab.
When I choose Quit in the menu, the buttons does not have a black outline. 

Best,
Karl




On Fri, Apr 13, 2018 at 9:37 AM, H. Hirzel <[hidden email]> wrote:
thanks for the reminder, not today but tomorrow ... HH

On 4/13/18, marcel.taeumel <[hidden email]> wrote:
> Anybody? Just file it in your work image and tell me what happens.
>
> Best,
> Marcel
>
>
>
> --
> Sent from: http://forum.world.st/Squeak-Dev-f45488.html
>
>




Reply | Threaded
Open this post in threaded view
|

Re: [Please Test] Refactoring for BorderedMorph to use BorderStyle

Karl Ramberg
Hi,
Skärmklipp2.jpg is before applying change set.

Best,
Karl

On Sat, Apr 14, 2018 at 10:00 AM, Marcel Taeumel <[hidden email]> wrote:
Hi Karl,

I found the bug with PolygonMorph. However, I cannot reproduce the Quit issue. Can you share a screenshot?

Best,
Marcel

Am 13.04.2018 20:47:20 schrieb karl ramberg <[hidden email]>:

A few issues:
When I open the Objects tool I get several errors with Polygon in for example the Games tab.
When I choose Quit in the menu, the buttons does not have a black outline. 

Best,
Karl




On Fri, Apr 13, 2018 at 9:37 AM, H. Hirzel <[hidden email]> wrote:
thanks for the reminder, not today but tomorrow ... HH

On 4/13/18, marcel.taeumel <[hidden email]> wrote:
> Anybody? Just file it in your work image and tell me what happens.
>
> Best,
> Marcel
>
>
>
> --
> Sent from: http://forum.world.st/Squeak-Dev-f45488.html
>
>









=?UTF-8?B?U2vDpHJta2xpcHAuSlBH?= (19K) Download Attachment
=?UTF-8?Q?Sk=C3=A4rmklipp2=2EJPG?= (23K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [Please Test] Refactoring for BorderedMorph to use BorderStyle

marcel.taeumel
Hi Karl,

well, I also had to update wrong border styles in the UI themes. If you use a custom theme, you should rebuild that, too. There used to be "BorderStyle default" in the themes, which had to be changed to "BorderStyle simple". Sorry, for that inconvenience.

In a fresh Trunk, it works fine.

Best,
Marcel

Am 14.04.2018 11:27:16 schrieb karl ramberg <[hidden email]>:

Hi,
Skärmklipp2.jpg is before applying change set.

Best,
Karl

On Sat, Apr 14, 2018 at 10:00 AM, Marcel Taeumel <[hidden email]> wrote:
Hi Karl,

I found the bug with PolygonMorph. However, I cannot reproduce the Quit issue. Can you share a screenshot?

Best,
Marcel

Am 13.04.2018 20:47:20 schrieb karl ramberg <[hidden email]>:

A few issues:
When I open the Objects tool I get several errors with Polygon in for example the Games tab.
When I choose Quit in the menu, the buttons does not have a black outline. 

Best,
Karl




On Fri, Apr 13, 2018 at 9:37 AM, H. Hirzel <[hidden email]> wrote:
thanks for the reminder, not today but tomorrow ... HH

On 4/13/18, marcel.taeumel <[hidden email]> wrote:
> Anybody? Just file it in your work image and tell me what happens.
>
> Best,
> Marcel
>
>
>
> --
> Sent from: http://forum.world.st/Squeak-Dev-f45488.html
>
>








Reply | Threaded
Open this post in threaded view
|

Re: [Please Test] Refactoring for BorderedMorph to use BorderStyle

Karl Ramberg
Ok, I understand 

Best,
Karl


On Sat, Apr 14, 2018 at 11:39 AM, Marcel Taeumel <[hidden email]> wrote:
Hi Karl,

well, I also had to update wrong border styles in the UI themes. If you use a custom theme, you should rebuild that, too. There used to be "BorderStyle default" in the themes, which had to be changed to "BorderStyle simple". Sorry, for that inconvenience.

In a fresh Trunk, it works fine.

Best,
Marcel

Am 14.04.2018 11:27:16 schrieb karl ramberg <[hidden email]>:

Hi,
Skärmklipp2.jpg is before applying change set.

Best,
Karl

On Sat, Apr 14, 2018 at 10:00 AM, Marcel Taeumel <[hidden email]> wrote:
Hi Karl,

I found the bug with PolygonMorph. However, I cannot reproduce the Quit issue. Can you share a screenshot?

Best,
Marcel

Am 13.04.2018 20:47:20 schrieb karl ramberg <[hidden email]>:

A few issues:
When I open the Objects tool I get several errors with Polygon in for example the Games tab.
When I choose Quit in the menu, the buttons does not have a black outline. 

Best,
Karl




On Fri, Apr 13, 2018 at 9:37 AM, H. Hirzel <[hidden email]> wrote:
thanks for the reminder, not today but tomorrow ... HH

On 4/13/18, marcel.taeumel <[hidden email]> wrote:
> Anybody? Just file it in your work image and tell me what happens.
>
> Best,
> Marcel
>
>
>
> --
> Sent from: http://forum.world.st/Squeak-Dev-f45488.html
>
>












Reply | Threaded
Open this post in threaded view
|

Re: [Please Test] Refactoring for BorderedMorph to use BorderStyle

David T. Lewis
In reply to this post by marcel.taeumel
On Thu, Apr 12, 2018 at 11:23:42PM -0700, marcel.taeumel wrote:
> Anybody? Just file it in your work image and tell me what happens.
>

Sorry I overlook this. I filed the changes in earlier today. All is
well with browsers and such, but when I open an Elipse from the Objects
tab, then rotate it with the halo handle, things go wrong. It looks
like the 'closed' instance variable in the PolygonMorph is nil.

I think you may have already addressed this from Karl's report.

Dave


Reply | Threaded
Open this post in threaded view
|

Re: [Please Test] Refactoring for BorderedMorph to use BorderStyle

marcel.taeumel
Thanks Karl and Dave. Chris, does it work in your image(s)?

Best,
Marcel

Am 14.04.2018 21:00:55 schrieb David T. Lewis <[hidden email]>:

On Thu, Apr 12, 2018 at 11:23:42PM -0700, marcel.taeumel wrote:
> Anybody? Just file it in your work image and tell me what happens.
>

Sorry I overlook this. I filed the changes in earlier today. All is
well with browsers and such, but when I open an Elipse from the Objects
tab, then rotate it with the halo handle, things go wrong. It looks
like the 'closed' instance variable in the PolygonMorph is nil.

I think you may have already addressed this from Karl's report.

Dave




Reply | Threaded
Open this post in threaded view
|

Re: [Please Test] Refactoring for BorderedMorph to use BorderStyle

Karl Ramberg
Hi,
Slightly off topic:
I have been looking at border stuff in latest Trunk image and I can't get border #inset and #raised to work.

The complex borders work.

Best,
Karl


On Sun, Apr 15, 2018 at 9:34 AM, Marcel Taeumel <[hidden email]> wrote:
Thanks Karl and Dave. Chris, does it work in your image(s)?

Best,
Marcel

Am 14.04.2018 21:00:55 schrieb David T. Lewis <[hidden email]>:

On Thu, Apr 12, 2018 at 11:23:42PM -0700, marcel.taeumel wrote:
> Anybody? Just file it in your work image and tell me what happens.
>

Sorry I overlook this. I filed the changes in earlier today. All is
well with browsers and such, but when I open an Elipse from the Objects
tab, then rotate it with the halo handle, things go wrong. It looks
like the 'closed' instance variable in the PolygonMorph is nil.

I think you may have already addressed this from Karl's report.

Dave








Reply | Threaded
Open this post in threaded view
|

Re: [Please Test] Refactoring for BorderedMorph to use BorderStyle

Karl Ramberg
Hi,

#inset and #raised does not work either with or without Marcels changeset.

Best,
Karl


On Tue, Apr 17, 2018 at 6:50 PM, karl ramberg <[hidden email]> wrote:
Hi,
Slightly off topic:
I have been looking at border stuff in latest Trunk image and I can't get border #inset and #raised to work.

The complex borders work.

Best,
Karl


On Sun, Apr 15, 2018 at 9:34 AM, Marcel Taeumel <[hidden email]> wrote:
Thanks Karl and Dave. Chris, does it work in your image(s)?

Best,
Marcel

Am 14.04.2018 21:00:55 schrieb David T. Lewis <[hidden email]>:

On Thu, Apr 12, 2018 at 11:23:42PM -0700, marcel.taeumel wrote:
> Anybody? Just file it in your work image and tell me what happens.
>

Sorry I overlook this. I filed the changes in earlier today. All is
well with browsers and such, but when I open an Elipse from the Objects
tab, then rotate it with the halo handle, things go wrong. It looks
like the 'closed' instance variable in the PolygonMorph is nil.

I think you may have already addressed this from Karl's report.

Dave









Reply | Threaded
Open this post in threaded view
|

Re: [Please Test] Refactoring for BorderedMorph to use BorderStyle

marcel.taeumel
Well, they kind of work if you set the #baseColor in the respective border style. Otherwise, yes, I noticed that, too. At least the Mines game draws the fields on its own. So, there might be a bug hidden in drawing those border styles.

Best,
Marcel

Am 18.04.2018 20:31:31 schrieb karl ramberg <[hidden email]>:

Hi,

#inset and #raised does not work either with or without Marcels changeset.

Best,
Karl


On Tue, Apr 17, 2018 at 6:50 PM, karl ramberg <[hidden email]> wrote:
Hi,
Slightly off topic:
I have been looking at border stuff in latest Trunk image and I can't get border #inset and #raised to work.

The complex borders work.

Best,
Karl


On Sun, Apr 15, 2018 at 9:34 AM, Marcel Taeumel <[hidden email]> wrote:
Thanks Karl and Dave. Chris, does it work in your image(s)?

Best,
Marcel

Am 14.04.2018 21:00:55 schrieb David T. Lewis <[hidden email]>:

On Thu, Apr 12, 2018 at 11:23:42PM -0700, marcel.taeumel wrote:
> Anybody? Just file it in your work image and tell me what happens.
>

Sorry I overlook this. I filed the changes in earlier today. All is
well with browsers and such, but when I open an Elipse from the Objects
tab, then rotate it with the halo handle, things go wrong. It looks
like the 'closed' instance variable in the PolygonMorph is nil.

I think you may have already addressed this from Karl's report.

Dave









Reply | Threaded
Open this post in threaded view
|

Re: [Please Test] Refactoring for BorderedMorph to use BorderStyle

Karl Ramberg
Well,
These border styles have been broken for some time.
I checked some old images and it worked in the 4.6 image but not in 5.1 so something changed between there :-)

Best,
Karl

On Thu, Apr 19, 2018 at 11:44 AM, Marcel Taeumel <[hidden email]> wrote:
Well, they kind of work if you set the #baseColor in the respective border style. Otherwise, yes, I noticed that, too. At least the Mines game draws the fields on its own. So, there might be a bug hidden in drawing those border styles.

Best,
Marcel

Am 18.04.2018 20:31:31 schrieb karl ramberg <[hidden email]>:

Hi,

#inset and #raised does not work either with or without Marcels changeset.

Best,
Karl


On Tue, Apr 17, 2018 at 6:50 PM, karl ramberg <[hidden email]> wrote:
Hi,
Slightly off topic:
I have been looking at border stuff in latest Trunk image and I can't get border #inset and #raised to work.

The complex borders work.

Best,
Karl


On Sun, Apr 15, 2018 at 9:34 AM, Marcel Taeumel <[hidden email]> wrote:
Thanks Karl and Dave. Chris, does it work in your image(s)?

Best,
Marcel

Am 14.04.2018 21:00:55 schrieb David T. Lewis <[hidden email]>:

On Thu, Apr 12, 2018 at 11:23:42PM -0700, marcel.taeumel wrote:
> Anybody? Just file it in your work image and tell me what happens.
>

Sorry I overlook this. I filed the changes in earlier today. All is
well with browsers and such, but when I open an Elipse from the Objects
tab, then rotate it with the halo handle, things go wrong. It looks
like the 'closed' instance variable in the PolygonMorph is nil.

I think you may have already addressed this from Karl's report.

Dave













Reply | Threaded
Open this post in threaded view
|

Re: [Please Test] Refactoring for BorderedMorph to use BorderStyle

Karl Ramberg
Hm,
Actually broken in 5.0 
Image conversion issue ??
Best,
Karl

On Thu, Apr 19, 2018 at 9:56 PM, karl ramberg <[hidden email]> wrote:
Well,
These border styles have been broken for some time.
I checked some old images and it worked in the 4.6 image but not in 5.1 so something changed between there :-)

Best,
Karl

On Thu, Apr 19, 2018 at 11:44 AM, Marcel Taeumel <[hidden email]> wrote:
Well, they kind of work if you set the #baseColor in the respective border style. Otherwise, yes, I noticed that, too. At least the Mines game draws the fields on its own. So, there might be a bug hidden in drawing those border styles.

Best,
Marcel

Am 18.04.2018 20:31:31 schrieb karl ramberg <[hidden email]>:

Hi,

#inset and #raised does not work either with or without Marcels changeset.

Best,
Karl


On Tue, Apr 17, 2018 at 6:50 PM, karl ramberg <[hidden email]> wrote:
Hi,
Slightly off topic:
I have been looking at border stuff in latest Trunk image and I can't get border #inset and #raised to work.

The complex borders work.

Best,
Karl


On Sun, Apr 15, 2018 at 9:34 AM, Marcel Taeumel <[hidden email]> wrote:
Thanks Karl and Dave. Chris, does it work in your image(s)?

Best,
Marcel

Am 14.04.2018 21:00:55 schrieb David T. Lewis <[hidden email]>:

On Thu, Apr 12, 2018 at 11:23:42PM -0700, marcel.taeumel wrote:
> Anybody? Just file it in your work image and tell me what happens.
>

Sorry I overlook this. I filed the changes in earlier today. All is
well with browsers and such, but when I open an Elipse from the Objects
tab, then rotate it with the halo handle, things go wrong. It looks
like the 'closed' instance variable in the PolygonMorph is nil.

I think you may have already addressed this from Karl's report.

Dave














Reply | Threaded
Open this post in threaded view
|

Re: [Please Test] Refactoring for BorderedMorph to use BorderStyle

David T. Lewis
Hi Karl,

Can you explain how I can see the problem with #raised and #inset borders?
I have a trunk level V3 image for comparison, so I can check if it might be
something related to the image conversion.

Dave


On Thu, Apr 19, 2018 at 10:04:32PM +0200, karl ramberg wrote:

> Hm,
> Actually broken in 5.0
> Image conversion issue ??
> Best,
> Karl
>
> On Thu, Apr 19, 2018 at 9:56 PM, karl ramberg <[hidden email]> wrote:
>
> > Well,
> > These border styles have been broken for some time.
> > I checked some old images and it worked in the 4.6 image but not in 5.1 so
> > something changed between there :-)
> >
> > Best,
> > Karl
> >
> > On Thu, Apr 19, 2018 at 11:44 AM, Marcel Taeumel <[hidden email]>
> > wrote:
> >
> >> Well, they kind of work if you set the #baseColor in the respective
> >> border style. Otherwise, yes, I noticed that, too. At least the Mines game
> >> draws the fields on its own. So, there might be a bug hidden in drawing
> >> those border styles.
> >>
> >> Best,
> >> Marcel
> >>
> >> Am 18.04.2018 20:31:31 schrieb karl ramberg <[hidden email]>:
> >> Hi,
> >>
> >> #inset and #raised does not work either with or without Marcels changeset.
> >>
> >> Best,
> >> Karl
> >>
> >>
> >> On Tue, Apr 17, 2018 at 6:50 PM, karl ramberg <[hidden email]>
> >> wrote:
> >>
> >>> Hi,
> >>> Slightly off topic:
> >>> I have been looking at border stuff in latest Trunk image and I can't
> >>> get border #inset and #raised to work.
> >>>
> >>> The complex borders work.
> >>>
> >>> Best,
> >>> Karl
> >>>
> >>>
> >>> On Sun, Apr 15, 2018 at 9:34 AM, Marcel Taeumel <[hidden email]>
> >>> wrote:
> >>>
> >>>> Thanks Karl and Dave. Chris, does it work in your image(s)?
> >>>>
> >>>> Best,
> >>>> Marcel
> >>>>
> >>>> Am 14.04.2018 21:00:55 schrieb David T. Lewis <[hidden email]>:
> >>>> On Thu, Apr 12, 2018 at 11:23:42PM -0700, marcel.taeumel wrote:
> >>>> > Anybody? Just file it in your work image and tell me what happens.
> >>>> >
> >>>>
> >>>> Sorry I overlook this. I filed the changes in earlier today. All is
> >>>> well with browsers and such, but when I open an Elipse from the Objects
> >>>> tab, then rotate it with the halo handle, things go wrong. It looks
> >>>> like the 'closed' instance variable in the PolygonMorph is nil.
> >>>>
> >>>> I think you may have already addressed this from Karl's report.
> >>>>
> >>>> Dave
> >>>>
> >>>>
> >>>>
> >>>>
> >>>>
> >>>>
> >>>
> >>
> >>
> >>
> >>
> >


Reply | Threaded
Open this post in threaded view
|

Re: [Please Test] Refactoring for BorderedMorph to use BorderStyle

Karl Ramberg
Hi,
This should show a thick border on the morph, with a simple raised "ilusion".
Should be same border width as second rectangle with a red border.

RectangleMorph new borderColor: #raised; borderWidth: 10; openInWorld
RectangleMorph new borderColor: Color red; borderWidth: 10; openInWorld

Best,
Karl


On Fri, Apr 20, 2018 at 2:57 AM, David T. Lewis <[hidden email]> wrote:
Hi Karl,

Can you explain how I can see the problem with #raised and #inset borders?
I have a trunk level V3 image for comparison, so I can check if it might be
something related to the image conversion.

Dave


On Thu, Apr 19, 2018 at 10:04:32PM +0200, karl ramberg wrote:
> Hm,
> Actually broken in 5.0
> Image conversion issue ??
> Best,
> Karl
>
> On Thu, Apr 19, 2018 at 9:56 PM, karl ramberg <[hidden email]> wrote:
>
> > Well,
> > These border styles have been broken for some time.
> > I checked some old images and it worked in the 4.6 image but not in 5.1 so
> > something changed between there :-)
> >
> > Best,
> > Karl
> >
> > On Thu, Apr 19, 2018 at 11:44 AM, Marcel Taeumel <[hidden email]>
> > wrote:
> >
> >> Well, they kind of work if you set the #baseColor in the respective
> >> border style. Otherwise, yes, I noticed that, too. At least the Mines game
> >> draws the fields on its own. So, there might be a bug hidden in drawing
> >> those border styles.
> >>
> >> Best,
> >> Marcel
> >>
> >> Am 18.04.2018 20:31:31 schrieb karl ramberg <[hidden email]>:
> >> Hi,
> >>
> >> #inset and #raised does not work either with or without Marcels changeset.
> >>
> >> Best,
> >> Karl
> >>
> >>
> >> On Tue, Apr 17, 2018 at 6:50 PM, karl ramberg <[hidden email]>
> >> wrote:
> >>
> >>> Hi,
> >>> Slightly off topic:
> >>> I have been looking at border stuff in latest Trunk image and I can't
> >>> get border #inset and #raised to work.
> >>>
> >>> The complex borders work.
> >>>
> >>> Best,
> >>> Karl
> >>>
> >>>
> >>> On Sun, Apr 15, 2018 at 9:34 AM, Marcel Taeumel <[hidden email]>
> >>> wrote:
> >>>
> >>>> Thanks Karl and Dave. Chris, does it work in your image(s)?
> >>>>
> >>>> Best,
> >>>> Marcel
> >>>>
> >>>> Am 14.04.2018 21:00:55 schrieb David T. Lewis <[hidden email]>:
> >>>> On Thu, Apr 12, 2018 at 11:23:42PM -0700, marcel.taeumel wrote:
> >>>> > Anybody? Just file it in your work image and tell me what happens.
> >>>> >
> >>>>
> >>>> Sorry I overlook this. I filed the changes in earlier today. All is
> >>>> well with browsers and such, but when I open an Elipse from the Objects
> >>>> tab, then rotate it with the halo handle, things go wrong. It looks
> >>>> like the 'closed' instance variable in the PolygonMorph is nil.
> >>>>
> >>>> I think you may have already addressed this from Karl's report.
> >>>>
> >>>> Dave
> >>>>
> >>>>
> >>>>
> >>>>
> >>>>
> >>>>
> >>>
> >>
> >>
> >>
> >>
> >





Reply | Threaded
Open this post in threaded view
|

Re: [Please Test] Refactoring for BorderedMorph to use BorderStyle

David T. Lewis
Thanks, I see it now.

The problem is also present in my "V3 trunk image", exactly as in the
trunk image. So it is not related to any differences in the coversion
to Spur in Squeak 5. It must be some other problem that was introduced
between Squeak 4.5 and 5.1.

I checked Squeak5.0-15113, and the problem is not happening there.

So ... it looks like something that was introduced between 5.0 and 5.1.

Dave


On Fri, Apr 20, 2018 at 06:59:49AM +0200, karl ramberg wrote:

> Hi,
> This should show a thick border on the morph, with a simple raised
> "ilusion".
> Should be same border width as second rectangle with a red border.
>
> RectangleMorph new borderColor: #raised; borderWidth: 10; openInWorld
> RectangleMorph new borderColor: Color red; borderWidth: 10; openInWorld
>
> Best,
> Karl
>
>
> On Fri, Apr 20, 2018 at 2:57 AM, David T. Lewis <[hidden email]> wrote:
>
> > Hi Karl,
> >
> > Can you explain how I can see the problem with #raised and #inset borders?
> > I have a trunk level V3 image for comparison, so I can check if it might be
> > something related to the image conversion.
> >
> > Dave
> >
> >
> > On Thu, Apr 19, 2018 at 10:04:32PM +0200, karl ramberg wrote:
> > > Hm,
> > > Actually broken in 5.0
> > > Image conversion issue ??
> > > Best,
> > > Karl
> > >
> > > On Thu, Apr 19, 2018 at 9:56 PM, karl ramberg <[hidden email]>
> > wrote:
> > >
> > > > Well,
> > > > These border styles have been broken for some time.
> > > > I checked some old images and it worked in the 4.6 image but not in
> > 5.1 so
> > > > something changed between there :-)
> > > >
> > > > Best,
> > > > Karl
> > > >
> > > > On Thu, Apr 19, 2018 at 11:44 AM, Marcel Taeumel <
> > [hidden email]>
> > > > wrote:
> > > >
> > > >> Well, they kind of work if you set the #baseColor in the respective
> > > >> border style. Otherwise, yes, I noticed that, too. At least the Mines
> > game
> > > >> draws the fields on its own. So, there might be a bug hidden in
> > drawing
> > > >> those border styles.
> > > >>
> > > >> Best,
> > > >> Marcel
> > > >>
> > > >> Am 18.04.2018 20:31:31 schrieb karl ramberg <[hidden email]>:
> > > >> Hi,
> > > >>
> > > >> #inset and #raised does not work either with or without Marcels
> > changeset.
> > > >>
> > > >> Best,
> > > >> Karl
> > > >>
> > > >>
> > > >> On Tue, Apr 17, 2018 at 6:50 PM, karl ramberg <[hidden email]>
> > > >> wrote:
> > > >>
> > > >>> Hi,
> > > >>> Slightly off topic:
> > > >>> I have been looking at border stuff in latest Trunk image and I can't
> > > >>> get border #inset and #raised to work.
> > > >>>
> > > >>> The complex borders work.
> > > >>>
> > > >>> Best,
> > > >>> Karl
> > > >>>
> > > >>>
> > > >>> On Sun, Apr 15, 2018 at 9:34 AM, Marcel Taeumel <
> > [hidden email]>
> > > >>> wrote:
> > > >>>
> > > >>>> Thanks Karl and Dave. Chris, does it work in your image(s)?
> > > >>>>
> > > >>>> Best,
> > > >>>> Marcel
> > > >>>>
> > > >>>> Am 14.04.2018 21:00:55 schrieb David T. Lewis <[hidden email]
> > >:
> > > >>>> On Thu, Apr 12, 2018 at 11:23:42PM -0700, marcel.taeumel wrote:
> > > >>>> > Anybody? Just file it in your work image and tell me what happens.
> > > >>>> >
> > > >>>>
> > > >>>> Sorry I overlook this. I filed the changes in earlier today. All is
> > > >>>> well with browsers and such, but when I open an Elipse from the
> > Objects
> > > >>>> tab, then rotate it with the halo handle, things go wrong. It looks
> > > >>>> like the 'closed' instance variable in the PolygonMorph is nil.
> > > >>>>
> > > >>>> I think you may have already addressed this from Karl's report.
> > > >>>>
> > > >>>> Dave
> > > >>>>
> > > >>>>
> > > >>>>
> > > >>>>
> > > >>>>
> > > >>>>
> > > >>>
> > > >>
> > > >>
> > > >>
> > > >>
> > > >
> >
> >
> >

>


12