Please add the platform code for Andreas' SqueakSSL to SVN for trunk and oscog

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Please add the platform code for Andreas' SqueakSSL to SVN for trunk and oscog

David T. Lewis
 
Ian, Eliot:

When you get a chance, could you please add the platform support code for
Andreas' SqueakSSL plugin to the Squeak trunk and oscog branches? Source
files attached. This is Andreas' work (not mine) but I have placed the files in
directories to match the platforms tree structure.

Background:

There has been some interest recently in getting Andreas' SqueakSSL plugin
incorporated into the standard VMs. For tracking purposes I opened an entry
at http://bugs.squeak.org/view.php?id=7751.

Andreas' Smalltalk code is at http://www.squeaksource.com/SqueakSSL, and I
have added this to the update map for trunk VMMaker. Ian, for the standard
interpreter, you should be able to do "VMMaker updateFromServer" followed
by "VMMakerTool forUnix" to have it added to your standard unix configuration.
Eliot, you can add the plugin from http://www.squeaksource.com/SqueakSSL to
your build recipe if you have not already done so.

The platform support code is at http://www.squeaksource.com/SqueakSSL. I made
a copy of that code, rearranging the directories to match the structure of our
SVN platforms tree, attached as SqueakSSL-platforms.tar.gz.

What needs to be done:

Ian: This is all new code that can simply be added to the repository without
side effects. I can confirm that the unix code compiles, but I have not functionally
tested it. There are compiler warnings when compiling -m64, and errors for
--image64, but I expect that a 32 bit compile is probably OK. There is platform
support code for unix, win32, and Mac OS. I think we can assume that win32 is in
good shape, and that unix is probably OK. I don't know about the Mac OS code
but we should check it in regardless, and follow up on any issues as needed.
Overall I do expect that some type declarations will need to be tidied up, but
we should start with Andreas' code unmodified and make any necessary patches
as updates to that base.

Eliot: I think that the attached platforms code is more recent and more complete
than what is currently in the oscog platforms tree. If so you can update your
platforms code with the attached, which I believe is Andreas' most up to date
work for SqueakSSLPlugin for unix, win32 and Mac OS.

Thanks,
Dave


SqueakSSL-platforms.tar.gz (15K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Please add the platform code for Andreas' SqueakSSL to SVN for trunk and oscog

Eliot Miranda-2
 


On Thu, Mar 21, 2013 at 7:12 PM, David T. Lewis <[hidden email]> wrote:
Ian, Eliot:

When you get a chance, could you please add the platform support code for
Andreas' SqueakSSL plugin to the Squeak trunk and oscog branches? Source
files attached. This is Andreas' work (not mine) but I have placed the files in
directories to match the platforms tree structure.

In progress, not checked in.  I've integrated but so far only tested on Mac OS.   Rather disappointing.  Three errors, 1 failing test, 2 successes, and 8 expected failures.  Anyone got any suggestions re the Mac support code or the tests?


Background:

There has been some interest recently in getting Andreas' SqueakSSL plugin
incorporated into the standard VMs. For tracking purposes I opened an entry
at http://bugs.squeak.org/view.php?id=7751.

Andreas' Smalltalk code is at http://www.squeaksource.com/SqueakSSL, and I
have added this to the update map for trunk VMMaker. Ian, for the standard
interpreter, you should be able to do "VMMaker updateFromServer" followed
by "VMMakerTool forUnix" to have it added to your standard unix configuration.
Eliot, you can add the plugin from http://www.squeaksource.com/SqueakSSL to
your build recipe if you have not already done so.

The platform support code is at http://www.squeaksource.com/SqueakSSL. I made
a copy of that code, rearranging the directories to match the structure of our
SVN platforms tree, attached as SqueakSSL-platforms.tar.gz.

What needs to be done:

Ian: This is all new code that can simply be added to the repository without
side effects. I can confirm that the unix code compiles, but I have not functionally
tested it. There are compiler warnings when compiling -m64, and errors for
--image64, but I expect that a 32 bit compile is probably OK. There is platform
support code for unix, win32, and Mac OS. I think we can assume that win32 is in
good shape, and that unix is probably OK. I don't know about the Mac OS code
but we should check it in regardless, and follow up on any issues as needed.
Overall I do expect that some type declarations will need to be tidied up, but
we should start with Andreas' code unmodified and make any necessary patches
as updates to that base.

Eliot: I think that the attached platforms code is more recent and more complete
than what is currently in the oscog platforms tree. If so you can update your
platforms code with the attached, which I believe is Andreas' most up to date
work for SqueakSSLPlugin for unix, win32 and Mac OS.

Thanks,
Dave




--
best,
Eliot
Reply | Threaded
Open this post in threaded view
|

Re: Please add the platform code for Andreas' SqueakSSL to SVN for trunk and oscog

David T. Lewis
 
On Tue, Mar 26, 2013 at 10:01:44AM -0700, Eliot Miranda wrote:

> On Thu, Mar 21, 2013 at 7:12 PM, David T. Lewis <[hidden email]> wrote:
>
> > Ian, Eliot:
> >
> > When you get a chance, could you please add the platform support code for
> > Andreas' SqueakSSL plugin to the Squeak trunk and oscog branches? Source
> > files attached. This is Andreas' work (not mine) but I have placed the
> > files in
> > directories to match the platforms tree structure.
> >
>
> In progress, not checked in.  I've integrated but so far only tested on Mac
> OS.   Rather disappointing.  Three errors, 1 failing test, 2 successes, and
> 8 expected failures.  Anyone got any suggestions re the Mac support code or
> the tests?
>

Esteban:

Can you please take a look at the Mac sources for the SqueakSSLPlugin and see
if they should be integrated into the Subversion repository for trunk and oscog?

Background and links to source are at http://bugs.squeak.org/view.php?id=7751

Eliot:

Ian incorporated the platforms sources for unix and win32 into trunk. I would
suggest that you do the same. We may need to deal with Mac at a later time.

I do expect that updates will be required, as the plugin did not compile for -m64
when I tried that. But these are easy things to fix, let's capture the current state
and move forward from there.

Dave


>
> > Background:
> >
> > There has been some interest recently in getting Andreas' SqueakSSL plugin
> > incorporated into the standard VMs. For tracking purposes I opened an entry
> > at http://bugs.squeak.org/view.php?id=7751.
> >
> > Andreas' Smalltalk code is at http://www.squeaksource.com/SqueakSSL, and I
> > have added this to the update map for trunk VMMaker. Ian, for the standard
> > interpreter, you should be able to do "VMMaker updateFromServer" followed
> > by "VMMakerTool forUnix" to have it added to your standard unix
> > configuration.
> > Eliot, you can add the plugin from http://www.squeaksource.com/SqueakSSLto
> > your build recipe if you have not already done so.
> >
> > The platform support code is at http://www.squeaksource.com/SqueakSSL. I
> > made
> > a copy of that code, rearranging the directories to match the structure of
> > our
> > SVN platforms tree, attached as SqueakSSL-platforms.tar.gz.
> >
> > What needs to be done:
> >
> > Ian: This is all new code that can simply be added to the repository
> > without
> > side effects. I can confirm that the unix code compiles, but I have not
> > functionally
> > tested it. There are compiler warnings when compiling -m64, and errors for
> > --image64, but I expect that a 32 bit compile is probably OK. There is
> > platform
> > support code for unix, win32, and Mac OS. I think we can assume that win32
> > is in
> > good shape, and that unix is probably OK. I don't know about the Mac OS
> > code
> > but we should check it in regardless, and follow up on any issues as
> > needed.
> > Overall I do expect that some type declarations will need to be tidied up,
> > but
> > we should start with Andreas' code unmodified and make any necessary
> > patches
> > as updates to that base.
> >
> > Eliot: I think that the attached platforms code is more recent and more
> > complete
> > than what is currently in the oscog platforms tree. If so you can update
> > your
> > platforms code with the attached, which I believe is Andreas' most up to
> > date
> > work for SqueakSSLPlugin for unix, win32 and Mac OS.
> >
> > Thanks,
> > Dave
> >
> >
>
>
> --
> best,
> Eliot