Please revert MetacelloBrowser-OB-UI-AlexandreBergel.44

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Please revert MetacelloBrowser-OB-UI-AlexandreBergel.44

Tobias Pape-3
Hi all

although I am happy that my ideas were heard,
I'd like to ask for reverting
MetacelloBrowser-OB-UI-AlexandreBergel.44.

The point is that the registerInWorldMenu is
platform-specific to squeak and best located in the
MetacelloConfiguration as Post-Load Doit.
(see alternative in
http://code.google.com/p/metacello/issues/detail?id=132
)

As Alex states in that report
"I do not know who postLoadScript works, and I am not sure this is necessary."
I propose the following:

* revert: MetacelloBrowser-OB-UI-AlexandreBergel.44
* add:
ConfigurationOfMetacelloBrowser>>#squeakRegisterInWorldMenu
in 'doits'

squeakRegisterInWorldMenu

        Smalltalk globals at: #TheWorldMenu ifPresent: [ :class |
                class registerOpenCommand:
                        {'Metacello Browser' . {MBOBConfigurationBrowser .  #open} .
                        'The Metacello Browser allows loading and management of Metacello configurations'} ].

* I think this is best fitted in the stable version, hence:
* modify:
ConfigurationOfMetacelloBrowser>>#baseline159:
baseline159: spec
        <version: '1.59-baseline'>

"…"
        spec for: #'squeak' do: [
                spec project: 'Announcements' with: [
                                spec
                                        className: 'ConfigurationOfAnnouncements';
                                        versionString: '1.0';
                                        repository: 'http://www.squeaksource.com/MetacelloRepository' ].
                spec
                        package: 'MetacelloBrowser-Core' with: [
                                spec requires: 'Announcements' ].
+ speck
+ package: 'MetacelloBrowser-OB-UI' with: [
+ spec postLoadDoIt: #squeakRegisterInWorldMenu ].
                spec
                        group: 'Core' with: #('OB'). ].
"…"

* and probably release a 1.59.2

Best
        -Tobias


Reply | Threaded
Open this post in threaded view
|

Re: Please revert MetacelloBrowser-OB-UI-AlexandreBergel.44

abergel
> although I am happy that my ideas were heard,

:-)

> I'd like to ask for reverting
> MetacelloBrowser-OB-UI-AlexandreBergel.44.

I updated the issue 132 with what comes below.
And waiting to sync with Dale to see how we proceed.

Cheers,
Alexandre


> The point is that the registerInWorldMenu is
> platform-specific to squeak and best located in the
> MetacelloConfiguration as Post-Load Doit.
> (see alternative in
> http://code.google.com/p/metacello/issues/detail?id=132
> )
>
> As Alex states in that report
> "I do not know who postLoadScript works, and I am not sure this is necessary."
> I propose the following:
>
> * revert: MetacelloBrowser-OB-UI-AlexandreBergel.44
> * add:
> ConfigurationOfMetacelloBrowser>>#squeakRegisterInWorldMenu
> in 'doits'
>
> squeakRegisterInWorldMenu
>
> Smalltalk globals at: #TheWorldMenu ifPresent: [ :class |
> class registerOpenCommand:
> {'Metacello Browser' . {MBOBConfigurationBrowser .  #open} .
> 'The Metacello Browser allows loading and management of Metacello configurations'} ].
>
> * I think this is best fitted in the stable version, hence:
> * modify:
> ConfigurationOfMetacelloBrowser>>#baseline159:
> baseline159: spec
> <version: '1.59-baseline'>
>
> "…"
> spec for: #'squeak' do: [
> spec project: 'Announcements' with: [
> spec
> className: 'ConfigurationOfAnnouncements';
> versionString: '1.0';
> repository: 'http://www.squeaksource.com/MetacelloRepository' ].
> spec
> package: 'MetacelloBrowser-Core' with: [
> spec requires: 'Announcements' ].
> + speck
> + package: 'MetacelloBrowser-OB-UI' with: [
> + spec postLoadDoIt: #squeakRegisterInWorldMenu ].
> spec
> group: 'Core' with: #('OB'). ].
> "…"
>
> * and probably release a 1.59.2
>
> Best
> -Tobias
>
>

--
_,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:
Alexandre Bergel  http://www.bergel.eu
^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.