Smalltalk › Squeak › Squeak - Dev

Proposal | Resetting pragma preferences via 'nil' or #reset... message

‹ Previous Topic Next Topic ›
 
classic Classic list List threaded Threaded
♦
♦
 5 messages Options
marcel.taeumel
Reply | Threaded
Open this post in threaded view
♦
♦
|

Proposal | Resetting pragma preferences via 'nil' or #reset... message

marcel.taeumel
Hi all!

Please find attached a change set that will implement #restoreDefaultValue on PragmaPreference looking for an optional #reset... message or just setting the preference to 'nil' and hoping for the best.

I added #reset... methods for all pragma preferences that do either (a) not support 'nil' or (b) do costly update stuff.

In the ReleaseBuilder, I opted for resetting all preferences as early as possible.

Can I put this in the Trunk? :-)

Best,
Marcel



pragma-cleanup.1.cs (24K) Download Attachment
Eliot Miranda-2
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: Proposal | Resetting pragma preferences via 'nil' or #reset... message

Eliot Miranda-2


On Wed, Oct 14, 2020 at 8:03 AM Marcel Taeumel <[hidden email]> wrote:
Hi all!

Please find attached a change set that will implement #restoreDefaultValue on PragmaPreference looking for an optional #reset... message or just setting the preference to 'nil' and hoping for the best.

I added #reset... methods for all pragma preferences that do either (a) not support 'nil' or (b) do costly update stuff.

In the ReleaseBuilder, I opted for resetting all preferences as early as possible.

Can I put this in the Trunk? :-)

Yes, but only if you remove all those stylings ;-)  I don't want y changes file filling up with junk that will be auto-styled over :-)

_,,,^..^,,,_
best, Eliot
marcel.taeumel
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: Proposal | Resetting pragma preferences via 'nil' or #reset... message

marcel.taeumel
Hmm... not sure how that happened. Maybe because I did that from a Vivide image. Well, no worries. I will use a fresh Trunk image as catalyst. :-)

Best,
Marcel

Am 14.10.2020 20:32:49 schrieb Eliot Miranda <[hidden email]>:



On Wed, Oct 14, 2020 at 8:03 AM Marcel Taeumel <[hidden email]> wrote:
Hi all!

Please find attached a change set that will implement #restoreDefaultValue on PragmaPreference looking for an optional #reset... message or just setting the preference to 'nil' and hoping for the best.

I added #reset... methods for all pragma preferences that do either (a) not support 'nil' or (b) do costly update stuff.

In the ReleaseBuilder, I opted for resetting all preferences as early as possible.

Can I put this in the Trunk? :-)

Yes, but only if you remove all those stylings ;-)  I don't want y changes file filling up with junk that will be auto-styled over :-)

_,,,^..^,,,_
best, Eliot
marcel.taeumel
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: Proposal | Resetting pragma preferences via 'nil' or #reset... message

marcel.taeumel
New day, new thoughts on this matter. I don't think that having extra #reset... messages for pragma preferences is necessary. The getter as "ifNil" and so should the setter support a 'nil' argument to reset. I will update those remaining 20% of setters to support 'nil' as argument.

Best,
Marcel

Am 15.10.2020 12:59:57 schrieb Marcel Taeumel <[hidden email]>:

Hmm... not sure how that happened. Maybe because I did that from a Vivide image. Well, no worries. I will use a fresh Trunk image as catalyst. :-)

Best,
Marcel

Am 14.10.2020 20:32:49 schrieb Eliot Miranda <[hidden email]>:



On Wed, Oct 14, 2020 at 8:03 AM Marcel Taeumel <[hidden email]> wrote:
Hi all!

Please find attached a change set that will implement #restoreDefaultValue on PragmaPreference looking for an optional #reset... message or just setting the preference to 'nil' and hoping for the best.

I added #reset... methods for all pragma preferences that do either (a) not support 'nil' or (b) do costly update stuff.

In the ReleaseBuilder, I opted for resetting all preferences as early as possible.

Can I put this in the Trunk? :-)

Yes, but only if you remove all those stylings ;-)  I don't want y changes file filling up with junk that will be auto-styled over :-)

_,,,^..^,,,_
best, Eliot
Eliot Miranda-2
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: Proposal | Resetting pragma preferences via 'nil' or #reset... message

Eliot Miranda-2


On Oct 15, 2020, at 4:27 AM, Marcel Taeumel <[hidden email]> wrote:


New day, new thoughts on this matter. I don't think that having extra #reset... messages for pragma preferences is necessary. The getter as "ifNil" and so should the setter support a 'nil' argument to reset. I will update those remaining 20% of setters to support 'nil' as argument.

+1; very nice.


Best,
Marcel

Am 15.10.2020 12:59:57 schrieb Marcel Taeumel <[hidden email]>:

Hmm... not sure how that happened. Maybe because I did that from a Vivide image. Well, no worries. I will use a fresh Trunk image as catalyst. :-)

Best,
Marcel

Am 14.10.2020 20:32:49 schrieb Eliot Miranda <[hidden email]>:



On Wed, Oct 14, 2020 at 8:03 AM Marcel Taeumel <[hidden email]> wrote:
Hi all!

Please find attached a change set that will implement #restoreDefaultValue on PragmaPreference looking for an optional #reset... message or just setting the preference to 'nil' and hoping for the best.

I added #reset... methods for all pragma preferences that do either (a) not support 'nil' or (b) do costly update stuff.

In the ReleaseBuilder, I opted for resetting all preferences as early as possible.

Can I put this in the Trunk? :-)

Yes, but only if you remove all those stylings ;-)  I don't want y changes file filling up with junk that will be auto-styled over :-)

_,,,^..^,,,_
best, Eliot
Free forum by Nabble Edit this page