Re: Inbox --> Treated? (was The Trunk: KernelTests-tonyg.318.mcz)

> On 2/20/17, Tobias Pape <[hidden email]> wrote:
>>
>> On 20.02.2017, at 23:00, Bert Freudenberg <[hidden email]> wrote:
>>
>>> How about some automatic server-side cleanup? If a package gets saved or
>>> merged into trunk, move it to treated-inbox.
>>>
>>> Then all you have to do in image is to copy/merge the version from inbox
>>> to trunk.
>>>
>>
>> Na, lets leave it that way for now :)
>> Its a-ok
>
> How are treated fixes moved from inbox to treated currently?

>
> For example this one
>
>    'The Inbox: Morphic-mdlh.1297.mcz'
>
> has been treated but is still in  the inbox
>
>      http://source.squeak.org/inbox/
>
>
> instead of
>
>
>      http://source.squeak.org/treated/
>
> This applies to quite a number of more fixes in the inbox.
>
>
> --Hannes
>
>
>>> - Bert -
>>>
>>> On Mon, Feb 20, 2017 at 10:54 PM, Tobias Pape <[hidden email]> wrote:
>>>
>>> On 20.02.2017, at 22:44, Levente Uzonyi <[hidden email]> wrote:
>>>
>>>> Inbox submissions are still rare enough to not justify creating an API
>>>> for squeaksource. :)
>>>
>>> But I Must Not leave my Squeak image :D
>>>
>>>>
>>>> Levente
>>>>
>>>> On Sat, 18 Feb 2017, Tobias Pape wrote:
>>>>
>>>>> So, I think we need a way to move from inbox to trunk/treated from the
>>>>> image.
>>>>> Website-only is cumbersome…
>>>>>
>>>>> Best regards
>>>>>     -Tobias
>>>>> On 18.02.2017, at 08:44, [hidden email] wrote:
>>>>>
>>>>>> Tobias Pape uploaded a new version of KernelTests to project The
>>>>>> Trunk:
>>>>>> http://source.squeak.org/trunk/KernelTests-tonyg.318.mcz
>>>>>> ==================== Summary ====================
>>>>>> Name: KernelTests-tonyg.318
>>>>>> Author: tonyg
>>>>>> Time: 17 February 2017, 2:10:54.13995 pm
>>>>>> UUID: 550fed38-fe11-4cea-bccb-2e3c13b421d0
>>>>>> Ancestors: KernelTests-nice.317
>>>>>> Add tests for Promise>>wait (including proposed change from
>>>>>> Kernel-tonyg.1059)
>>>>>> =============== Diff against KernelTests-nice.317 ===============
>>>>>> Item was added:
>>>>>> + ----- Method: PromiseTest>>testWaitForRejection (in category
>>>>>> 'testing - monad') -----
>>>>>> + testWaitForRejection
>>>>>> +   | p |
>>>>>> +   p := Promise new.
>>>>>> +   [ (Delay forMilliseconds: 1) wait. p rejectWith: Error new ] fork.
>>>>>> +   self should: [ p wait ] raise: BrokenPromise.!
>>>>>> Item was added:
>>>>>> + ----- Method: PromiseTest>>testWaitForResolution (in category
>>>>>> 'testing - monad') -----
>>>>>> + testWaitForResolution
>>>>>> +   | p |
>>>>>> +   p := Promise new.
>>>>>> +   [ (Delay forMilliseconds: 1) wait. p resolveWith: #ok ] fork.
>>>>>> +   self assert: [ p wait = #ok ]!
>>>>>> Item was added:
>>>>>> + ----- Method:
>>>>>> PromiseTest>>testWaitRejectionYieldsCorrectBrokenPromise (in category
>>>>>> 'testing - monad') -----
>>>>>> + testWaitRejectionYieldsCorrectBrokenPromise
>>>>>> +   | p |
>>>>>> +   p := Promise new.
>>>>>> +   [ (Delay forMilliseconds: 1) wait. p rejectWith: Error new ] fork.
>>>>>> +   [ p wait ] on: BrokenPromise do: [ :bp | ^ self assert: [ bp
>>>>>> promise == p ] ].
>>>>>> +   self fail: 'Should not reach this point'!
>>>>
>>>
>>>
>>>
>>>
>>
>>
>>
>

> The other button, "Move to The Trunk" would have taken care of that.
> Perhaps it has adequate error-handling such that it still will.
>
> Otherwise, you can simply remove them from the Inbox using the "Delete
> Version" on the sidebar of the web interface.
>
> On Thu, Feb 23, 2017 at 10:22 AM, H. Hirzel <[hidden email]> wrote:
>> OK, through a web interface, I see.
>>
>> What about
>>
>> Environments-jr.69.mcz
>> Environments-jr.68.mcz
>>
>> which have been moved to trunk and are still in the inbox?
>>
>> --Hannes
>>
>> On 2/23/17, Tobias Pape <[hidden email]> wrote:
>>>
>>> On 23.02.2017, at 15:55, H. Hirzel <[hidden email]> wrote:
>>>
>>>> On 2/20/17, Tobias Pape <[hidden email]> wrote:
>>>>>
>>>>> On 20.02.2017, at 23:00, Bert Freudenberg <[hidden email]> wrote:
>>>>>
>>>>>> How about some automatic server-side cleanup? If a package gets saved
>>>>>> or
>>>>>> merged into trunk, move it to treated-inbox.
>>>>>>
>>>>>> Then all you have to do in image is to copy/merge the version from
>>>>>> inbox
>>>>>> to trunk.
>>>>>>
>>>>>
>>>>> Na, lets leave it that way for now :)
>>>>> Its a-ok
>>>>
>>>> How are treated fixes moved from inbox to treated currently?
>>>
>>> This way:
>>>
>>>
>>
>
>