Re: [OpenSmalltalk/opensmalltalk-vm] Add WindowEventMetricChange support for macOS (iOS). Fix a nasty typo in iOS (0361fc3)

What is being switched here?

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

A frivolous name WindowEventWindowStinks for a useful one WindowEventScreenChange

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

I love that sentence,but the swithc is missing a case, it only has a default, does it?

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

I noticed the missing case, too. An experiment in VS 2019 shows that part after switch() is skipped (in C++). Does OjbC handle it differently?

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

I think you're being misled by git diffs. here's the actual switch in the source

        NSRect frame = [window frame];
        NSRect screen = [[window screen] frame];
        evt.value1 = frame.origin.x;
        evt.value2 = screen.size.height - (frame.size.height + frame.origin.y);
        evt.value3 = frame.size.width;
        evt.value4 = frame.size.height;
        break;
    default:
        evt.value1 = 0;
        evt.value2 = 0;
        evt.value3 = 0;
        evt.value4 = 0;
    }```

That's quite regular, right?  It's wrong, because the image wants left/top/right/bottom, not left/top/width/height, but... :-)

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

The case ... : is missing.

I would have expected:

    switch (windowType) {
    case SOMETHING:
        NSRect frame = [window frame];
        NSRect screen = [[window screen] frame];
        evt.value1 = frame.origin.x;
        evt.value2 = screen.size.height - (frame.size.height + frame.origin.y);
        evt.value3 = frame.size.width;
        evt.value4 = frame.size.height;
        break;
    default:
        evt.value1 = 0;
        evt.value2 = 0;
        evt.value3 = 0;
        evt.value4 = 0;
    }

but there is no case me puzzled

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

Clearly, some case of windowType is expected.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

Doh! Thanks both.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.