Re: [OpenSmalltalk/opensmalltalk-vm] CogVM source as per VMMaker.oscog-eem.2484 (897ef17)

 

Since we getButtonState() including both buttons and modifiers, I wonder why not just fill both buttons and modifiersfields rather than filling the buttons field with the modifiers???

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/897ef1725e32c2eb3d24e3402b2e95b114b8b28b?email_source=notifications\u0026email_token=AIJPEW6BP222BCPUZIBLYCTQ2PUGLA5CNFSM4J7G4EYKYY3PNVWWK3TUL52HS4DFVVBW63LNNF2EG33NNVSW45FKMNXW23LFNZ2F62LEZYBC4GW3#commitcomment-36575963", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/897ef1725e32c2eb3d24e3402b2e95b114b8b28b?email_source=notifications\u0026email_token=AIJPEW6BP222BCPUZIBLYCTQ2PUGLA5CNFSM4J7G4EYKYY3PNVWWK3TUL52HS4DFVVBW63LNNF2EG33NNVSW45FKMNXW23LFNZ2F62LEZYBC4GW3#commitcomment-36575963", "name": "View Commit" }, "description": "View this Commit on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 

Same as for unix: why fill buttons field with modifiers state, instead of filling both buttons and modifiers fields?
We have both states in buttonAndModifiers no?

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/897ef1725e32c2eb3d24e3402b2e95b114b8b28b?email_source=notifications\u0026email_token=AIJPEW4LBWA74J5TPPFELP3Q2PUT7A5CNFSM4J7G4EYKYY3PNVWWK3TUL52HS4DFVVBW63LNNF2EG33NNVSW45FKMNXW23LFNZ2F62LEZYBC4GXP#commitcomment-36575983", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/897ef1725e32c2eb3d24e3402b2e95b114b8b28b?email_source=notifications\u0026email_token=AIJPEW4LBWA74J5TPPFELP3Q2PUT7A5CNFSM4J7G4EYKYY3PNVWWK3TUL52HS4DFVVBW63LNNF2EG33NNVSW45FKMNXW23LFNZ2F62LEZYBC4GXP#commitcomment-36575983", "name": "View Commit" }, "description": "View this Commit on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 
Ancient history dating back to (probably ) 1996. Surely we can do better this much later...

> On 2019-12-25, at 3:33 PM, Nicolas Cellier <[hidden email]> wrote:
>
> Same as for unix: why fill buttons field with modifiers state, instead of filling both buttons and modifiers fields?
> We have both states in buttonAndModifiers no?
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub, or unsubscribe.
>


tim
--
tim Rowledge; [hidden email]; http://www.rowledge.org/tim
Cap'n!  The spellchecker kinna take this abuse!

 

The other question is where the factor 32 comes from...

My understanding is that coordinates are expressed in typesetting points or pica (1/72.27 inches, rounded to 1/72 by Apple and some other software providers) - if current scale factor is = 1.
https://developer.apple.com/library/archive/documentation/Cocoa/Conceptual/CocoaDrawingGuide/Transforms/Transforms.html
A usual font height is 12 points (1/6 inch), count about 2 points for interline, that makes about 14 points line grid.
Note that a point = a pixel in last century monitors having 72 pixels (dots) per inch, and also in Squeak...

My understanding is that deltaX and deltaY are in same coordinates units
https://developer.apple.com/documentation/appkit/nsevent/1534158-deltay

We want to convert that to scrolling units.

In Squeak, we convert 120 scrolling units into 3 scrollDelta.
A scrollDelta typically is = lineHeight in text pane and font height in list pane.
So we want 120 scrollUnits = 3 scrollDelta = 36 to 40 points typically.
That makes roughly a factor * 3.

Though, with * 32, OSX trackpad scrolls feel sluggish, it would be far worse with * 3!
It's clear that I missed something...

Unless we should better use scrollingDeltaY for scroll wheel events as recommended in the link above...
https://developer.apple.com/documentation/appkit/nsevent/1535387-scrollingdeltay

In which case we should inquire hasPreciseScrollingDeltas

I'm not completely satisifed with Apple docs, so scanning github for crowd wisdom
I found example of * 32 in other code bases when not precise:
xi-editor/druid@2cf48ec

This is for OSX > 10.7 which can be tested like this:
OpenTTD/OpenTTD#7109

I will try some experiments...

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/897ef1725e32c2eb3d24e3402b2e95b114b8b28b?email_source=notifications\u0026email_token=AIJPEW3YXKEGGSK2ECQN2B3Q2XSHFA5CNFSM4J7G4EYKYY3PNVWWK3TUL52HS4DFVVBW63LNNF2EG33NNVSW45FKMNXW23LFNZ2F62LEZYBC4U62#commitcomment-36590554", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/897ef1725e32c2eb3d24e3402b2e95b114b8b28b?email_source=notifications\u0026email_token=AIJPEW3YXKEGGSK2ECQN2B3Q2XSHFA5CNFSM4J7G4EYKYY3PNVWWK3TUL52HS4DFVVBW63LNNF2EG33NNVSW45FKMNXW23LFNZ2F62LEZYBC4U62#commitcomment-36590554", "name": "View Commit" }, "description": "View this Commit on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>