Re: [OpenSmalltalk/opensmalltalk-vm] Directly use the symbolic (=virtual) key code, that's what we want. (0dbcb71)

 

While at it, why not rename charCode to keycode to avoid confusion in the future? It is an auto variable so it won't affect rest of the code.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/0dbcb71e9c53cb5c60023fa018d03e178117864f?email_source=notifications\u0026email_token=AIJPEW3RFY4HU7W4BYSERELQ2IFA7A5CNFSM4J66L6AKYY3PNVWWK3TUL52HS4DFVVBW63LNNF2EG33NNVSW45FKMNXW23LFNZ2F62LEZYBC32BG#commitcomment-36562982", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/0dbcb71e9c53cb5c60023fa018d03e178117864f?email_source=notifications\u0026email_token=AIJPEW3RFY4HU7W4BYSERELQ2IFA7A5CNFSM4J66L6AKYY3PNVWWK3TUL52HS4DFVVBW63LNNF2EG33NNVSW45FKMNXW23LFNZ2F62LEZYBC32BG#commitcomment-36562982", "name": "View Commit" }, "description": "View this Commit on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 

Agree, as I wrote in previous commit comment, I want to do that to the struct too:
134b8f7
I want to change all the occurrences at once, because when doing these deep changes, it's convenient to have less keyword to search for.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/0dbcb71e9c53cb5c60023fa018d03e178117864f?email_source=notifications\u0026email_token=AIJPEWYAU2BVTA3NWAUFCMLQ2IKKPA5CNFSM4J66L6AKYY3PNVWWK3TUL52HS4DFVVBW63LNNF2EG33NNVSW45FKMNXW23LFNZ2F62LEZYBC32PD#commitcomment-36563427", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/0dbcb71e9c53cb5c60023fa018d03e178117864f?email_source=notifications\u0026email_token=AIJPEWYAU2BVTA3NWAUFCMLQ2IKKPA5CNFSM4J66L6AKYY3PNVWWK3TUL52HS4DFVVBW63LNNF2EG33NNVSW45FKMNXW23LFNZ2F62LEZYBC32PD#commitcomment-36563427", "name": "View Commit" }, "description": "View this Commit on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>