Re: [OpenSmalltalk/opensmalltalk-vm] FileAttributesPlugin: Add session Id (f6445ab)

 

Hi Alistair,

can you regenerate src/plugins/FileAttributesPlugin/FileAttributesPlugin.c?  It is marked as generated from a dirty package, and that;'s a definite no no:

VMPluginCodeGenerator * VMMaker.oscog-cb.2486 uuid: 38ce095a-ec39-4d1d-b8c7-096335f5b687
FileAttributesPlugin * FileAttributesPlugin.oscog-akg.45 uuid: b0e1cf62-47e3-4a3b-b95c-b639d96c615f

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@eliotmiranda on f6445ab: Hi Alistair,\r\n\r\n can you regenerate src/plugins/FileAttributesPlugin/FileAttributesPlugin.c? It is marked as generated from a dirty package, and that;'s a definite no no:\r\n\r\n \tVMPluginCodeGenerator * VMMaker.oscog-cb.2486 uuid: 38ce095a-ec39-4d1d-b8c7-096335f5b687\r\n\tFileAttributesPlugin * FileAttributesPlugin.oscog-akg.45 uuid: b0e1cf62-47e3-4a3b-b95c-b639d96c615f"}],"action":{"name":"View Commit","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/f6445ab9ea75f685e4e53bff8917449646c3754b#commitcomment-31695668"}}}</script> <script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/f6445ab9ea75f685e4e53bff8917449646c3754b#commitcomment-31695668", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/f6445ab9ea75f685e4e53bff8917449646c3754b#commitcomment-31695668", "name": "View Commit" }, "description": "View this Commit on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 

Hi Eliot,

This is an internal commit of the plugin I did during development, the latest version from the merge is:

94c54ed#diff-04cbc775a3686446b844a93e1520e706

The repository is configured to not allow squash merges, so all the commits that are part of a PR will always be present.

In the latest commit the FileAttributesPlugin package is clean, but the VMMaker package is still dirty - it contains the fixes that became part of VMMaker.oscog-akg.2487. I'll load up the latest version of VMMaker and regenerate the plugin.

P.S. I'm still planning on responding to your earlier email re using alloca(). I was out all yesterday, so have a (small) queue of messages to reply to.

Cheers,
Alistair

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@akgrant43 on f6445ab: Hi Eliot,\r\n\r\nThis is an internal commit of the plugin I did during development, the latest version from the merge is:\r\n\r\nhttps://github.com/OpenSmalltalk/opensmalltalk-vm/commit/94c54edc5bbb8dfac318686176e67ceaa20883bb#diff-04cbc775a3686446b844a93e1520e706\r\n\r\nThe repository is configured to not allow squash merges, so all the commits that are part of a PR will always be present.\r\n\r\nIn the latest commit the FileAttributesPlugin package is clean, but the VMMaker package is still dirty - it contains the fixes that became part of VMMaker.oscog-akg.2487. I'll load up the latest version of VMMaker and regenerate the plugin.\r\n\r\nP.S. I'm still planning on responding to your earlier email re using alloca(). I was out all yesterday, so have a (small) queue of messages to reply to.\r\n\r\nCheers,\r\nAlistair"}],"action":{"name":"View Commit","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/f6445ab9ea75f685e4e53bff8917449646c3754b#commitcomment-31697373"}}}</script> <script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/f6445ab9ea75f685e4e53bff8917449646c3754b#commitcomment-31697373", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/f6445ab9ea75f685e4e53bff8917449646c3754b#commitcomment-31697373", "name": "View Commit" }, "description": "View this Commit on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 

Hi Alistair,

I have a clean VMMaker so I can do the generation.  I just want to be sure that I should generate from  FileAttributesPlugin.oscog-akg.46.  Is that right? I should have made this offer earlier.  Sorry.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@eliotmiranda on f6445ab: Hi Alistair,\r\n\r\n I have a clean VMMaker so I can do the generation. I just want to be sure that I should generate from FileAttributesPlugin.oscog-akg.46. Is that right? I should have made this offer earlier. Sorry."}],"action":{"name":"View Commit","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/f6445ab9ea75f685e4e53bff8917449646c3754b#commitcomment-31697491"}}}</script> <script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/f6445ab9ea75f685e4e53bff8917449646c3754b#commitcomment-31697491", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/f6445ab9ea75f685e4e53bff8917449646c3754b#commitcomment-31697491", "name": "View Commit" }, "description": "View this Commit on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 

No problem, it's already done. :-)

(The merge page showed the only change was the comment about the VMMaker version, so I merged it in straight away).

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@akgrant43 on f6445ab: No problem, it's already done. :-)\r\n\r\n(The merge page showed the only change was the comment about the VMMaker version, so I merged it in straight away)."}],"action":{"name":"View Commit","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/f6445ab9ea75f685e4e53bff8917449646c3754b#commitcomment-31697503"}}}</script> <script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/f6445ab9ea75f685e4e53bff8917449646c3754b#commitcomment-31697503", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/f6445ab9ea75f685e4e53bff8917449646c3754b#commitcomment-31697503", "name": "View Commit" }, "description": "View this Commit on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 
On Mon, 17 Dec 2018 at 15:10, akgrant43 <[hidden email]> wrote:

> Hi Eliot,
>
> This is an internal commit of the plugin I did during development, the
> latest version from the merge is:
>
> 94c54ed#diff-04cbc775a3686446b844a93e1520e706
> <https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/94c54edc5bbb8dfac318686176e67ceaa20883bb#diff-04cbc775a3686446b844a93e1520e706>
>
> The repository is configured to not allow squash merges, so all the
> commits that are part of a PR will always be present.
>
To provide cleaner PRs, I tend to "git commit --amend" to my-branch that I
issued a PR from and force push that to my github account.
In spite of the general advice not to force push public branches, in
reality it seems people rarely branch except from the canonical account.
Actually this could be covered by a convention like...
"if you branch from someone's personal account, immediately push it to
your account so it shows up in the network view."
Forcing pushing only a problem if someone has branched from it the network
view could be checked before forcing pushing.

cheers -ben

>

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@bencoman on f6445ab: On Mon, 17 Dec 2018 at 15:10, akgrant43 \u003cnotifications@github.com\u003e wrote:\n\n\u003e Hi Eliot,\n\u003e\n\u003e This is an internal commit of the plugin I did during development, the\n\u003e latest version from the merge is:\n\u003e\n\u003e 94c54ed#diff-04cbc775a3686446b844a93e1520e706\n\u003e \u003chttps://github.com/OpenSmalltalk/opensmalltalk-vm/commit/94c54edc5bbb8dfac318686176e67ceaa20883bb#diff-04cbc775a3686446b844a93e1520e706\u003e\n\u003e\n\u003e The repository is configured to not allow squash merges, so all the\n\u003e commits that are part of a PR will always be present.\n\u003e\nTo provide cleaner PRs, I tend to \"git commit --amend\" to my-branch that I\nissued a PR from and force push that to my github account.\nIn spite of the general advice not to force push public branches, in\nreality it seems people rarely branch except from the canonical account.\nActually this could be covered by a convention like...\n \"if you branch from someone's personal account, immediately push it to\nyour account so it shows up in the network view.\"\nForcing pushing only a problem if someone has branched from it the network\nview could be checked before forcing pushing.\n\ncheers -ben\n\n\u003e\n"}],"action":{"name":"View Commit","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/f6445ab9ea75f685e4e53bff8917449646c3754b#commitcomment-31702943"}}}</script> <script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/f6445ab9ea75f685e4e53bff8917449646c3754b#commitcomment-31702943", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/f6445ab9ea75f685e4e53bff8917449646c3754b#commitcomment-31702943", "name": "View Commit" }, "description": "View this Commit on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>