Re: [OpenSmalltalk/opensmalltalk-vm] Handle epoll event delivery errors without VM segfault. (b6616b2)

 

AIO_R should be AIO_W here.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/b6616b21d263ecaa334d458bf3a9579fcb88c635#commitcomment-46864203", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/b6616b21d263ecaa334d458bf3a9579fcb88c635#commitcomment-46864203", "name": "View Commit" }, "description": "View this Commit on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 

And AIO_X here.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/b6616b21d263ecaa334d458bf3a9579fcb88c635#commitcomment-46864211", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/b6616b21d263ecaa334d458bf3a9579fcb88c635#commitcomment-46864211", "name": "View Commit" }, "description": "View this Commit on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 

Oops sorry about that. Just pushed the fix. Thank you for reviewing.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/b6616b21d263ecaa334d458bf3a9579fcb88c635#commitcomment-46865614", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/b6616b21d263ecaa334d458bf3a9579fcb88c635#commitcomment-46865614", "name": "View Commit" }, "description": "View this Commit on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 

Also note that if(a=b) will generate a warning on modern compiler because often a miss write of a==b.
The modern convention is to write if( (a=b) ) to express the intention to assign and shut up the warning.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/b6616b21d263ecaa334d458bf3a9579fcb88c635#commitcomment-46886891", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/b6616b21d263ecaa334d458bf3a9579fcb88c635#commitcomment-46886891", "name": "View Commit" }, "description": "View this Commit on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 

Fixed in the next update, thanks

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/b6616b21d263ecaa334d458bf3a9579fcb88c635#commitcomment-46887098", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/b6616b21d263ecaa334d458bf3a9579fcb88c635#commitcomment-46887098", "name": "View Commit" }, "description": "View this Commit on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>