Re: [OpenSmalltalk/opensmalltalk-vm] I am cleaning the Win32 security plugin unicode mess. (2a6304d)

 

Note: squeakIniName was TCHAR everywhere else, so it cannot be a WCHAR here only...
Unless we manage to compile all with -DUNICODE, which was hardly possible at that time
(fortunately, we're getting closer)

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@nicolas-cellier-aka-nice on 2a6304d: Note: squeakIniName was TCHAR everywhere else, so it cannot be a WCHAR here only...\r\nUnless we manage to compile all with -DUNICODE, which was hardly possible at that time\r\n(fortunately, we're getting closer)"}],"action":{"name":"View Commit","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/2a6304d3586af4d7ada93d74be9ab4bcccbacdec#commitcomment-31824380"}}}</script> <script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/2a6304d3586af4d7ada93d74be9ab4bcccbacdec#commitcomment-31824380", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/2a6304d3586af4d7ada93d74be9ab4bcccbacdec#commitcomment-31824380", "name": "View Commit" }, "description": "View this Commit on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 

Unfortunately, this ain't gonna work, because dwSize is the size of the buffer in bytes, not the size in character (WCHAR)

This is because RegQueryValueEx is very low level and can read several types, thus handle the buffer as un-interpreted bytes.
Therefore, dwSize must be multiplied by sizeof(WCHAR) before the call, and divided by sizeof(WCHAR) after the call if we use the RegExQueryValueW variant, so as to express the size in characters like we intend to.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@nicolas-cellier-aka-nice on 2a6304d: Unfortunately, this ain't gonna work, because dwSize is the size of the buffer in bytes, not the size in character (WCHAR)\r\n\r\nThis is because RegQueryValueEx is very low level and can read several types, thus handle the buffer as un-interpreted bytes.\r\nTherefore, dwSize must be multiplied by sizeof(WCHAR) before the call, and divided by sizeof(WCHAR) after the call if we use the RegExQueryValueW variant, so as to express the size in characters like we intend to."}],"action":{"name":"View Commit","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/2a6304d3586af4d7ada93d74be9ab4bcccbacdec#commitcomment-31827279"}}}</script> <script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/2a6304d3586af4d7ada93d74be9ab4bcccbacdec#commitcomment-31827279", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/2a6304d3586af4d7ada93d74be9ab4bcccbacdec#commitcomment-31827279", "name": "View Commit" }, "description": "View this Commit on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 

What a “nice” find…

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@krono on 2a6304d: What a “nice” find…"}],"action":{"name":"View Commit","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/2a6304d3586af4d7ada93d74be9ab4bcccbacdec#commitcomment-31828283"}}}</script> <script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/2a6304d3586af4d7ada93d74be9ab4bcccbacdec#commitcomment-31828283", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/2a6304d3586af4d7ada93d74be9ab4bcccbacdec#commitcomment-31828283", "name": "View Commit" }, "description": "View this Commit on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 

I don't know the implications of this change...
Is f->isStdioStream information relevant?
What was the difference between ReadFile and ReadConsole?
Could someone else verify?

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@nicolas-cellier-aka-nice on 2a6304d: I don't know the implications of this change...\r\nIs f-\u003eisStdioStream information relevant?\r\nWhat was the difference between ReadFile and ReadConsole?\r\nCould someone else verify?"}],"action":{"name":"View Commit","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/2a6304d3586af4d7ada93d74be9ab4bcccbacdec#commitcomment-31828968"}}}</script> <script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/2a6304d3586af4d7ada93d74be9ab4bcccbacdec#commitcomment-31828968", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/2a6304d3586af4d7ada93d74be9ab4bcccbacdec#commitcomment-31828968", "name": "View Commit" }, "description": "View this Commit on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 

Ah, but I guess that Ronie did use -DUNICODE in his minheadless builds, which is perfectly OK.
But if we merge, we have to be cautious!

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@nicolas-cellier-aka-nice on 2a6304d: Ah, but I guess that Ronie did use -DUNICODE in his minheadless builds, which is perfectly OK.\r\nBut if we merge, we have to be cautious!"}],"action":{"name":"View Commit","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/2a6304d3586af4d7ada93d74be9ab4bcccbacdec#commitcomment-31828978"}}}</script> <script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/2a6304d3586af4d7ada93d74be9ab4bcccbacdec#commitcomment-31828978", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/2a6304d3586af4d7ada93d74be9ab4bcccbacdec#commitcomment-31828978", "name": "View Commit" }, "description": "View this Commit on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 

Oups sorry, it seems that Alistair already fixed that

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@nicolas-cellier-aka-nice on 2a6304d: Oups sorry, it seems that Alistair already fixed that"}],"action":{"name":"View Commit","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/2a6304d3586af4d7ada93d74be9ab4bcccbacdec#commitcomment-31829093"}}}</script> <script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/2a6304d3586af4d7ada93d74be9ab4bcccbacdec#commitcomment-31829093", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/2a6304d3586af4d7ada93d74be9ab4bcccbacdec#commitcomment-31829093", "name": "View Commit" }, "description": "View this Commit on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 

This was a mistake and was reverted in commit d475614,

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@akgrant43 on 2a6304d: This was a mistake and was reverted in commit d475614,"}],"action":{"name":"View Commit","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/2a6304d3586af4d7ada93d74be9ab4bcccbacdec#commitcomment-31829117"}}}</script> <script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/2a6304d3586af4d7ada93d74be9ab4bcccbacdec#commitcomment-31829117", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/2a6304d3586af4d7ada93d74be9ab4bcccbacdec#commitcomment-31829117", "name": "View Commit" }, "description": "View this Commit on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>