Hmm, this is very suspiscious
../../platforms/win32/plugins/SocketPlugin/sqWin32NewNet.c:872:8: warning: logical not is only applied to the left hand side of this bitwise operator [-Wlogical-not-parentheses]
if(!pss->sockState & SOCK_BOUND_UDP) {
^ ~
../../platforms/win32/plugins/SocketPlugin/sqWin32NewNet.c:872:8: note: add parentheses after the '!' to evaluate the bitwise operator first
if(!pss->sockState & SOCK_BOUND_UDP) {
^
( )
../../platforms/win32/plugins/SocketPlugin/sqWin32NewNet.c:872:8: note: add parentheses around left hand side expression to silence this warning
if(!pss->sockState & SOCK_BOUND_UDP) {
^
( )
IMO it should be if ( ! (state & flag) ) rather than if ( (! state) & flag )
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@nicolas-cellier-aka-nice on 9c16adb: Hmm, this is very suspiscious\r\n\r\n ../../platforms/win32/plugins/SocketPlugin/sqWin32NewNet.c:872:8: warning: logical not is only applied to the left hand side of this bitwise operator [-Wlogical-not-parentheses]\r\n if(!pss-\u003esockState \u0026 SOCK_BOUND_UDP) {\r\n ^ ~\r\n ../../platforms/win32/plugins/SocketPlugin/sqWin32NewNet.c:872:8: note: add parentheses after the '!' to evaluate the bitwise operator first\r\n if(!pss-\u003esockState \u0026 SOCK_BOUND_UDP) {\r\n ^\r\n ( )\r\n ../../platforms/win32/plugins/SocketPlugin/sqWin32NewNet.c:872:8: note: add parentheses around left hand side expression to silence this warning\r\n if(!pss-\u003esockState \u0026 SOCK_BOUND_UDP) {\r\n ^\r\n ( )\r\n\r\nIMO it should be `if ( ! (state \u0026 flag) )` rather than `if ( (! state) \u0026 flag )`"}],"action":{"name":"View Commit","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/9c16adb9e0ac15b5a2e05ca4d090b889594c5292#commitcomment-31618047"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/9c16adb9e0ac15b5a2e05ca4d090b889594c5292#commitcomment-31618047",
"url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/9c16adb9e0ac15b5a2e05ca4d090b889594c5292#commitcomment-31618047",
"name": "View Commit"
},
"description": "View this Commit on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>
Locked
