Re: [OpenSmalltalk/opensmalltalk-vm] Initiate .editorconfig files [ci skip] (c10131f)

 

Hi Nicolas, I use 4-space tabs, and I've documented somewhere that that's the house style for OpenSmalltalk. I would much rather see us keep to this and reformat files to agree with it than allow an 8 space tab style. As we know 8 space tabs indent too much and result in the awful mixed tab and space indent style that makes sources look so ugly if one gets the tab size wrong, and basically reads the viability of one choosing one's tab style. Further, Smalltalk (at last Smalltalk080 & Squeak) uses a 4 space tab and all the generated sources assume 4 space tabs. So can we please change the tab size in .editorconfig to 4?

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/c10131f02a806e8d67cca95c9f5ba6ec8927a4d6?email_source=notifications\u0026email_token=AIJPEW4EL7LNK2JR5OGCM5LQ2KO45A5CNFSM4J7BIUPKYY3PNVWWK3TUL52HS4DFVVBW63LNNF2EG33NNVSW45FKMNXW23LFNZ2F62LEZYBC37FV#commitcomment-36568245", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/c10131f02a806e8d67cca95c9f5ba6ec8927a4d6?email_source=notifications\u0026email_token=AIJPEW4EL7LNK2JR5OGCM5LQ2KO45A5CNFSM4J7BIUPKYY3PNVWWK3TUL52HS4DFVVBW63LNNF2EG33NNVSW45FKMNXW23LFNZ2F62LEZYBC37FV#commitcomment-36568245", "name": "View Commit" }, "description": "View this Commit on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 

Hi Eliot,
Default is set to 4 space tab stop but for win32 where the very old 8 space convention was used. It's very old code, and i'm just documenting how it is formatted.
Without a massive reformat, alignment becomes horrible, and new commits with 4 space tab stop make it impossible to get correctly aligned code.
I have contemplated doing a massive reformat, it's just that someone will massively become author of last change, a minor detail https://stackoverflow.com/questions/53502654/how-do-i-run-a-code-formatter-over-my-source-without-modifying-git-history
If you want, we can do it.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/c10131f02a806e8d67cca95c9f5ba6ec8927a4d6?email_source=notifications\u0026email_token=AIJPEWZ3VRPNF46HJFVF3V3Q2MHZXA5CNFSM4J7BIUPKYY3PNVWWK3TUL52HS4DFVVBW63LNNF2EG33NNVSW45FKMNXW23LFNZ2F62LEZYBC4BGI#commitcomment-36570312", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/c10131f02a806e8d67cca95c9f5ba6ec8927a4d6?email_source=notifications\u0026email_token=AIJPEWZ3VRPNF46HJFVF3V3Q2MHZXA5CNFSM4J7BIUPKYY3PNVWWK3TUL52HS4DFVVBW63LNNF2EG33NNVSW45FKMNXW23LFNZ2F62LEZYBC4BGI#commitcomment-36570312", "name": "View Commit" }, "description": "View this Commit on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 

Just a side note, the biggest problem with massive reformatting is not about blame, history is not lost. It is that every other change in every other branch will conflict and require more efforts to sync.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/c10131f02a806e8d67cca95c9f5ba6ec8927a4d6?email_source=notifications\u0026email_token=AIJPEW73YSBRY2F7SDLYKFLQ2N2ERA5CNFSM4J7BIUPKYY3PNVWWK3TUL52HS4DFVVBW63LNNF2EG33NNVSW45FKMNXW23LFNZ2F62LEZYBC4EIX#commitcomment-36573463", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/c10131f02a806e8d67cca95c9f5ba6ec8927a4d6?email_source=notifications\u0026email_token=AIJPEW73YSBRY2F7SDLYKFLQ2N2ERA5CNFSM4J7BIUPKYY3PNVWWK3TUL52HS4DFVVBW63LNNF2EG33NNVSW45FKMNXW23LFNZ2F62LEZYBC4EIX#commitcomment-36573463", "name": "View Commit" }, "description": "View this Commit on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>