Re: [OpenSmalltalk/opensmalltalk-vm] Mouse Wheel Events (#41)

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] Mouse Wheel Events (#41)

David T Lewis
 

Mouse wheels have been implemented in this commit for OSX and unix VM:

897ef17

I'm also proposing #461 for windows VM

Those events will be generated with a VM parameter saved with image.
In Squeak 5.3, see: Smalltalk sendMouseWheelEvents: true..

So we are near to close this issue...

However, the linux and OSX commit do not report button and modifiers state correctly (correctly = like every other mouse event).
We have to change that.

Also, some devices (like MacBook trackpad) generate a flow of wheel events with very small deltas (far less than 120, I observed deltas down to 1!).
This delivers far too many events to image side, making Morphic not responsive.
Thus we shall better accumulate a few of those events at VM side until a threshold is reached.
I have hardcoded a threshold of 20 on windows VM (WHEEL_DELTA/6), it kind of works for me... (maybe 10 would give a greater sensitivity).

I will create another branch with fixes for OSX/linux.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/41?email_source=notifications\u0026email_token=AIJPEW7VL5T4674LNT4LW7TQ2UOW7A5CNFSM4CNA2S22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHWFJZI#issuecomment-569136357", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/41?email_source=notifications\u0026email_token=AIJPEW7VL5T4674LNT4LW7TQ2UOW7A5CNFSM4CNA2S22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHWFJZI#issuecomment-569136357", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] Mouse Wheel Events (#41)

David T Lewis
 

Mabye we should introduce a "I'm interested in these kind of Events" mask sent to the VM…

So we can forego creating events the image is not interested in, all the way down to no events at all, for special purposes…


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/41?email_source=notifications\u0026email_token=AIJPEWYHJ32SWSKLSOHKPMLQ2UO6NA5CNFSM4CNA2S22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHWFLYQ#issuecomment-569136610", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/41?email_source=notifications\u0026email_token=AIJPEWYHJ32SWSKLSOHKPMLQ2UO6NA5CNFSM4CNA2S22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHWFLYQ#issuecomment-569136610", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>