Re: [OpenSmalltalk/opensmalltalk-vm] Rescue Win64 cygwin/mingw build and fix issue #498 (f679770)

 

Err, case of blindness! I see it know:

we pass --stack -Xlinker 2097152,2097152 where it should have been -Xlinker --stack=2097152,2097152

I will check if we can restore -mno-stack-arg-probe with above invocation...

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/f679770b318090f0abdddeabc59568a6520ed7f2#commitcomment-42875483", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/f679770b318090f0abdddeabc59568a6520ed7f2#commitcomment-42875483", "name": "View Commit" }, "description": "View this Commit on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 

Nope, wrong guess, the incantation was correct...

It should not be --stack=reserved,committed but --stack reserved,committed

We cannot pass an argument containing a coma (,) via -Wl,--stack,reserved,committed because it would transform the command into --stack reserved committed

So there was a mixture of -Wl, and -Xlinker, which was misleading but correct...

See https://stackoverflow.com/questions/7221141/any-difference-between-wl-option-and-xlinker-option-syntax-for-gcc

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/f679770b318090f0abdddeabc59568a6520ed7f2#commitcomment-42876577", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/f679770b318090f0abdddeabc59568a6520ed7f2#commitcomment-42876577", "name": "View Commit" }, "description": "View this Commit on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>