I've checked: it's a one liner to be changed in https://github.com/OpenSmalltalk/opensmalltalk-vm/blob/Cog/src/plugins/Win32OSProcessPlugin/Win32OSProcessPlugin.c near line 826 Since this is generated code from VMMaker, the code has to be changed in slang. IMO, there should be a boolean argument (optional) telling if we want to open the console or not. IMO false by default would be a good thing, though true for backward compatibility is also a possible alternative... Le mar. 11 déc. 2018 à 12:56, Nicolas Cellier <[hidden email]> a écrit :
|
And if you are using https://github.com/astares/Pharo-OS-Windows/blob/master/src/OS-Windows-Environment/WinProcess.class.st rather than the OSProcess plugin, then it's a bit more involved to make the changes, because you must also redirect the I/O thru a pipe, but it's doable too. Le mar. 11 déc. 2018 à 14:43, Nicolas Cellier <[hidden email]> a écrit :
|
In reply to this post by Nicolas Cellier
Hi Nicolas,
On Tue, Dec 11, 2018 at 5:43 AM Nicolas Cellier <[hidden email]> wrote:
So what changes do you want exactly? I'm happy to do the Smalltalk/Slang writing (adding the parameter, etc) but I don't know what result you'd like to see. Can you post the body of the function as you'd like to see it or the lines around line 826?
_,,,^..^,,,_ best, Eliot |
Hi all, I think that Christopher and Peter are talking about ProcessWrapper and not OSProcess, which is fetched from here: I think this was originally Levente's work? The source code is stored in a zip next to the dll in the same server, no history attached to it. Guille On Wed, Dec 12, 2018 at 12:30 AM Eliot Miranda <[hidden email]> wrote:
|
In reply to this post by Eliot Miranda-2
Hi Eliot, Sorry for not answering. I wanted to test whether a change were really necessary or not, but got distracted... I've never used OSProcess, so I must learn first, but the Debugger did not help. I will try again. Le mer. 12 déc. 2018 à 00:30, Eliot Miranda <[hidden email]> a écrit :
|
Free forum by Nabble | Edit this page |