For the OpalCompiler support, I have simply added the compiler method in Xtreams-Parsing because it does not conflict with anything else, I have the feeling that this is bearable... It's not ideal. That also means that bleeding-edge will not load in Squeak 4.4 or older, and maybe not elder version of Pharo...I have also added a NotFoundError subclass of NotFound in Xtreams-support. Maybe I could have changed NotFoundError reference into NotFound?
2013/11/19 Sven Van Caekenberghe <[hidden email]>
|
Unfortunate that KeyNotFound is not more generic (e.g., NotFound).
On Tue, Nov 19, 2013 at 4:50 PM, Nicolas Cellier <[hidden email]> wrote: > For the OpalCompiler support, I have simply added the compiler method in > Xtreams-Parsing because it does not conflict with anything else, I have the > feeling that this is bearable... > I have also added a NotFoundError subclass of NotFound in Xtreams-support. > It's not ideal. That also means that bleeding-edge will not load in Squeak > 4.4 or older, and maybe not elder version of Pharo... > Maybe I could have changed NotFoundError reference into NotFound? > In the future, or if we really want a bleding edge in elder images, we may > have to fork the Xtreams-support, but as long as we can, it's better to > avoid it. > > > 2013/11/19 Sven Van Caekenberghe <[hidden email]> >> >> >> On 18 Nov 2013, at 22:33, Nicolas Cellier >> <[hidden email]> wrote: >> >> > Ah, NotFoundError is also undeclared in Squeak, it is the VisualWorks >> > class name. >> > It could go into Xtreams-Support... >> >> OK, are you going to check this in, or should I ? >> >> How are we going to deal with platform specific stuff (like the Opal >> compiler switch) ? >> >> Sven > > > > > |
In reply to this post by Nicolas Cellier
On Tue, 19 Nov 2013, Nicolas Cellier wrote:
> For the OpalCompiler support, I have simply added the compiler method in Xtreams-Parsing because it does not conflict with anything else, I have > the feeling that this is bearable... > I have also added a NotFoundError subclass of NotFound in Xtreams-support. > It's not ideal. That also means that bleeding-edge will not load in Squeak 4.4 or older, and maybe not elder version of Pharo... You mean any version of Squeak, since there's no class named NotFound. > Maybe I could have changed NotFoundError reference into NotFound? > In the future, or if we really want a bleding edge in elder images, we may have to fork the Xtreams-support, but as long as we can, it's better to > avoid it. You can postpone this for a few months, but I don't see why it would make sense. Forking is bad, but if you want to support two diverging platforms, then you'll have to do it sooner or later. Levente > > > 2013/11/19 Sven Van Caekenberghe <[hidden email]> > > On 18 Nov 2013, at 22:33, Nicolas Cellier <[hidden email]> wrote: > > > Ah, NotFoundError is also undeclared in Squeak, it is the VisualWorks class name. > > It could go into Xtreams-Support... > > OK, are you going to check this in, or should I ? > > How are we going to deal with platform specific stuff (like the Opal compiler switch) ? > > Sven > > > > |
On Wed, 20 Nov 2013, Levente Uzonyi wrote:
> On Tue, 19 Nov 2013, Nicolas Cellier wrote: > >> For the OpalCompiler support, I have simply added the compiler method in >> Xtreams-Parsing because it does not conflict with anything else, I have >> the feeling that this is bearable... >> I have also added a NotFoundError subclass of NotFound in Xtreams-support. >> It's not ideal. That also means that bleeding-edge will not load in Squeak >> 4.4 or older, and maybe not elder version of Pharo... > > You mean any version of Squeak, since there's no class named NotFound. I see you've added it. > >> Maybe I could have changed NotFoundError reference into NotFound? >> In the future, or if we really want a bleding edge in elder images, we may >> have to fork the Xtreams-support, but as long as we can, it's better to >> avoid it. > > You can postpone this for a few months, but I don't see why it would make > sense. Forking is bad, but if you want to support two diverging platforms, > then you'll have to do it sooner or later. Well, it's not worth to bother with it, because IIUC the Pharo folks will fork it anyway. Levente > > > Levente > >> >> >> 2013/11/19 Sven Van Caekenberghe <[hidden email]> >> >> On 18 Nov 2013, at 22:33, Nicolas Cellier >> <[hidden email]> wrote: >> >> > Ah, NotFoundError is also undeclared in Squeak, it is the >> VisualWorks class name. >> > It could go into Xtreams-Support... >> >> OK, are you going to check this in, or should I ? >> >> How are we going to deal with platform specific stuff (like the Opal >> compiler switch) ? >> >> Sven >> >> >> >> > > |
Free forum by Nabble | Edit this page |