Re: [Pharo-dev] issue with large file path on windows

 

Hi Nicolai,

    I'm a bit concerned that this is creating drift with the "official" Cog source base at http://www.squeakvm.org/svn/squeak/branches/Cog.  Long filename support for win32 was recently added by Marcel Taumel in May of this year.  Are you tracking that?  How can we keep the sources harmonized?

On Sun, Aug 23, 2015 at 4:44 AM, Nicolai Hess <[hidden email]> wrote:

For those who had problems with pharo on windows and github based repositories,

I built a windows vm with support for long paths:

https://drive.google.com/file/d/0B8yEahnuIem2bmxwdzJuUXFxVGM/view?usp=sharing

For browsing directories with large paths (FileList or Inspect),
you may need one additional change in the image (But I am not really sure about that) :

DiskStore>>initialize
    super initialize.
    maxFileNameLength := Smalltalk vm maxFilenameLength ifNil: [ 32767 ].

please test and give feedback.

This wasn't as easy as I thought, and I had to make some more changes

for the file permissions (the stat-functions don't work for files with long paths).

Please test other file/folder operations.

nicolai

--

_,,,^..^,,,_

best, Eliot

 

2015-09-10 21:31 GMT+02:00 Eliot Miranda <[hidden email]>:

 

Hi Nicolai,

    I'm a bit concerned that this is creating drift with the "official" Cog source base at http://www.squeakvm.org/svn/squeak/branches/Cog.  Long filename support for win32 was recently added by Marcel Taumel in May of this year.  Are you tracking that?  How can we keep the sources harmonized?

Yes, I know, and I already asked on the ML if we can take that change or

if it is not possible because we have already other changes (pharos file plugin

provides addition attributes (the file permissions)).

But I got no response, so I tried to adopt Marcels change.

And I only found the change for sqWin32FilePrims.c, but missed the other change

that is necessary in sqWin32Directory.c (and asked on the ML). In the meantime Marcel added this but I could not find

the changed source, only an updated vm.

Is this change already comitted?

I would love if someone else got this working.

nicolai

 

On Sun, Aug 23, 2015 at 4:44 AM, Nicolai Hess <[hidden email]> wrote:

For those who had problems with pharo on windows and github based repositories,

I built a windows vm with support for long paths:

https://drive.google.com/file/d/0B8yEahnuIem2bmxwdzJuUXFxVGM/view?usp=sharing

For browsing directories with large paths (FileList or Inspect),
you may need one additional change in the image (But I am not really sure about that) :

DiskStore>>initialize
    super initialize.
    maxFileNameLength := Smalltalk vm maxFilenameLength ifNil: [ 32767 ].

please test and give feedback.

This wasn't as easy as I thought, and I had to make some more changes

for the file permissions (the stat-functions don't work for files with long paths).

Please test other file/folder operations.

nicolai

--

_,,,^..^,,,_

best, Eliot

 

Hi Nicolai,

On Thu, Sep 10, 2015 at 1:17 PM, Nicolai Hess <[hidden email]> wrote:

 

2015-09-10 21:31 GMT+02:00 Eliot Miranda <[hidden email]>:

 

Hi Nicolai,

    I'm a bit concerned that this is creating drift with the "official" Cog source base at http://www.squeakvm.org/svn/squeak/branches/Cog.  Long filename support for win32 was recently added by Marcel Taumel in May of this year.  Are you tracking that?  How can we keep the sources harmonized?

Yes, I know, and I already asked on the ML if we can take that change or

if it is not possible because we have already other changes (pharos file plugin

provides addition attributes (the file permissions)).

Esteban and I just harmonized this.  I'm (almost correctly) generating the plugin source such that one can define either PharoVM or not to chose between the different versions.  I say "almost" because I'm currently spitting out

#define PharoVM 0

...

#if PharoVM

instead of

#if !defined(PharoVM)

#   define PharoVM 0

#endif

...

#if PharoVM

but I'll fix it v soon.

But I got no response, so I tried to adopt Marcels change.

And I only found the change for sqWin32FilePrims.c, but missed the other change

that is necessary in sqWin32Directory.c (and asked on the ML). In the meantime Marcel added this but I could not find

the changed source, only an updated vm.

Is this change already comitted?

Yes, see http://www.squeakvm.org/svn/squeak/branches/Cog/platforms/win32/vm/sqWin32Directory.c

I'm sorry I didn't see your message.  Did you ask on vm-dev?

 

I would love if someone else got this working.

:-)  I hear you :-)

 

nicolai

 

On Sun, Aug 23, 2015 at 4:44 AM, Nicolai Hess <[hidden email]> wrote:

For those who had problems with pharo on windows and github based repositories,

I built a windows vm with support for long paths:

https://drive.google.com/file/d/0B8yEahnuIem2bmxwdzJuUXFxVGM/view?usp=sharing

For browsing directories with large paths (FileList or Inspect),
you may need one additional change in the image (But I am not really sure about that) :

DiskStore>>initialize
    super initialize.
    maxFileNameLength := Smalltalk vm maxFilenameLength ifNil: [ 32767 ].

please test and give feedback.

This wasn't as easy as I thought, and I had to make some more changes

for the file permissions (the stat-functions don't work for files with long paths).

Please test other file/folder operations.

nicolai

--

_,,,^..^,,,_

best, Eliot

--

_,,,^..^,,,_

best, Eliot

2015-09-10 23:07 GMT+02:00 Eliot Miranda <[hidden email]>:

 

Hi Nicolai,

On Thu, Sep 10, 2015 at 1:17 PM, Nicolai Hess <[hidden email]> wrote:

 

2015-09-10 21:31 GMT+02:00 Eliot Miranda <[hidden email]>:

 

Hi Nicolai,

    I'm a bit concerned that this is creating drift with the "official" Cog source base at http://www.squeakvm.org/svn/squeak/branches/Cog.  Long filename support for win32 was recently added by Marcel Taumel in May of this year.  Are you tracking that?  How can we keep the sources harmonized?

Yes, I know, and I already asked on the ML if we can take that change or

if it is not possible because we have already other changes (pharos file plugin

provides addition attributes (the file permissions)).

Esteban and I just harmonized this.  I'm (almost correctly) generating the plugin source such that one can define either PharoVM or not to chose between the different versions.  I say "almost" because I'm currently spitting out

#define PharoVM 0

...

#if PharoVM

instead of

#if !defined(PharoVM)

#   define PharoVM 0

#endif

...

#if PharoVM

but I'll fix it v soon.

OK, I'll try to copy marcels solution

 

But I got no response, so I tried to adopt Marcels change.

And I only found the change for sqWin32FilePrims.c, but missed the other change

that is necessary in sqWin32Directory.c (and asked on the ML). In the meantime Marcel added this but I could not find

the changed source, only an updated vm.

Is this change already comitted?

Yes, see http://www.squeakvm.org/svn/squeak/branches/Cog/platforms/win32/vm/sqWin32Directory.c

Ah, good. Now (I must be blind, but) I can not see the other change, shouldn't there

be a "plugins" folder in Cog/platforms/win32/?
Where are the changes to sqWin32FilePrims.c now?

 

I'm sorry I didn't see your message.  Did you ask on vm-dev?

I am not sure, maybe I only send it in the squeak-dev list

 

 

I would love if someone else got this working.

:-)  I hear you :-)

 

nicolai

 

On Sun, Aug 23, 2015 at 4:44 AM, Nicolai Hess <[hidden email]> wrote:

For those who had problems with pharo on windows and github based repositories,

I built a windows vm with support for long paths:

https://drive.google.com/file/d/0B8yEahnuIem2bmxwdzJuUXFxVGM/view?usp=sharing

For browsing directories with large paths (FileList or Inspect),
you may need one additional change in the image (But I am not really sure about that) :

DiskStore>>initialize
    super initialize.
    maxFileNameLength := Smalltalk vm maxFilenameLength ifNil: [ 32767 ].

please test and give feedback.

This wasn't as easy as I thought, and I had to make some more changes

for the file permissions (the stat-functions don't work for files with long paths).

Please test other file/folder operations.

nicolai

--

_,,,^..^,,,_

best, Eliot

--

_,,,^..^,,,_

best, Eliot

2015-09-11 9:43 GMT+02:00 Nicolai Hess <[hidden email]>:

2015-09-10 23:07 GMT+02:00 Eliot Miranda <[hidden email]>:

 

Hi Nicolai,

On Thu, Sep 10, 2015 at 1:17 PM, Nicolai Hess <[hidden email]> wrote:

 

2015-09-10 21:31 GMT+02:00 Eliot Miranda <[hidden email]>:

 

Hi Nicolai,

    I'm a bit concerned that this is creating drift with the "official" Cog source base at http://www.squeakvm.org/svn/squeak/branches/Cog.  Long filename support for win32 was recently added by Marcel Taumel in May of this year.  Are you tracking that?  How can we keep the sources harmonized?

Yes, I know, and I already asked on the ML if we can take that change or

if it is not possible because we have already other changes (pharos file plugin

provides addition attributes (the file permissions)).

Esteban and I just harmonized this.  I'm (almost correctly) generating the plugin source such that one can define either PharoVM or not to chose between the different versions.  I say "almost" because I'm currently spitting out

#define PharoVM 0

...

#if PharoVM

instead of

#if !defined(PharoVM)

#   define PharoVM 0

#endif

...

#if PharoVM

but I'll fix it v soon.

OK, I'll try to copy marcels solution

 

But I got no response, so I tried to adopt Marcels change.

And I only found the change for sqWin32FilePrims.c, but missed the other change

that is necessary in sqWin32Directory.c (and asked on the ML). In the meantime Marcel added this but I could not find

the changed source, only an updated vm.

Is this change already comitted?

Yes, see http://www.squeakvm.org/svn/squeak/branches/Cog/platforms/win32/vm/sqWin32Directory.c

Ah, good. Now (I must be blind, but) I can not see the other change, shouldn't there

be a "plugins" folder in Cog/platforms/win32/?
Where are the changes to sqWin32FilePrims.c now?

Ok, found it. It is in the trunk branch :)

 

 

I'm sorry I didn't see your message.  Did you ask on vm-dev?

I am not sure, maybe I only send it in the squeak-dev list

 

 

I would love if someone else got this working.

:-)  I hear you :-)

 

nicolai

 

On Sun, Aug 23, 2015 at 4:44 AM, Nicolai Hess <[hidden email]> wrote:

For those who had problems with pharo on windows and github based repositories,

I built a windows vm with support for long paths:

https://drive.google.com/file/d/0B8yEahnuIem2bmxwdzJuUXFxVGM/view?usp=sharing

For browsing directories with large paths (FileList or Inspect),
you may need one additional change in the image (But I am not really sure about that) :

DiskStore>>initialize
    super initialize.
    maxFileNameLength := Smalltalk vm maxFilenameLength ifNil: [ 32767 ].

please test and give feedback.

This wasn't as easy as I thought, and I had to make some more changes

for the file permissions (the stat-functions don't work for files with long paths).

Please test other file/folder operations.

nicolai

--

_,,,^..^,,,_

best, Eliot

--

_,,,^..^,,,_

best, Eliot

 

2015-09-11 9:44 GMT+02:00 Nicolai Hess <[hidden email]>:

2015-09-11 9:43 GMT+02:00 Nicolai Hess <[hidden email]>:

2015-09-10 23:07 GMT+02:00 Eliot Miranda <[hidden email]>:

 

Hi Nicolai,

On Thu, Sep 10, 2015 at 1:17 PM, Nicolai Hess <[hidden email]> wrote:

 

2015-09-10 21:31 GMT+02:00 Eliot Miranda <[hidden email]>:

 

Hi Nicolai,

    I'm a bit concerned that this is creating drift with the "official" Cog source base at http://www.squeakvm.org/svn/squeak/branches/Cog.  Long filename support for win32 was recently added by Marcel Taumel in May of this year.  Are you tracking that?  How can we keep the sources harmonized?

Yes, I know, and I already asked on the ML if we can take that change or

if it is not possible because we have already other changes (pharos file plugin

provides addition attributes (the file permissions)).

Esteban and I just harmonized this.  I'm (almost correctly) generating the plugin source such that one can define either PharoVM or not to chose between the different versions.  I say "almost" because I'm currently spitting out

#define PharoVM 0

...

#if PharoVM

instead of

#if !defined(PharoVM)

#   define PharoVM 0

#endif

...

#if PharoVM

but I'll fix it v soon.

OK, I'll try to copy marcels solution

 

But I got no response, so I tried to adopt Marcels change.

And I only found the change for sqWin32FilePrims.c, but missed the other change

that is necessary in sqWin32Directory.c (and asked on the ML). In the meantime Marcel added this but I could not find

the changed source, only an updated vm.

Is this change already comitted?

Yes, see http://www.squeakvm.org/svn/squeak/branches/Cog/platforms/win32/vm/sqWin32Directory.c

Ah, good. Now (I must be blind, but) I can not see the other change, shouldn't there

be a "plugins" folder in Cog/platforms/win32/?
Where are the changes to sqWin32FilePrims.c now?

Ok, found it. It is in the trunk branch :)

No, wait, now I am confused. The change to sqWin32FilePrims.c is only in the trunk branch and the change to sqWin32Directory.c is

only in the Cog branch. What branch includes the solution for both (sqWin32Directory.c and sqWin32FilePrims.c) and should be

used for a merge into pharos vm repository?

 

 

 

I'm sorry I didn't see your message.  Did you ask on vm-dev?

I am not sure, maybe I only send it in the squeak-dev list

 

 

I would love if someone else got this working.

:-)  I hear you :-)

 

nicolai

 

On Sun, Aug 23, 2015 at 4:44 AM, Nicolai Hess <[hidden email]> wrote:

For those who had problems with pharo on windows and github based repositories,

I built a windows vm with support for long paths:

https://drive.google.com/file/d/0B8yEahnuIem2bmxwdzJuUXFxVGM/view?usp=sharing

For browsing directories with large paths (FileList or Inspect),
you may need one additional change in the image (But I am not really sure about that) :

DiskStore>>initialize
    super initialize.
    maxFileNameLength := Smalltalk vm maxFilenameLength ifNil: [ 32767 ].

please test and give feedback.

This wasn't as easy as I thought, and I had to make some more changes

for the file permissions (the stat-functions don't work for files with long paths).

Please test other file/folder operations.

nicolai

--

_,,,^..^,,,_

best, Eliot

--

_,,,^..^,,,_

best, Eliot

 

Hi Nicolai,

    I'm a bit concerned that this is creating drift with the "official" Cog source base at http://www.squeakvm.org/svn/squeak/branches/Cog.  Long filename support for win32 was recently added by Marcel Taumel in May of this year.  Are you tracking that?  How can we keep the sources harmonized?

On Sun, Aug 23, 2015 at 4:44 AM, Nicolai Hess <[hidden email]> wrote:

For those who had problems with pharo on windows and github based repositories,

I built a windows vm with support for long paths:

https://drive.google.com/file/d/0B8yEahnuIem2bmxwdzJuUXFxVGM/view?usp=sharing

For browsing directories with large paths (FileList or Inspect),
you may need one additional change in the image (But I am not really sure about that) :

DiskStore>>initialize
    super initialize.
    maxFileNameLength := Smalltalk vm maxFilenameLength ifNil: [ 32767 ].

please test and give feedback.

This wasn't as easy as I thought, and I had to make some more changes

for the file permissions (the stat-functions don't work for files with long paths).

Please test other file/folder operations.

nicolai

--

_,,,^..^,,,_

best, Eliot

 

Thanks Nicolai, that's great!  I'll merge in your changes.  Which files do I need to look at?

On Sat, Sep 12, 2015 at 8:00 AM, Nicolai Hess <[hidden email]> wrote:

 

2015-09-10 21:31 GMT+02:00 Eliot Miranda <[hidden email]>:

 

Hi Nicolai,

    I'm a bit concerned that this is creating drift with the "official" Cog source base at http://www.squeakvm.org/svn/squeak/branches/Cog.  Long filename support for win32 was recently added by Marcel Taumel in May of this year.  Are you tracking that?  How can we keep the sources harmonized?

Ok, I removed all of my code again and merged with sqWin32Directory.c and sqWin32FilePrims.c from the official cog source.

I left only pharos additions for the fileattributes (posixpermissions) this should make it easier to merge which the

squeak vm main branch (wrapped with pharo vm ifdefs).

github branch: https://github.com/nicolaihess/pharo-vm/tree/harmonize_win_file_plugin

I'll create a push request.

nicolai

 

On Sun, Aug 23, 2015 at 4:44 AM, Nicolai Hess <[hidden email]> wrote:

For those who had problems with pharo on windows and github based repositories,

I built a windows vm with support for long paths:

https://drive.google.com/file/d/0B8yEahnuIem2bmxwdzJuUXFxVGM/view?usp=sharing

For browsing directories with large paths (FileList or Inspect),
you may need one additional change in the image (But I am not really sure about that) :

DiskStore>>initialize
    super initialize.
    maxFileNameLength := Smalltalk vm maxFilenameLength ifNil: [ 32767 ].

please test and give feedback.

This wasn't as easy as I thought, and I had to make some more changes

for the file permissions (the stat-functions don't work for files with long paths).

Please test other file/folder operations.

nicolai

--

_,,,^..^,,,_

best, Eliot

--

_,,,^..^,,,_

best, Eliot

On Sat, Sep 12, 2015 at 11:00 PM, Nicolai Hess <[hidden email]> wrote:
>
>
>
> 2015-09-10 21:31 GMT+02:00 Eliot Miranda <[hidden email]>:
>>
>>
>> Hi Nicolai,
>>
>>     I'm a bit concerned that this is creating drift with the "official" Cog source base at http://www.squeakvm.org/svn/squeak/branches/Cog.  Long filename support for win32 was recently added by Marcel Taumel in May of this year.  Are you tracking that?  How can we keep the sources harmonized?
>
>
> Ok, I removed all of my code again and merged with sqWin32Directory.c and sqWin32FilePrims.c from the official cog source.
> I left only pharos additions for the fileattributes (posixpermissions) this should make it easier to merge which the
> squeak vm main branch (wrapped with pharo vm ifdefs).

What is the purpose of fileattributes? In the interests of further
minimising drift, is this useful to Squeak?
cheers -ben

 

Pharo uses them. 

Posix permissions are useful for both linux and mac. 

Windows uses also the posix permissions that came with MinGW… I do not think they are useful but we provide them anyway :)

Esteban

ps: I do not know what are you doing there guys, but you broke my builds (I’m taking a look at them now) :P

On 15 Sep 2015, at 09:24, Nicolai Hess <[hidden email]> wrote:

2015-09-15 4:11 GMT+02:00 Ben Coman <[hidden email]>:

On Sat, Sep 12, 2015 at 11:00 PM, Nicolai Hess <[hidden email]> wrote:
>
>
>
> 2015-09-10 21:31 GMT+02:00 Eliot Miranda <[hidden email]>:
>>
>>
>> Hi Nicolai,
>>
>>     I'm a bit concerned that this is creating drift with the "official" Cog source base at http://www.squeakvm.org/svn/squeak/branches/Cog.  Long filename support for win32 was recently added by Marcel Taumel in May of this year.  Are you tracking that?  How can we keep the sources harmonized?
>
>
> Ok, I removed all of my code again and merged with sqWin32Directory.c and sqWin32FilePrims.c from the official cog source.
> I left only pharos additions for the fileattributes (posixpermissions) this should make it easier to merge which the
> squeak vm main branch (wrapped with pharo vm ifdefs).

What is the purpose of fileattributes? In the interests of further
minimising drift, is this useful to Squeak?
cheers -ben

I don't know, I don't think we use it at all. And for the different platforms, the permission attributes

doesn't really *are the same*. For example, the read/write permissions we are showing for

win32 platform, don't have much to do with win32 access restrictions - Idon't know about macos.

> On 15 Sep 2015, at 14:13, David T. Lewis <[hidden email]> wrote:
>
>
> On Tue, Sep 15, 2015 at 11:40:48AM +0200, Esteban Lorenzano wrote:
>>
>> Pharo uses them.
>>
>> Posix permissions are useful for both linux and mac.
>> Windows uses also the posix permissions that came with MinGW??? I do not think they are useful but we provide them anyway :)
>
>
> Posix permissions are based on Unix, and are very platform specific. The
> Windows equivalents are semantically different, and other operating systems
> may exist that are not Unix based at all.
>
> IMO, platform specific functions should go into separate plugins, and not
> in FilePlugin.

well, I disagree :)
I do not find this approach practical… because in general, there is no other systems that may exist using other permissions than POSIX. Except Windows, of course, but even for windows, there are compatibility layers that we can use.
In the case of the FilePlugin extensions, we choose to stay POSIX because in general, as its been said before, the job of a virtual machine is been virtual: to provide an “abstract machine” common for everything in the image. I’m not saying that this is possible and even desirable in all cases, but it should be something to think about.
In that case, we could design a common file permissions different to the one of Windows and different to POSIX, but I think POSIX does the job just fine.

Also, the choice was: POSIX or nothing (because we didn’t have anything before).
I would be very happy if we agree in a better solution, and we implement it.
But in the mean time, a not perfect solution is better than none.

Esteban

>
> Dave
>
>
>
>>
>> Esteban
>>
>> ps: I do not know what are you doing there guys, but you broke my builds (I???m taking a look at them now) :P
>>
>>> On 15 Sep 2015, at 09:24, Nicolai Hess <[hidden email]> wrote:
>>>
>>>
>>>
>>> 2015-09-15 4:11 GMT+02:00 Ben Coman <[hidden email] <mailto:[hidden email]>>:
>>>
>>> On Sat, Sep 12, 2015 at 11:00 PM, Nicolai Hess <[hidden email] <mailto:[hidden email]>> wrote:
>>>>
>>>>
>>>>
>>>> 2015-09-10 21:31 GMT+02:00 Eliot Miranda <[hidden email] <mailto:[hidden email]>>:
>>>>>
>>>>>
>>>>> Hi Nicolai,
>>>>>
>>>>>    I'm a bit concerned that this is creating drift with the "official" Cog source base at http://www.squeakvm.org/svn/squeak/branches/Cog <http://www.squeakvm.org/svn/squeak/branches/Cog>.  Long filename support for win32 was recently added by Marcel Taumel in May of this year.  Are you tracking that?  How can we keep the sources harmonized?
>>>>
>>>>
>>>> Ok, I removed all of my code again and merged with sqWin32Directory.c and sqWin32FilePrims.c from the official cog source.
>>>> I left only pharos additions for the fileattributes (posixpermissions) this should make it easier to merge which the
>>>> squeak vm main branch (wrapped with pharo vm ifdefs).
>>>
>>> What is the purpose of fileattributes? In the interests of further
>>> minimising drift, is this useful to Squeak?
>>> cheers -ben
>>>
>>> I don't know, I don't think we use it at all. And for the different platforms, the permission attributes
>>> doesn't really *are the same*. For example, the read/write permissions we are showing for
>>> win32 platform, don't have much to do with win32 access restrictions - Idon't know about macos.
>>>
>>>
>>>
>>>
>>>
>>
>