On Thu, Sep 22, 2011 at 11:06 AM, Eliot Miranda <[hidden email]> wrote: Hi Igor, Here's the format field (Behavior>instSpec at the image level) as currently populated: 0 = 0 sized objects (UndefinedObject True False et al)
1 = non-indexable objects with inst vars (Point et al) 2 = indexable objects with no inst vars (Array et al) 3 = indexable objects with inst vars (MethodContext AdditionalMethodState et al)
4 = weak indexable objects with inst vars (WeakArray et al) 6 = 32-bit indexable objects (Float, Bitmap ert al) 8 = 8-bit indexable objects (ByteString, ByteArray et al) 12 = CompiledMethod
N.B. in the VM the least two bits of the format/instSpec for byte objects (formats 8 and 12) is used to encode the number of odd bytes in the object, so that a 1 character ByteString has a format of 11, = 8 + 3, size = 1 word - 3 bytes.
For the future (i.e. the new GC/object representation, /not/ for the first implementation of ephemerons which we can do now, for Pharo 1.4 or 1.5) we need to extend format/instSpec to support 64 bits. I think format needs to be made a 5 bit field with room for 4 bits of odd bytes for 64-bit images. [For VMers, the Size4Bit is a horrible hack). So then
0 = 0 sized objects (UndefinedObject True False et al) 1 = non-indexable objects with inst vars (Point et al) 2 = indexable objects with no inst vars (Array et al) 3 = indexable objects with inst vars (MethodContext AdditionalMethodState et al)
4 = weak indexable objects with inst vars (WeakArray et al) 5 = weak non-indexable objects with inst vars (ephemerons) (Ephemeron) and we need 8 CompiledMethod values, 8 byte values, 4 16-bit values, 2 32-bit values and a 64-bit value, = 23 values, 23 + 5 = 30, so there is room, e.g.
9 (?) 64-bit indexable 10 - 11 32-bit indexable 12 - 15 16-bit indexable 16 - 23 byte indexable 24 - 31 compiled method In 32-bit images only the least significant 2 bits would be used for formats 16 & 24, and the least significant bit for format 12.
best, Eliot |
On Thu, Sep 22, 2011 at 11:28 AM, Igor Stasenko <[hidden email]> wrote:
That would make sense. Boosting it so that the new VMs can run older images and newer, ephemeron images, but that ephemeron images won't open on older VMs. Yes, this makes perfect sense.
I think it is, because clearly, an images which expect ephemerons to best, Eliot |
In reply to this post by Eliot Miranda-2
On 22.09.2011 20:20, Eliot Miranda wrote: If we are changing the format for 64bit images anyways, why not simplify it/ be more consistent by spending a full byte? Bit: 8 7 6 5 4 3 2 1 | 64bit | 32bit |16bit | 8bit |compiled | weak | indexable | instVars | (Odd number encoded in remaining indexable bit fields) Could get away with 7 if you put f.ex. the unused indexable weak combination (6) as compiled method/8bit Or is the header space in your new 64bit format already quite filled, so this is a bad idea? Cheers, Henry |
On Thu, Sep 22, 2011 at 12:29 PM, Henrik Sperre Johansen <[hidden email]> wrote:
I used to prefer this approach but I've realised that the format/instSpec approach (I think Dan came up with) makes better use of bits because so many of the bit combinations are mutually exclusive. For example, pointers excludes all the byte/short/32-bit/64-bit indexability combinations. Also, see below...
Yes, ish. But they're scarce, and very useful for experiments etc. Right now I have typedef struct {
unsigned short classIndex; unsigned unused0 : 6;
unsigned isPinned : 1; unsigned isImmutable : 1;
unsigned format : 5; /* on a byte boundary */ unsigned isMarked : 1;
unsigned isGrey : 1; unsigned isRemembered : 1;
unsigned objHash : 24; /* on a 32-bit word boundary */ unsigned char slotSize; /* on a byte boundary */
} CogObjectHeader; Where classIndex is 16-bits simply for efficiency and will grow to 20 or 22 bits as needed. So one could steal one or two bits from unused0 and two bits from objHash, and give these to format, but it would be a waste. Better keep these back for other uses.
Also, can I ask the assembled company exactly how many bits you'd spend on the objHash (identityHash)? Think forward to 64-bits. Is 24 bits about all we can afford or still too generous? Anybody have any data to contribute?
-- best, Eliot |
In reply to this post by Eliot Miranda-2
On Thu, Sep 22, 2011 at 11:37:46AM -0700, Eliot Miranda wrote: > > On Thu, Sep 22, 2011 at 11:28 AM, Igor Stasenko <[hidden email]> wrote: > > > > Do you think this will require boosting an image format version number? > > That would make sense. Boosting it so that the new VMs can run older images > and newer, ephemeron images, but that ephemeron images won't open on older > VMs. Yes, this makes perfect sense. Please use image format number 6521, allocating bit 5 as the "ephemeron support bit". Details: 6505 printStringBase: 2 ==> '1100101101001' ImageFormat bitsInUse printStringBase: 2 ==> '10001100111101111' "Next available bit is bit 5" 2r1100101101001 ==> 6505 2r1100101111001 ==> 6521 "A 64 bit image with cog support plus ephemeron support would be 68019" (ImageFormat wordSize: 4 cog: true) asInteger ==> 6505 (ImageFormat wordSize: 4 cog: true) asInteger bitOr: 2r10000 ==> 6521 (ImageFormat wordSize: 8 cog: true) asInteger ==> 68003 (ImageFormat wordSize: 8 cog: true) asInteger bitOr: 2r10000 ==> 68019 6505 printStringBase: 2 ==> '1100101101001' 6521 printStringBase: 2 ==> '1100101111001' 68003 printStringBase: 2 ==> '10000100110100011' 68019 printStringBase: 2 ==> '10000100110110011' If you agree, I'll update ImageFormat and ImageFormatTest to document the new format number assignments. Dave |
In reply to this post by Eliot Miranda-2
Stupid question: what does it mean? > we need 8 CompiledMethod values Stef > > > Here's the format field (Behavior>instSpec at the image level) as currently populated: > > 0 = 0 sized objects (UndefinedObject True False et al) > 1 = non-indexable objects with inst vars (Point et al) > 2 = indexable objects with no inst vars (Array et al) > 3 = indexable objects with inst vars (MethodContext AdditionalMethodState et al) > 4 = weak indexable objects with inst vars (WeakArray et al) > 6 = 32-bit indexable objects (Float, Bitmap ert al) > 8 = 8-bit indexable objects (ByteString, ByteArray et al) > 12 = CompiledMethod > > N.B. in the VM the least two bits of the format/instSpec for byte objects (formats 8 and 12) is used to encode the number of odd bytes in the object, so that a 1 character ByteString has a format of 11, = 8 + 3, size = 1 word - 3 bytes. > > > For the future (i.e. the new GC/object representation, /not/ for the first implementation of ephemerons which we can do now, for Pharo 1.4 or 1.5) we need to extend format/instSpec to support 64 bits. I think format needs to be made a 5 bit field with room for 4 bits of odd bytes for 64-bit images. [For VMers, the Size4Bit is a horrible hack). So then > > 0 = 0 sized objects (UndefinedObject True False et al) > 1 = non-indexable objects with inst vars (Point et al) > 2 = indexable objects with no inst vars (Array et al) > 3 = indexable objects with inst vars (MethodContext AdditionalMethodState et al) > 4 = weak indexable objects with inst vars (WeakArray et al) > 5 = weak non-indexable objects with inst vars (ephemerons) (Ephemeron) > > and we need 8 CompiledMethod values, 8 byte values, 4 16-bit values, 2 32-bit values and a 64-bit value, = 23 values, 23 + 5 = 30, so there is room, e.g. > > 9 (?) 64-bit indexable > 10 - 11 32-bit indexable > 12 - 15 16-bit indexable > 16 - 23 byte indexable > 24 - 31 compiled method > > In 32-bit images only the least significant 2 bits would be used for formats 16 & 24, and the least significant bit for format 12. > > |
On 23 September 2011 09:44, stephane ducasse <[hidden email]> wrote: > > Stupid question: > > what does it mean? >> we need 8 CompiledMethod values > to encode odd size values. The header encoding size in machine words, which on 64 bit system are always 8-byte aligned. But compiled method size could be any size in bytes and to encode it we need 3 bits somewhere (or 8 different values), to encode size in bytes i.e.: sizeinbytes = sizeInWords*8 + (oddSize) where oddsize is our 0..7 value > Stef > >> >> >> Here's the format field (Behavior>instSpec at the image level) as currently populated: >> >> 0 = 0 sized objects (UndefinedObject True False et al) >> 1 = non-indexable objects with inst vars (Point et al) >> 2 = indexable objects with no inst vars (Array et al) >> 3 = indexable objects with inst vars (MethodContext AdditionalMethodState et al) >> 4 = weak indexable objects with inst vars (WeakArray et al) >> 6 = 32-bit indexable objects (Float, Bitmap ert al) >> 8 = 8-bit indexable objects (ByteString, ByteArray et al) >> 12 = CompiledMethod >> >> N.B. in the VM the least two bits of the format/instSpec for byte objects (formats 8 and 12) is used to encode the number of odd bytes in the object, so that a 1 character ByteString has a format of 11, = 8 + 3, size = 1 word - 3 bytes. >> >> >> For the future (i.e. the new GC/object representation, /not/ for the first implementation of ephemerons which we can do now, for Pharo 1.4 or 1.5) we need to extend format/instSpec to support 64 bits. I think format needs to be made a 5 bit field with room for 4 bits of odd bytes for 64-bit images. [For VMers, the Size4Bit is a horrible hack). So then >> >> 0 = 0 sized objects (UndefinedObject True False et al) >> 1 = non-indexable objects with inst vars (Point et al) >> 2 = indexable objects with no inst vars (Array et al) >> 3 = indexable objects with inst vars (MethodContext AdditionalMethodState et al) >> 4 = weak indexable objects with inst vars (WeakArray et al) >> 5 = weak non-indexable objects with inst vars (ephemerons) (Ephemeron) >> >> and we need 8 CompiledMethod values, 8 byte values, 4 16-bit values, 2 32-bit values and a 64-bit value, = 23 values, 23 + 5 = 30, so there is room, e.g. >> >> 9 (?) 64-bit indexable >> 10 - 11 32-bit indexable >> 12 - 15 16-bit indexable >> 16 - 23 byte indexable >> 24 - 31 compiled method >> >> In 32-bit images only the least significant 2 bits would be used for formats 16 & 24, and the least significant bit for format 12. >> >> > -- Best regards, Igor Stasenko. |
btw, i am still wondering if it necessary to know exact size in bytes of compiled method. I think we could align its size to 8 bytes without much loss. then it will take single place (value) in format instead of 8. Of course, for bytearrays we cannot do same trick, since then we will have not container left which can hold data with size aligned to single byte. On 23 September 2011 12:58, Igor Stasenko <[hidden email]> wrote: > On 23 September 2011 09:44, stephane ducasse <[hidden email]> wrote: >> >> Stupid question: >> >> what does it mean? >>> we need 8 CompiledMethod values >> > to encode odd size values. > The header encoding size in machine words, which on 64 bit system are > always 8-byte aligned. > But compiled method size could be any size in bytes and to encode it > we need 3 bits somewhere (or 8 different values), > to encode size in bytes i.e.: > > sizeinbytes = sizeInWords*8 + (oddSize) > > where oddsize is our 0..7 value > >> Stef >> >>> >>> >>> Here's the format field (Behavior>instSpec at the image level) as currently populated: >>> >>> 0 = 0 sized objects (UndefinedObject True False et al) >>> 1 = non-indexable objects with inst vars (Point et al) >>> 2 = indexable objects with no inst vars (Array et al) >>> 3 = indexable objects with inst vars (MethodContext AdditionalMethodState et al) >>> 4 = weak indexable objects with inst vars (WeakArray et al) >>> 6 = 32-bit indexable objects (Float, Bitmap ert al) >>> 8 = 8-bit indexable objects (ByteString, ByteArray et al) >>> 12 = CompiledMethod >>> >>> N.B. in the VM the least two bits of the format/instSpec for byte objects (formats 8 and 12) is used to encode the number of odd bytes in the object, so that a 1 character ByteString has a format of 11, = 8 + 3, size = 1 word - 3 bytes. >>> >>> >>> For the future (i.e. the new GC/object representation, /not/ for the first implementation of ephemerons which we can do now, for Pharo 1.4 or 1.5) we need to extend format/instSpec to support 64 bits. I think format needs to be made a 5 bit field with room for 4 bits of odd bytes for 64-bit images. [For VMers, the Size4Bit is a horrible hack). So then >>> >>> 0 = 0 sized objects (UndefinedObject True False et al) >>> 1 = non-indexable objects with inst vars (Point et al) >>> 2 = indexable objects with no inst vars (Array et al) >>> 3 = indexable objects with inst vars (MethodContext AdditionalMethodState et al) >>> 4 = weak indexable objects with inst vars (WeakArray et al) >>> 5 = weak non-indexable objects with inst vars (ephemerons) (Ephemeron) >>> >>> and we need 8 CompiledMethod values, 8 byte values, 4 16-bit values, 2 32-bit values and a 64-bit value, = 23 values, 23 + 5 = 30, so there is room, e.g. >>> >>> 9 (?) 64-bit indexable >>> 10 - 11 32-bit indexable >>> 12 - 15 16-bit indexable >>> 16 - 23 byte indexable >>> 24 - 31 compiled method >>> >>> In 32-bit images only the least significant 2 bits would be used for formats 16 & 24, and the least significant bit for format 12. >>> >>> >> > > > > -- > Best regards, > Igor Stasenko. > -- Best regards, Igor Stasenko. |
In reply to this post by Eliot Miranda-2
On 22.09.2011 21:57, Eliot Miranda wrote: This is probably a stupid question, but where is the variable size in words stored? In a quadword preceding the header like it is in 32bit format? The reason I'm asking is that to me, the main application of identityHash is for HashedCollection's, and the max size of those thus impact what a reasonable answer would be... Cheers, Henry |
On Fri, Sep 23, 2011 at 5:01 AM, Henrik Sperre Johansen <[hidden email]> wrote:
So the size of an object in slots (32-bit or 64-bit) is the byte slotSize field, allowing an object to have 254 slots before it is too big for this representation. If an object has more than 254 slots its slotSize has the value 255 and an additional 64-bit word (64-bit to guarantee 64-bit alignment of all objects) preceeding contains the actual slot size (even if only 32-bits are used). This means that there is a maximum of 2/255 words of overhead for this extra word, or < 1%.
So to compute the size of an indexable object one determines the slot size and subtracts the number of named inst vars. For format 4 there are no named inst vars, so the computation is something like
| ss | numIndexableFields := (ss := obj slotSize > 254 ifTrue: [obj overflowSlotSize] ifFalse: [ss]) - (obj format = 3 ifTrue: [self numIndexableFields: obj] ifFalse: [0]) In 64-bit VisualWorks I took a different approach, using an 8 bit field to hold either the number of named inst vars or the number of odd bytes. But this meant an 8 bit slot size, an 8 bit nun named inst vars/odd bytes and 8 header flags, leaving only 20 buts each for the class index and obj hash fields. With Squeak this isn't compelling because the collection hierarchy has been reworked to use Arrays instead of the older flat format (e.g. where OrderedCollection was indexable and has firstIndex and lastIndex).
Yes.
and what kinds of sizes have you seen?
best, Eliot |
Free forum by Nabble | Edit this page |