Hi Stef, I will help on the Squeak side. I suppose I could work on
that symmetry with Timestamp, but I'd rather talk about removing Timestamp instead first.. It doesn't really seem like we need two time-stamp classes, do we? On Fri, Apr 23, 2010 at 3:06 PM, Stéphane Ducasse <[hidden email]> wrote: > I'm turning this into tests! > Brent if you want to help fixing let me know. > I will focus now on the parsing problem. > > Stef > > On Apr 23, 2010, at 9:51 PM, Nicolas Cellier wrote: > >> 2010/4/23 Stéphane Ducasse <[hidden email]>: >>> Hi all >>> >>> I'm trying to fix some tests and I do not like the behavior of DateAndTime = >>> Comparing aDateAndTime and a something tries to convert the something in a dateAndTime automagically. >>> I find that not really good because it hides potential problem: manipulating string instead of objects. >>> >>> So I would like to have >>> (aDateAndTime offset: '0:12:00:00') = '1901-01-01T00:00:00+12:00' -> false >>> (aDateAndTime offset: '0:12:00:00') asString = '1901-01-01T00:00:00+12:00' -> true. >>> >>> What do you think. >>> >> >> I would expect this for = >> 1) Reflexive >> self assert: x = x. >> 2) Symmetric >> self assert: (x = y) = (y = x). >> 3) Transitive >> self assert: (x = y) & (y = z) ==> (x = z). >> >> I guess equality with a String at least breaks 2). >> >> Nicolas >> >> >>> Stef >>> _______________________________________________ >>> Pharo-project mailing list >>> [hidden email] >>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >>> >> >> _______________________________________________ >> Pharo-project mailing list >> [hidden email] >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > > _______________________________________________ > Pharo-project mailing list > [hidden email] > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > |
Indeed this would be good to fold TimeStamp in its superclass.
I was not aware of this situation but now we will fix it. May be some care is needed to keep the nice printout of TimeStamp Stef On Apr 23, 2010, at 11:36 PM, Chris Muller wrote: > Hi Stef, I will help on the Squeak side. I suppose I could work on > that symmetry with Timestamp, but I'd rather talk about removing > Timestamp instead first.. It doesn't really seem like we need two > time-stamp classes, do we? > > > > On Fri, Apr 23, 2010 at 3:06 PM, Stéphane Ducasse > <[hidden email]> wrote: >> I'm turning this into tests! >> Brent if you want to help fixing let me know. >> I will focus now on the parsing problem. >> >> Stef >> >> On Apr 23, 2010, at 9:51 PM, Nicolas Cellier wrote: >> >>> 2010/4/23 Stéphane Ducasse <[hidden email]>: >>>> Hi all >>>> >>>> I'm trying to fix some tests and I do not like the behavior of DateAndTime = >>>> Comparing aDateAndTime and a something tries to convert the something in a dateAndTime automagically. >>>> I find that not really good because it hides potential problem: manipulating string instead of objects. >>>> >>>> So I would like to have >>>> (aDateAndTime offset: '0:12:00:00') = '1901-01-01T00:00:00+12:00' -> false >>>> (aDateAndTime offset: '0:12:00:00') asString = '1901-01-01T00:00:00+12:00' -> true. >>>> >>>> What do you think. >>>> >>> >>> I would expect this for = >>> 1) Reflexive >>> self assert: x = x. >>> 2) Symmetric >>> self assert: (x = y) = (y = x). >>> 3) Transitive >>> self assert: (x = y) & (y = z) ==> (x = z). >>> >>> I guess equality with a String at least breaks 2). >>> >>> Nicolas >>> >>> >>>> Stef >>>> _______________________________________________ >>>> Pharo-project mailing list >>>> [hidden email] >>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >>>> >>> >>> _______________________________________________ >>> Pharo-project mailing list >>> [hidden email] >>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> >> >> _______________________________________________ >> Pharo-project mailing list >> [hidden email] >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> > |
Free forum by Nabble | Edit this page |