Re: [Pkg] The Trunk: System-edc.261.mcz

On 24.02.2010, at 10:46, [hidden email] wrote:
>
> Edgar J. De Cleene uploaded a new version of System to project The Trunk:
> http://source.squeak.org/trunk/System-edc.261.mcz
>
> pos := req url lastPositionOf: $/.
> packName := req url copyFrom: pos + 1 to: req url size.

That should be

        packName := req url copyAfterLast: $/

Please don't open-code the great collection methods we have.

- Bert -

On 2/24/10 8:50 AM, "Bert Freudenberg" <[hidden email]> wrote:

> That should be
>
> packName := req url copyAfterLast: $/
>
> Please don't open-code the great collection methods we have.
>
> - Bert -
>


Ok.

I do not put more in trunk.

Again I like you said some about in 3.10 we have less red test and the red
test grow from 8507 to 8472.

Edgar

On Wed, 24 Feb 2010, Edgar J. De Cleene wrote:

There's only one red test: SMDependencyTest >> #test2 and it was broken a
few months ago too, so I guess nothing changed between 8472 and
8507 regarding tests which raise an error.


Levente

>
> Edgar
>
>
>
>
>

On 24.02.2010, at 11:30, Edgar J. De Cleene wrote:
Huh, having a bad day? I have no intention of stopping you from committing to trunk. But wouldn't you agree that learning a better way to code is more efficient in the long run? Advise by experienced developers used to be appreciated here (remember Dan's "terseman" quips?).

In any case, I looked at this. Why do you want CodeLoader to load mcz and sar files? We have Installer, why is this needed?

In fact, this bypasses the SecurityManager in #installSourceFile:, which opens a big security hole. I guess this is unintentional, so what do you actually need this for?

- Bert -