Re: [Seaside] Someone to tackle failing tests in Squeak?

> Hi everyone,
>
> The Travis build on github for the (not yet released) Seaside 3.2.0 is failing for Squeak [1].
> Can someone working with Squeak have a look at this?
>
> Thanks!
> Johan
>
> [1] https://travis-ci.org/SeasideSt/Seaside/builds/40377175 <https://travis-ci.org/SeasideSt/Seaside/builds/40377175>
>

> Hi David,
>
> > Is there a way that I can download an image with the failing tests? Sorry
> > if this is dumb question, but I don't know much about travis-ci.
>
> Sorry, there is no way to save files on Travis CI. It???s a build service only.
> If you want to have a Squeak image with that version of Seaside, you should make it locally yourself.
>
> > These are the failing tests, so I expect it will be an easy problem to debug:
> >
> >  WAExternalFileLibraryTest debug: #testAsAbsoluteUrlRelativeTo.
> >  WAExternalFileLibraryTest debug: #testPathForRequest.
>
> Yes, it???s not much at all.
> Just that we don???t have the spare cycles to also maintain Squeak. I set up the build process to check, but we need someone to follow up and fix. Recently Tobias did some work but he might need some help.
>

> Hi David,
>
> > On 11 Nov 2014, at 01:44, David T. Lewis <[hidden email]> wrote:
> >
> > Is there a Metacello configuration for Seaside that I should be using to get
> > me closer to the correct configuration?
>
> Looks like Paul gave you the necessary instructions. Mind that the failing tests are in latest version of Grease, which is loaded for Seaside 3.1.x (stable) and Seaside 3.2.0 (which is in development).
> Btw, the Metacello instructions are also mentioned on http://seaside.st/download/pharo <http://seaside.st/download/pharo>
>
> Let me know if you need any help.

> On Thu, Nov 13, 2014 at 3:49 AM, David T. Lewis <[hidden email]> wrote:
> > On Tue, Nov 11, 2014 at 08:11:33AM +0100, Johan Brichau wrote:
> >> Hi David,
> >>
> >> > On 11 Nov 2014, at 01:44, David T. Lewis <[hidden email]> wrote:
> >> >
> >> > Is there a Metacello configuration for Seaside that I should be using to get
> >> > me closer to the correct configuration?
> >>
> >> Looks like Paul gave you the necessary instructions. Mind that the failing tests are in latest version of Grease, which is loaded for Seaside 3.1.x (stable) and Seaside 3.2.0 (which is in development).
> >> Btw, the Metacello instructions are also mentioned on http://seaside.st/download/pharo <http://seaside.st/download/pharo>
> >>
> >> Let me know if you need any help.
> >
> > Hi Johan,
> >
> > I am able to load Grease and Seaside 3.2.0 from the Metacello configurations,
> > which work very well. There is one glitch in loading Seaside, because
> > WASecureKeyGenerator class>>canSeed tries to use GRPharoPlaform subclass,
> > does not exist. But that seems to be related to the same issue that is
> > causing the original unit test failures that you are asking about.
>
> That should probably not be. I'll have a look.
>
> > The failures in WAExternalFileLibraryTest are related to GRPlatform.
> > GRPlatform is providing a range of compatibility methods that are
> > vectored through its concrete subclasses, which appear to include
> > implementations for the various flavors of Pharo, as well as for a
> > number of versions of Gemstone.
> >
> > I do not see any implementation of GRPlatform for Squeak. Presumably
> > this might be a class called GRSqueakPlatform, but I cannot find this
> > in any of the repositories, and the "GRPlatform current" idiom does
> > not answer anything appropriate for generic Squeak.
> >
> > Hopefully I am just confused (by far the most likely explanation), but
> > it seems that either I am not loading the right packages, or (worse)
> > I am trying to "debug" software that nobody has gotten around to writing
> > yet.
> >
> > Are these Travis CI failures actual failures, in the sense that they
> > are tests that used to work, but now are failing due to some new
> > problem? Or are they just an indication that GRSqueakPlatform does
> > not exist, and we need to find someone to implement it?
>
> Right GRSqueakPlatform does not exist. The clean solution would be to
> create a Grease-Squeak-Core and Grease-Tests-Squeak-Core with a
> GRSqueakPlatform and the necessary class extension methods. That would
> be very welcome.
> Because we don't have the resources to do this we currently treat
> Squeak as similar to Pharo 1.2 (or something) and load a
> GRPharoPlaform class and some class extensions. If the load scripts
> have a bug they don't even do that and you just GRPlatform with no
> subclass.

>
> On Fri, Nov 14, 2014 at 10:04 AM, David T. Lewis <[hidden email]>
> wrote:
>
> > On Thu, Nov 13, 2014 at 10:43:48AM +0100, Philippe Marschall wrote:
> > > On Thu, Nov 13, 2014 at 3:49 AM, David T. Lewis <[hidden email]>
> > wrote:
> > > > On Tue, Nov 11, 2014 at 08:11:33AM +0100, Johan Brichau wrote:
> > > >> Hi David,
> > > >>
> > > >> > On 11 Nov 2014, at 01:44, David T. Lewis <[hidden email]>
> > wrote:
> > > >> >
> > > >> > Is there a Metacello configuration for Seaside that I should be
> > using to get
> > > >> > me closer to the correct configuration?
> > > >>
> > > >> Looks like Paul gave you the necessary instructions. Mind that the
> > failing tests are in latest version of Grease, which is loaded for Seaside
> > 3.1.x (stable) and Seaside 3.2.0 (which is in development).
> > > >> Btw, the Metacello instructions are also mentioned on
> > http://seaside.st/download/pharo <http://seaside.st/download/pharo>
> > > >>
> > > >> Let me know if you need any help.
> > > >
> > > > Hi Johan,
> > > >
> > > > I am able to load Grease and Seaside 3.2.0 from the Metacello
> > configurations,
> > > > which work very well. There is one glitch in loading Seaside, because
> > > > WASecureKeyGenerator class>>canSeed tries to use GRPharoPlaform
> > subclass,
> > > > does not exist. But that seems to be related to the same issue that is
> > > > causing the original unit test failures that you are asking about.
> > >
> > > That should probably not be. I'll have a look.
> > >
> > > > The failures in WAExternalFileLibraryTest are related to GRPlatform.
> > > > GRPlatform is providing a range of compatibility methods that are
> > > > vectored through its concrete subclasses, which appear to include
> > > > implementations for the various flavors of Pharo, as well as for a
> > > > number of versions of Gemstone.
> > > >
> > > > I do not see any implementation of GRPlatform for Squeak. Presumably
> > > > this might be a class called GRSqueakPlatform, but I cannot find this
> > > > in any of the repositories, and the "GRPlatform current" idiom does
> > > > not answer anything appropriate for generic Squeak.
> > > >
> > > > Hopefully I am just confused (by far the most likely explanation), but
> > > > it seems that either I am not loading the right packages, or (worse)
> > > > I am trying to "debug" software that nobody has gotten around to
> > writing
> > > > yet.
> > > >
> > > > Are these Travis CI failures actual failures, in the sense that they
> > > > are tests that used to work, but now are failing due to some new
> > > > problem? Or are they just an indication that GRSqueakPlatform does
> > > > not exist, and we need to find someone to implement it?
> > >
> > > Right GRSqueakPlatform does not exist. The clean solution would be to
> > > create a Grease-Squeak-Core and Grease-Tests-Squeak-Core with a
> > > GRSqueakPlatform and the necessary class extension methods. That would
> > > be very welcome.
> > > Because we don't have the resources to do this we currently treat
> > > Squeak as similar to Pharo 1.2 (or something) and load a
> > > GRPharoPlaform class and some class extensions. If the load scripts
> > > have a bug they don't even do that and you just GRPlatform with no
> > > subclass.
> >
> > Squeak-dev:
> >
> > We need a volunteer to implement a Squeak-specific compatibility
> > class in Grease for Seaside, as described by Philippe above. Is
> > there someone who might be interested in implementing the missing
> > GRSqueakPlatform support?
> >
> > Most likely, the implementation could be modeled after the existing
> > Grease support for Pharo 1.2. Pharo 1.2 was basically the same as
> > Squeak 3.9, and the Squeak development stream is generally quite
> > good about maintaining compatibility of interfaces required by
> > external packages. I expect that this would not be a large project,
> > and it would be of great value for the Squeak community as well as
> > for Seaside.
> >
> > Thanks!
> >
> > Dave
> >
> > _______________________________________________
> > seaside mailing list
> > [hidden email]
> > http://lists.squeakfoundation.org/cgi-bin/mailman/listinfo/seaside
> >
>
>
>
> --
> jmck.seasidehosting.st