|
|
Many months ago had deja vu about 4 found elements where as far as my beleif goes are names od four created colour superclasses bugged two misplaced two trown out.. Send Vm-dev mailing list submissions to
[hidden email]
To subscribe or unsubscribe via the World Wide Web, visit
http://lists.squeakfoundation.org/mailman/listinfo/vm-dev
or, via email, send a message with subject or body 'help' to
[hidden email]
You can reach the person managing the list at
[hidden email]
When replying, please edit your Subject line so it is more specific
than "Re: Contents of Vm-dev digest..."
Today's Topics:
1. [OpenSmalltalk/opensmalltalk-vm] 7deac0: Unix(macOS)
SocketPlugin: (Eliot Miranda)
2. Still Failing: OpenSmalltalk/opensmalltalk-vm#2229 (Cog -
7deac02) (Travis CI)
3. Build failed: opensmalltalk-vm 1.0.2231 (AppVeyor)
4. Re: [OpenSmalltalk/opensmalltalk-vm] Unix(macOS)
SocketPlugin: (7deac02) (Tobias Pape)
----------------------------------------------------------------------
Message: 1
Date: Thu, 08 Oct 2020 21:27:11 -0700
From: Eliot Miranda <[hidden email]>
To: [hidden email]
Subject: [Vm-dev] [OpenSmalltalk/opensmalltalk-vm] 7deac0: Unix(macOS)
SocketPlugin:
Message-ID:
<OpenSmalltalk/opensmalltalk-vm/push/refs/heads/Cog/[hidden email]>
Content-Type: text/plain; charset=UTF-8
Branch: refs/heads/Cog
Home: https://github.com/OpenSmalltalk/opensmalltalk-vm
Commit: 7deac028aeeb769c8782242fc23bebdfaaa58e3d
https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/7deac028aeeb769c8782242fc23bebdfaaa58e3d
Author: Eliot Miranda <[hidden email]>
Date: 2020-10-08 (Thu, 08 Oct 2020)
Changed paths:
M platforms/unix/plugins/SocketPlugin/sqUnixSocket.c
M platforms/win32/plugins/SocketPlugin/sqWin32NewNet.c
Log Message:
-----------
Unix(macOS) SocketPlugin:
Fix sendDone/primtiveSocketSendDone/sqSocketSendDone on macOS. The select in
socketWritable does not answer true for writable sockets, presumably because
the select in aioPoll already has done. So have dataHandler (which is called
from aioPoll when the socket *is* writable) set a flag in privateSocketStruct
notifiedOfWritability and use this to avoid the wrongly unsuccessful call of
select in sqSocketSendDone. Clear notifiedOfWritability before any and all send/
write system calls.
Have sqWin32NewNet.c process the select result in its socketWritable in exactly
the same way as sqUnixSocket.c's.
I WELCOME ANY REVIEW OF THIS COMMIT!! Levente, Tobias, you might take a close
look at this one.
------------------------------
Message: 2
Date: Fri, 09 Oct 2020 04:38:05 +0000
From: Travis CI <[hidden email]>
To: [hidden email]
Subject: [Vm-dev] Still Failing: OpenSmalltalk/opensmalltalk-vm#2229
(Cog - 7deac02)
Message-ID:
<[hidden email]>
Content-Type: text/plain; charset="utf-8"
Build Update for OpenSmalltalk/opensmalltalk-vm
-------------------------------------
Build: #2229
Status: Still Failing
Duration: 10 mins and 25 secs
Commit: 7deac02 (Cog)
Author: Eliot Miranda
Message: Unix(macOS) SocketPlugin:
Fix sendDone/primtiveSocketSendDone/sqSocketSendDone on macOS. The select in
socketWritable does not answer true for writable sockets, presumably because
the select in aioPoll already has done. So have dataHandler (which is called
from aioPoll when the socket *is* writable) set a flag in privateSocketStruct
notifiedOfWritability and use this to avoid the wrongly unsuccessful call of
select in sqSocketSendDone. Clear notifiedOfWritability before any and all send/
write system calls.
Have sqWin32NewNet.c process the select result in its socketWritable in exactly
the same way as sqUnixSocket.c's.
I WELCOME ANY REVIEW OF THIS COMMIT!! Levente, Tobias, you might take a close
look at this one.
View the changeset: https://github.com/OpenSmalltalk/opensmalltalk-vm/compare/3f129f28147b...7deac028aeeb
View the full build log and details: https://travis-ci.org/github/OpenSmalltalk/opensmalltalk-vm/builds/734179980?utm_medium=notification&utm_source=email
--
You can unsubscribe from build emails from the OpenSmalltalk/opensmalltalk-vm repository going to https://travis-ci.org/account/preferences/unsubscribe?repository=8795279&utm_medium=notification&utm_source=email.
Or unsubscribe from *all* email updating your settings at https://travis-ci.org/account/preferences/unsubscribe?utm_medium=notification&utm_source=email.
Or configure specific recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/vm-dev/attachments/20201009/01001847/attachment-0001.html>
------------------------------
Message: 3
Date: Fri, 09 Oct 2020 05:02:17 +0000
From: AppVeyor <[hidden email]>
To: [hidden email]
Subject: [Vm-dev] Build failed: opensmalltalk-vm 1.0.2231
Message-ID: <[hidden email]>
Content-Type: text/plain; charset="utf-8"
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/vm-dev/attachments/20201009/e00d88b5/attachment-0001.html>
------------------------------
Message: 4
Date: Thu, 08 Oct 2020 23:20:23 -0700
From: Tobias Pape <[hidden email]>
To: OpenSmalltalk/opensmalltalk-vm
<[hidden email]>
Cc: Subscribed <[hidden email]>
Subject: Re: [Vm-dev] [OpenSmalltalk/opensmalltalk-vm] Unix(macOS)
SocketPlugin: (7deac02)
Message-ID:
<OpenSmalltalk/opensmalltalk-vm/commit/7deac028aeeb769c8782242fc23bebdfaaa58e3d/[hidden email]>
Content-Type: text/plain; charset="utf-8"
Manpage says otherwise:
> If the time limit expires, `select()` returns 0
And some tutorial says:
>On success, `select()` and `pselect()` return the number of file descriptors contained in the three returned descriptor sets (that is, the total number of bits that are set in `readfds`, `writefds`, `exceptfds`) which *may be zero if the timeout expires before anything interesting happens*.
I don't see how `select` should ever return `0` for a writable `fd`
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/7deac028aeeb769c8782242fc23bebdfaaa58e3d#commitcomment-43096552
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/vm-dev/attachments/20201008/faa334a1/attachment.html>
------------------------------
Subject: Digest Footer
_______________________________________________
Vm-dev mailing list
[hidden email]
http://lists.squeakfoundation.org/mailman/listinfo/vm-dev
------------------------------
End of Vm-dev Digest, Vol 172, Issue 12
***************************************
|
Locked
